From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: Emacs release branch warnings with GCC 8 Date: Mon, 30 Apr 2018 12:52:59 -0700 Organization: UCLA Computer Science Department Message-ID: References: <0d193e2f-bb41-ade7-fc31-5f353044f8cb@cs.ucla.edu> <83y3h4qybl.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1525117930 24234 195.159.176.226 (30 Apr 2018 19:52:10 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 30 Apr 2018 19:52:10 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Apr 30 21:52:05 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fDEqC-0006Bq-2g for ged-emacs-devel@m.gmane.org; Mon, 30 Apr 2018 21:52:04 +0200 Original-Received: from localhost ([::1]:33120 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fDEsI-0008N7-Ub for ged-emacs-devel@m.gmane.org; Mon, 30 Apr 2018 15:54:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46077) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fDErF-0008Lz-SI for emacs-devel@gnu.org; Mon, 30 Apr 2018 15:53:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fDErF-0008Kl-4c for emacs-devel@gnu.org; Mon, 30 Apr 2018 15:53:09 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:38276) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fDErA-0008G5-Iy; Mon, 30 Apr 2018 15:53:04 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 404A8160081; Mon, 30 Apr 2018 12:53:03 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id g1NSnD09pyD7; Mon, 30 Apr 2018 12:53:02 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 8C06A160085; Mon, 30 Apr 2018 12:53:02 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id WgmGzlay0vtO; Mon, 30 Apr 2018 12:53:02 -0700 (PDT) Original-Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 71DBE160081; Mon, 30 Apr 2018 12:53:02 -0700 (PDT) In-Reply-To: <83y3h4qybl.fsf@gnu.org> Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:224997 Archived-At: On 04/30/2018 12:38 PM, Eli Zaretskii wrote: > But a release tarball is not built with --enable-gcc-warnings by > default, right? Right. This is about people who build from a release tarball with --enable-gcc-warnings, and about people who build from Git (the latter appear to be a growing number....). > >> I've patched the master to fix this problem in commits >> 2b9ab8c8fba849da8bf2aa45e65b122bb937a6b3 and >> 8c3215e7a47e3caaa005bf573765ed63e0739b89, and could backport these >> patches (or a subset) to emacs-26 if there's interest. > I'm okay with the first one, but I don't understand how the warnings > you've shown are related to the ATTRIBUTE_MALLOC changes in the second > commit. The first commit enables -Wsuggest-attribute=malloc, and the ATTRIBUTE_MALLOC changes in the second commit then pacifies GCC in that area. We could change the first commit to not enable -Wsuggest-attribute=malloc and this would simplify the second commit, though we'd then be differing from Gnulib in the first commit.