From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.devel Subject: Re: master bbb92dde01 1/3: Add unit tests and documentation for Eshell pattern-based globs Date: Sun, 17 Apr 2022 12:44:35 -0700 Message-ID: References: <165018069752.13409.7508805625490994436@vcs2.savannah.gnu.org> <20220417073140.7A60AC01684@vcs2.savannah.gnu.org> <875yn8ca52.fsf@gnus.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------9FB9396428D825A1E7DA7626" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20843"; mail-complaints-to="usenet@ciao.gmane.io" To: Lars Ingebrigtsen , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Apr 17 21:45:53 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ngAqH-0005Ij-4l for ged-emacs-devel@m.gmane-mx.org; Sun, 17 Apr 2022 21:45:53 +0200 Original-Received: from localhost ([::1]:33304 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ngAqG-0003dh-0R for ged-emacs-devel@m.gmane-mx.org; Sun, 17 Apr 2022 15:45:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46346) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ngAp7-0002uZ-Jd for emacs-devel@gnu.org; Sun, 17 Apr 2022 15:44:41 -0400 Original-Received: from mail-pj1-x1033.google.com ([2607:f8b0:4864:20::1033]:35389) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ngAp5-0005RE-Tx for emacs-devel@gnu.org; Sun, 17 Apr 2022 15:44:41 -0400 Original-Received: by mail-pj1-x1033.google.com with SMTP id i24-20020a17090adc1800b001cd5529465aso10958221pjv.0 for ; Sun, 17 Apr 2022 12:44:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:references:from:message-id:date:mime-version:in-reply-to :content-language; bh=nvNNdx/DnEkuUvGjnFWwffMyB/94uAmlJ5ElZtqdP98=; b=lWyjV85PU3ea61x1qTRfxiM6XtQPiQhvMMRH6X0NPv8F6OU4TyWXayI1xEDDtjN0tF E7FIFJzwXOZYEcZpe2DGBR3OgTswoxOMXpsKb6YB2bFiLSXGsMnI2TNnNAAcMaueVyYu TF0x3ZGN75JdtPzlzAxD7S3ALFVmX0XWhRI7CK/gXyIO2111UyruIkERiF2Udn7+iJs3 /ccsEbjbvpP9ADwTJ37TG2fEoVbamfRBihfM8Wl8Nn/bPmakqjoB4BTtrnfxv3CsSbjT d7HGpUVCsv3KkE9UYkn2xt2HpzRrwBtmVsi68PGn9C5Bo/KQGoL1a9FuZNzI75o8NuE4 rRlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:references:from:message-id:date :mime-version:in-reply-to:content-language; bh=nvNNdx/DnEkuUvGjnFWwffMyB/94uAmlJ5ElZtqdP98=; b=tCP3PE/cx39HpPeN90Mr8V6AGJ/+zeYHWXp2otOBryIViOsdWmpbrZ/RIhWZmMCBdf QNUozvGgkAx2WoEQlGMHa+SbmZdKoUxsafbD57MxEYZX3zdB8eqyXFu9/gtL9M4F7Eow amS1z2KAcMJFeemLUJi+dm3wPOgpZq/C66HGWANLKs+6K3UmcPVN7H8NdMED+Xbqnn0E IG+dT02eWjIY0f3MNMvyNBn3CM8WpBzyQQfk7KI5k/fFP9X3/NsSarJs6W92M/tjGX7T LB/5PFIWP8ILydqtbIkrgrQmNx/Y2PhgGb32N8gfFns1rc1zfNrAEt34cQuUIA+zOyN3 8ENw== X-Gm-Message-State: AOAM5322HD0WP27uooZ4HRxqWkzVR+Pvh448AhuU/mM4MkLJmkq4Uy3h HekGBKDUb4tcBWts4j9pe28rQIhSiOU= X-Google-Smtp-Source: ABdhPJxOEtMcirGGUzaXLjmBNYGqh77kPxKGAbPE5Tuz8EKscDFXQy+yRiDsVy6hV4RB0Qwhtq4Ocw== X-Received: by 2002:a17:902:7684:b0:156:25b3:ef6b with SMTP id m4-20020a170902768400b0015625b3ef6bmr7942921pll.39.1650224678480; Sun, 17 Apr 2022 12:44:38 -0700 (PDT) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id l5-20020a056a0016c500b004f768db4c94sm9805692pfc.212.2022.04.17.12.44.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 17 Apr 2022 12:44:37 -0700 (PDT) In-Reply-To: <875yn8ca52.fsf@gnus.org> Content-Language: en-US Received-SPF: pass client-ip=2607:f8b0:4864:20::1033; envelope-from=jporterbugs@gmail.com; helo=mail-pj1-x1033.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:288571 Archived-At: This is a multi-part message in MIME format. --------------9FB9396428D825A1E7DA7626 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 4/17/2022 2:49 AM, Lars Ingebrigtsen wrote: > Eli Zaretskii writes: > >> branch: master >> commit bbb92dde01ec3fc46b24247fb2d181a21dbcc40a >> Author: Jim Porter >> Commit: Eli Zaretskii >> >> Add unit tests and documentation for Eshell pattern-based globs > > Something in this patch series leads to the following "make check" > failure (on Debian): > > Invalid read syntax: "#<" [snip] > It does not fail with "make em-pred-tests". Does the attached patch fix it? I think the issue was that `eshell-partial-let-func' got the original function value too early, so during macro-expansion, it would insert something like `#', which the parser didn't like. I've moved this bit later and it works for me. --------------9FB9396428D825A1E7DA7626 Content-Type: text/plain; charset=UTF-8; name="0001-Fix-Eshell-predicate-tests-when-running-from-make-ch.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="0001-Fix-Eshell-predicate-tests-when-running-from-make-ch.pa"; filename*1="tch" RnJvbSBkMDgyM2Y3N2NiOTQyNjc3ZDMyZDUyNjgzMDFmNTgxYjE5ZjVlYzA3IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFN1biwgMTcgQXByIDIwMjIgMTI6MzM6NTggLTA3MDAKU3ViamVjdDogW1BB VENIXSBGaXggRXNoZWxsIHByZWRpY2F0ZSB0ZXN0cyB3aGVuIHJ1bm5pbmcgZnJvbSAnbWFr ZSBjaGVjaycKCiogdGVzdC9saXNwL2VzaGVsbC9lbS1wcmVkLXRlc3RzLmVsIChlc2hlbGwt cGFydGlhbC1sZXQtZnVuYyk6IEdldApvcmlnaW5hbCBmdW5jdGlvbiBhZnRlciBtYWNyby1l eHBhbnNpb24uCi0tLQogdGVzdC9saXNwL2VzaGVsbC9lbS1wcmVkLXRlc3RzLmVsIHwgNiAr KystLS0KIDEgZmlsZSBjaGFuZ2VkLCAzIGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0p CgpkaWZmIC0tZ2l0IGEvdGVzdC9saXNwL2VzaGVsbC9lbS1wcmVkLXRlc3RzLmVsIGIvdGVz dC9saXNwL2VzaGVsbC9lbS1wcmVkLXRlc3RzLmVsCmluZGV4IGZiZjg5NDUyMTUuLjdmODhh YzQ0NzUgMTAwNjQ0Ci0tLSBhL3Rlc3QvbGlzcC9lc2hlbGwvZW0tcHJlZC10ZXN0cy5lbAor KysgYi90ZXN0L2xpc3AvZXNoZWxsL2VtLXByZWQtdGVzdHMuZWwKQEAgLTk1LDEzICs5NSwx MyBAQCBlc2hlbGwtcGFydGlhbC1sZXQtZnVuYwogICBgKGNsLWxldGYKICAgICAgICAsKG1h cGNhcgogICAgICAgICAgKGxhbWJkYSAob3ZlcnJpZGUpCi0gICAgICAgICAgIChsZXQgKChv cmlnLWZ1bmN0aW9uIChzeW1ib2wtZnVuY3Rpb24gKGNhciBvdmVycmlkZSkpKSkKLSAgICAg ICAgICAgICBgKChzeW1ib2wtZnVuY3Rpb24gIycsKGNhciBvdmVycmlkZSkpCisgICAgICAg ICAgIGAoKHN5bWJvbC1mdW5jdGlvbiAjJywoY2FyIG92ZXJyaWRlKSkKKyAgICAgICAgICAg ICAobGV0ICgob3JpZy1mdW5jdGlvbiAoc3ltYm9sLWZ1bmN0aW9uICMnLChjYXIgb3ZlcnJp ZGUpKSkpCiAgICAgICAgICAgICAgICAobGFtYmRhIChmaWxlICZyZXN0IHJlc3QpCiAgICAg ICAgICAgICAgICAgIChhcHBseQogICAgICAgICAgICAgICAgICAgKGlmIChhbmQgKHN0cmlu Z3AgZmlsZSkgKHN0cmluZy1wcmVmaXgtcCAiL2Zha2UvIiBmaWxlKSkKICAgICAgICAgICAg ICAgICAgICAgICAsKGNhZHIgb3ZlcnJpZGUpCi0gICAgICAgICAgICAgICAgICAgICxvcmln LWZ1bmN0aW9uKQorICAgICAgICAgICAgICAgICAgICBvcmlnLWZ1bmN0aW9uKQogICAgICAg ICAgICAgICAgICAgZmlsZSByZXN0KSkpKSkKICAgICAgICAgIG92ZXJyaWRlcykKICAgICAg LEBib2R5KSkKLS0gCjIuMjUuMQoK --------------9FB9396428D825A1E7DA7626--