From: Jim Porter <jporterbugs@gmail.com>
To: Lars Ingebrigtsen <larsi@gnus.org>, emacs-devel@gnu.org
Subject: Re: master bbb92dde01 1/3: Add unit tests and documentation for Eshell pattern-based globs
Date: Sun, 17 Apr 2022 12:44:35 -0700 [thread overview]
Message-ID: <c90408d0-958c-cd3f-f148-45fbef9a19bc@gmail.com> (raw)
In-Reply-To: <875yn8ca52.fsf@gnus.org>
[-- Attachment #1: Type: text/plain, Size: 793 bytes --]
On 4/17/2022 2:49 AM, Lars Ingebrigtsen wrote:
> Eli Zaretskii <eliz@gnu.org> writes:
>
>> branch: master
>> commit bbb92dde01ec3fc46b24247fb2d181a21dbcc40a
>> Author: Jim Porter <jporterbugs@gmail.com>
>> Commit: Eli Zaretskii <eliz@gnu.org>
>>
>> Add unit tests and documentation for Eshell pattern-based globs
>
> Something in this patch series leads to the following "make check"
> failure (on Debian):
>
> Invalid read syntax: "#<"
[snip]
> It does not fail with "make em-pred-tests".
Does the attached patch fix it? I think the issue was that
`eshell-partial-let-func' got the original function value too early, so
during macro-expansion, it would insert something like `#<subr
file-attributes>', which the parser didn't like. I've moved this bit
later and it works for me.
[-- Attachment #2: 0001-Fix-Eshell-predicate-tests-when-running-from-make-ch.patch --]
[-- Type: text/plain, Size: 1317 bytes --]
From d0823f77cb942677d32d5268301f581b19f5ec07 Mon Sep 17 00:00:00 2001
From: Jim Porter <jporterbugs@gmail.com>
Date: Sun, 17 Apr 2022 12:33:58 -0700
Subject: [PATCH] Fix Eshell predicate tests when running from 'make check'
* test/lisp/eshell/em-pred-tests.el (eshell-partial-let-func): Get
original function after macro-expansion.
---
test/lisp/eshell/em-pred-tests.el | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/test/lisp/eshell/em-pred-tests.el b/test/lisp/eshell/em-pred-tests.el
index fbf8945215..7f88ac4475 100644
--- a/test/lisp/eshell/em-pred-tests.el
+++ b/test/lisp/eshell/em-pred-tests.el
@@ -95,13 +95,13 @@ eshell-partial-let-func
`(cl-letf
,(mapcar
(lambda (override)
- (let ((orig-function (symbol-function (car override))))
- `((symbol-function #',(car override))
+ `((symbol-function #',(car override))
+ (let ((orig-function (symbol-function #',(car override))))
(lambda (file &rest rest)
(apply
(if (and (stringp file) (string-prefix-p "/fake/" file))
,(cadr override)
- ,orig-function)
+ orig-function)
file rest)))))
overrides)
,@body))
--
2.25.1
next prev parent reply other threads:[~2022-04-17 19:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <165018069752.13409.7508805625490994436@vcs2.savannah.gnu.org>
[not found] ` <20220417073140.7A60AC01684@vcs2.savannah.gnu.org>
2022-04-17 9:49 ` master bbb92dde01 1/3: Add unit tests and documentation for Eshell pattern-based globs Lars Ingebrigtsen
2022-04-17 19:44 ` Jim Porter [this message]
2022-04-17 19:51 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c90408d0-958c-cd3f-f148-45fbef9a19bc@gmail.com \
--to=jporterbugs@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.