From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Mendler Newsgroups: gmane.emacs.bugs Subject: bug#61274: 29.0.60; dabbrev-capf signals errors Date: Sat, 4 Feb 2023 18:30:41 +0100 Message-ID: References: <87o7q9y9oh.fsf@daniel-mendler.de> <83pmaptvt1.fsf@gnu.org> <83mt5ttlqu.fsf@gnu.org> <83fsbltko3.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17695"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 61274@debbugs.gnu.org To: Eli Zaretskii , Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Feb 04 18:31:22 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pOMNm-0004QV-6x for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 04 Feb 2023 18:31:22 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pOMNY-0006Vy-0h; Sat, 04 Feb 2023 12:31:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pOMNV-0006Vi-Oi for bug-gnu-emacs@gnu.org; Sat, 04 Feb 2023 12:31:06 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pOMNS-0003lZ-67 for bug-gnu-emacs@gnu.org; Sat, 04 Feb 2023 12:31:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pOMNS-0000qm-1Z for bug-gnu-emacs@gnu.org; Sat, 04 Feb 2023 12:31:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Daniel Mendler Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 Feb 2023 17:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61274 X-GNU-PR-Package: emacs Original-Received: via spool by 61274-submit@debbugs.gnu.org id=B61274.16755318513247 (code B ref 61274); Sat, 04 Feb 2023 17:31:02 +0000 Original-Received: (at 61274) by debbugs.gnu.org; 4 Feb 2023 17:30:51 +0000 Original-Received: from localhost ([127.0.0.1]:43375 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pOMNH-0000qJ-0P for submit@debbugs.gnu.org; Sat, 04 Feb 2023 12:30:51 -0500 Original-Received: from server.qxqx.de ([178.63.65.180]:41939 helo=mail.qxqx.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pOMNE-0000q3-Vf for 61274@debbugs.gnu.org; Sat, 04 Feb 2023 12:30:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=fGBF/SowRqhE+V5faCq1GsFI9aACsU4YxfMj4YL1ch4=; b=gOx+IVNI1jQeKkt+KF+/aTqKl7 TpjOnVsbQ0BnafYuG1sGJ1Zj7AVBbT8D7YXdHA++Chys/rAAXSxV128KfeIGYSozoRIUSBCftXl1F 05Vu8tCC30CNIbeC2YM+wAatDSbARYoWGtR5TkYiFu90qu1milr0fKBloz5CiB8iDfZQ=; Content-Language: en-US In-Reply-To: <83fsbltko3.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:254788 Archived-At: On 2/4/23 18:17, Eli Zaretskii wrote: >> From: Stefan Monnier >> Cc: Daniel Mendler , 61274@debbugs.gnu.org >> Date: Sat, 04 Feb 2023 12:13:27 -0500 >> >>> maybe dabbrev-capf is unsuitable to serve as the value of >>> completion-at-point-functions? >> >> As the name implies, it's a function designed specifically for use on >> `completion-at-point-functions`. Maybe dabbrev is not well adapted >> for use within a normal completion UI, but `dabbrev-capf` should do its >> best to obey the rules of `completion-at-point-functions`, so I think >> the behavior Daniel suggests is indeed what `dabbrev-capf` should try >> to do. > > Then there's something here that puzzles me: the recipe presented by > Daniel is basically identical to what dabbrev-completion does. And > yet dabbrev-completion produces different effects when invoked in the > same buffer with the same text at point. What is responsible for the > difference in behavior? You mean that the stringp type error does not occur? There is some code in `dabbrev-completion' which sets up Dabbrev (resets variables etc), so this is likely causing the difference. However the second issue still occurs even with `dabbrev-completion'. When I execute `dabbrev-completion' in a buffer where no completions are found, I get the message "dabbrev--abbrev-at-point: No possible abbreviation preceding point", while the message should be the usual "No match" from `completion-at-point'. At this point we are moving into problematic territory however, since Stefan reimplemented `dabbrev-completion' based on `dabbrev-capf'. We may want a more specific error message for `dabbev-completion', while we don't want any errors signalled by `dabbrev-capf', such that it conforms to the `completion-at-point-functions' contract. Daniel