From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#59622: 29.0.50; [PATCH] Regression in Eshell's handling of escaped newlines Date: Sat, 3 Dec 2022 17:41:50 -0800 Message-ID: References: <90faf628-390d-1094-2fcb-e6a23ac46da8@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26308"; mail-complaints-to="usenet@ciao.gmane.io" To: 59622@debbugs.gnu.org, eliz@gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 04 02:42:13 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p1e1F-0006iq-3s for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 04 Dec 2022 02:42:13 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p1e16-0000eH-3V; Sat, 03 Dec 2022 20:42:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p1e14-0000dV-UV for bug-gnu-emacs@gnu.org; Sat, 03 Dec 2022 20:42:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p1e14-0003DJ-Mi for bug-gnu-emacs@gnu.org; Sat, 03 Dec 2022 20:42:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p1e14-0004Sq-80 for bug-gnu-emacs@gnu.org; Sat, 03 Dec 2022 20:42:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 04 Dec 2022 01:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59622 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59622-submit@debbugs.gnu.org id=B59622.167011811917154 (code B ref 59622); Sun, 04 Dec 2022 01:42:02 +0000 Original-Received: (at 59622) by debbugs.gnu.org; 4 Dec 2022 01:41:59 +0000 Original-Received: from localhost ([127.0.0.1]:54447 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p1e11-0004Sc-HW for submit@debbugs.gnu.org; Sat, 03 Dec 2022 20:41:59 -0500 Original-Received: from mail-pg1-f182.google.com ([209.85.215.182]:37659) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p1e0z-0004SW-Uq for 59622@debbugs.gnu.org; Sat, 03 Dec 2022 20:41:58 -0500 Original-Received: by mail-pg1-f182.google.com with SMTP id v3so7511694pgh.4 for <59622@debbugs.gnu.org>; Sat, 03 Dec 2022 17:41:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:references:to:from :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=SzEx23/dOVdCVdOxELNIEOOdNlhBROa+CdGpWKCxbOY=; b=dNCjn8IUSR8XHKKxPQYWVp6YUv6TBprzFOFqrC1Wq9VNx6DjlROIgpvsxG27dlUx1s SNepFXOrxgN8ZLuM5IjErDipY7Up6FqJDBehjfRROrYp1vB4dzFzPQgld0MoiKQcC+Nh 0uVIge9e2G4ZG9ALsd8U78yIVdgxBbSiOB1Gl1refxqFdWnZEDaakLA31rIl70Mrqcrv DsCh3+gG8uizb0sfwV+we3ax+dkbXYvwuhJe9B+OI7YbnGKjG876+j7b0ISsKc/KEWCF oF1JHNxBsEe8Ogs82hCVc8iqnMqhNR3srx94cvGDvSNZ8b6Y9/E+Z22kCzh6aHeOuPvj xcjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:references:to:from :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SzEx23/dOVdCVdOxELNIEOOdNlhBROa+CdGpWKCxbOY=; b=g9zRvz/hXesq9MbEjeLv8LYOxJHxmVQwyDP7guvXwniDqMOm8RPfwRORmbiGLWSzPN e1Sx+H8cjPCTFSMW87UoinWfqo+Idrep19VAVbskrsYbYClCQlwIVU98jvHtXL5KRJbV TlA0IsagpP1fIeBm6YFibb7cSrV9YsPtyrIm1nZewKkLEmchF6nVYJehaJjSXSvigaa/ G1e9hydkcx7smDbgJwgDiCTVAG0L3JlFZ2BkqTGRulp9ekC69hXziNzyhqKcXZ3JVMJR EWsxXumoMZ6FmU2QYOK3mrHQkwNqDS2V+99Fu//J/VLBwwCRgEHktIyUTdibOL46fWMO nF+Q== X-Gm-Message-State: ANoB5png01pC6KlJR9Ega6Vk3VlwFnyCa15Ph3OP4m4b6O7sHDNZ79d6 tr1h83aUj9vWa32GKfvF/TvIUlsSOJw= X-Google-Smtp-Source: AA0mqf6fSTVUcIvk3Fj1hezzRDxziDunJfyN/6eg8xgCfxJePA/xGWG4Db5K0lKeu+jeIjrHKrGg7A== X-Received: by 2002:a63:5f83:0:b0:478:ab05:4da9 with SMTP id t125-20020a635f83000000b00478ab054da9mr1768414pgb.369.1670118111905; Sat, 03 Dec 2022 17:41:51 -0800 (PST) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id iw1-20020a170903044100b0017f5ad327casm7913434plb.103.2022.12.03.17.41.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 03 Dec 2022 17:41:51 -0800 (PST) Content-Language: en-US In-Reply-To: <90faf628-390d-1094-2fcb-e6a23ac46da8@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:249890 Archived-At: On 11/26/2022 4:36 PM, Jim Porter wrote: > Starting from "emacs -Q -f eshell": > >   # Emacs 28 >   ~ $ echo foo\ >   bar > >   foobar > >   # Emacs 29 >   ~ $ echo foo\ >   bar > >   foo >   bar > > That is, Emacs 28 used to treat escaped newlines in the way you'd expect > from other shells: it expands to the empty string. Now in Emacs 29, it > inserts a literal newline. Eli, since this is a regression from Emacs 28 (likely fallout from one of my changes to fix some longstanding bugs with quotes in Eshell), would my current patch be ok on the release branch? I can try to minimize the changes a bit further (I slightly refactored 'eshell-parse-backslash' to reduce repetition), but since it has unit tests, I think it should be pretty safe either way.