From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#57245: 29.0.50; M-> in a large XML file (without long lines) is slow Date: Wed, 17 Aug 2022 15:30:22 +0300 Message-ID: References: <18035574-1b50-62f4-7605-8cdb33204535@yandex.ru> <83tu6cdt7l.fsf@gnu.org> <913e0b46-7145-d39d-1fcd-bc17094e28f2@yandex.ru> <6688b0ad-54e1-4a59-e9b6-4cdc803a8359@yandex.ru> <4e2838b5-109e-7a27-0230-29dc6624b751@yandex.ru> <83bksjdru1.fsf@gnu.org> <83wnb7cbg7.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36019"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Cc: 57245@debbugs.gnu.org, monnier@iro.umontreal.ca To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 17 14:31:18 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oOICZ-0009BR-P8 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 17 Aug 2022 14:31:15 +0200 Original-Received: from localhost ([::1]:54710 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oOICY-000842-2S for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 17 Aug 2022 08:31:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48400) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oOICM-00083o-D8 for bug-gnu-emacs@gnu.org; Wed, 17 Aug 2022 08:31:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59976) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oOICM-0005Yd-4D for bug-gnu-emacs@gnu.org; Wed, 17 Aug 2022 08:31:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oOICL-0000JC-TJ for bug-gnu-emacs@gnu.org; Wed, 17 Aug 2022 08:31:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 17 Aug 2022 12:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57245 X-GNU-PR-Package: emacs Original-Received: via spool by 57245-submit@debbugs.gnu.org id=B57245.16607394351153 (code B ref 57245); Wed, 17 Aug 2022 12:31:01 +0000 Original-Received: (at 57245) by debbugs.gnu.org; 17 Aug 2022 12:30:35 +0000 Original-Received: from localhost ([127.0.0.1]:49725 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oOIBv-0000IX-2Z for submit@debbugs.gnu.org; Wed, 17 Aug 2022 08:30:35 -0400 Original-Received: from mail-wm1-f44.google.com ([209.85.128.44]:43610) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oOIBt-0000IB-3V for 57245@debbugs.gnu.org; Wed, 17 Aug 2022 08:30:33 -0400 Original-Received: by mail-wm1-f44.google.com with SMTP id ay39-20020a05600c1e2700b003a5503a80cfso877949wmb.2 for <57245@debbugs.gnu.org>; Wed, 17 Aug 2022 05:30:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc; bh=/lfv++YbCxMjkSrbSwbSgoSKXsAlOCN1yAmLuRRbkBI=; b=SozAeKL48ar+98//iDpESh8khTqQY67BaXcqjm3N4d0/o1pCJvatf+hpzpzmimm/oI GiyXACKLznfd7gc2o3yq4SHOlks9FULdpf9JRKVSjzK4Zu8smVHoS6FxulaT9b60Z20i nyJa+Z0YYJuJtkdQd/8jx7LeTciKZz50n5J7sVanKbaCC4rU7R+FRFjusw2LS+oq2mn9 Z5aJu3guxCg2MMFgdY797gjFkI7PTuef3eS/aiEU+tPuXPhblCKIrQD8WS4S5VAK71dK 8xnob3oMgKOibdKqjPmlbc9xVYaJ0EYMwUY/Q+yeQsTj6uIIyN1mGPr4b/x53F2/Ti1n r+tQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc; bh=/lfv++YbCxMjkSrbSwbSgoSKXsAlOCN1yAmLuRRbkBI=; b=Qd9n3oE50SBZq/dOtTgodF1yibmpmDMldxY/fxHRR4T6dHcwRIQu8ra5Afk0wlh2q6 q3Z6VrreKBMozfD8Wz1Q27oYXKxTExGKC9IS6hBW9NQbrGJevJgc+ckc1+peFlVzKasl rcGD4iv5o2PZz4xBUS9+FQUvQAw3jcD/fG53WqJjkEgUnMrNsKRW2jHOQVQsNyEoSnda RY8yjlqgIAM+mc8yTwUcC3ifPktII84fOX3CX6kQ84xAwFToJ57CEyoL24Lc5wSM4RoP eLVlycv8/RCKK9ci76FlD93+FZsdxRDNUIbVDFsdWJL5S3QjYrAmOmoH95Kh20mr+e8b aQBQ== X-Gm-Message-State: ACgBeo1RE6bICPAT7l9TWp2vxcbOsuU9OIS036YrBHvi7w5FfCF8uOYm GQfd2VyIWpHUCplyZMYpXF4= X-Google-Smtp-Source: AA6agR4OVEE+CVnfggjO0RCASu5L9XXDw8pLSXAdN7qdgbKwJ+GvouAy3iKsIYvrrfh3GuFbX4iFHw== X-Received: by 2002:a1c:6a0a:0:b0:3a5:bcad:f2cc with SMTP id f10-20020a1c6a0a000000b003a5bcadf2ccmr2053047wmc.74.1660739427068; Wed, 17 Aug 2022 05:30:27 -0700 (PDT) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id i8-20020a05600c2d8800b003a31ca9dfb6sm2308713wmg.32.2022.08.17.05.30.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Aug 2022 05:30:25 -0700 (PDT) Content-Language: en-US In-Reply-To: <83wnb7cbg7.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:240067 Archived-At: On 17.08.2022 15:16, Eli Zaretskii wrote: >> Date: Wed, 17 Aug 2022 14:46:46 +0300 >> Cc:57245@debbugs.gnu.org,monnier@iro.umontreal.ca >> From: Dmitry Gutov >> >> On 17.08.2022 14:36, Eli Zaretskii wrote: >>>> Date: Wed, 17 Aug 2022 01:20:38 +0300 >>>> Cc: Eli Zaretskii,57245@debbugs.gnu.org >>>> From: Dmitry Gutov >>>> >>>> Otherwise, syntax-wholeline-max seems to be doing its job fine: if I >>>> comment out the narrowing code in handle_fontified_prop (or switch to >>>> the branch I posted previously), two XML files -- one with long lines >>>> and one without (the files differ only by addition of newlines) -- show >>>> approximately the same delay on M->. >>> Doesn't syntax-wholeline-max only affect long lines? >> Its purpose is to handle the slowdown which occurred specifically on >> long lines because of >> font-lock-extend-region-functions/syntax-propertize-extend-region-functions. >> Now that it works -- I don't see any particular slowdowns on long lines, >> even with narrowing disabled. >> >> And the performance of M-> depends solely on the size of a file. In my >> XML test files, at least. > Is that a yes? Yes, it's a "yes". Stefan said: > font-lock does suffer from long lines, so the current code's handling > of font-lock makes some sense Meaning that narrowing around font-lock on long lines makes sense. And I replied that no, syntax-wholelines-max should be dealing with long lines issues in font-lock already. > Because if it is, then what does this have to do with > the issue of nXML not being scalable enough? Narrowing around font-lock shouldn't be conditioned on the presence of long lines. It either should be done unconditionally (with larger radius, I guess), or not at all.