all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Paul Eggert <eggert@cs.ucla.edu>
To: "Mattias Engdegård" <mattiase@acm.org>,
	"Stefan Monnier" <monnier@iro.umontreal.ca>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: [Emacs-diffs] master bc2a93d: Fix more regular expression typos
Date: Wed, 20 Mar 2019 09:24:29 -0700	[thread overview]
Message-ID: <c6e9c2f4-25f1-21c4-0929-0cf461a29af7@cs.ucla.edu> (raw)
In-Reply-To: <5E15A42D-D323-4BD3-8CA1-FCDBF7AC812C@acm.org>

[-- Attachment #1: Type: text/plain, Size: 135 bytes --]

On 3/20/19 6:33 AM, Mattias Engdegård wrote:
> The "\\\\" should be included.

Thanks to both of you. I installed the attached.


[-- Attachment #2: 0001-Fix-pcomplete-typo-in-recent-regex-typo-fix.patch --]
[-- Type: text/x-patch, Size: 964 bytes --]

From 8c30a1c51214058f28014953fc5b23d3cf9e3826 Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Wed, 20 Mar 2019 09:23:05 -0700
Subject: [PATCH] Fix pcomplete typo in recent regex typo fix

Problem reported by Stefan Monnier in:
https://lists.gnu.org/r/emacs-devel/2019-03/msg00682.html
* lisp/pcomplete.el (pcomplete-parse-comint-arguments):
Restore the trailing backslash (but two of them this time).
---
 lisp/pcomplete.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/pcomplete.el b/lisp/pcomplete.el
index ef285db57e..d0f2a2e24d 100644
--- a/lisp/pcomplete.el
+++ b/lisp/pcomplete.el
@@ -768,7 +768,7 @@ pcomplete-parse-comint-arguments
 	(push (point) begins)
         (while
             (progn
-              (skip-chars-forward "^ \t\n")
+              (skip-chars-forward "^ \t\n\\\\")
               (when (eq (char-after) ?\\)
                 (forward-char 1)
                 (unless (eolp)
-- 
2.20.1


      reply	other threads:[~2019-03-20 16:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20190319000234.5983.14812@vcs0.savannah.gnu.org>
     [not found] ` <20190319000239.D3DC7209E0@vcs0.savannah.gnu.org>
2019-03-20 12:26   ` [Emacs-diffs] master bc2a93d: Fix more regular expression typos Stefan Monnier
2019-03-20 13:01     ` Mattias Engdegård
2019-03-20 13:14       ` Stefan Monnier
2019-03-20 13:33         ` Mattias Engdegård
2019-03-20 16:24           ` Paul Eggert [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c6e9c2f4-25f1-21c4-0929-0cf461a29af7@cs.ucla.edu \
    --to=eggert@cs.ucla.edu \
    --cc=emacs-devel@gnu.org \
    --cc=mattiase@acm.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.