From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#33566: [PATCH] RE: bug#33566: 26; `group' :type for defcustom Date: Sat, 22 Dec 2018 15:35:40 -0800 (PST) Message-ID: References: <09947acd-9d28-44c8-9fa0-c5cd4a4ee569@default> <64ef54b7-8773-480c-943f-fcde67233332@default> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1545521646 4395 195.159.176.226 (22 Dec 2018 23:34:06 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 22 Dec 2018 23:34:06 +0000 (UTC) To: Phil Sainty , 33566@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Dec 23 00:34:01 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gaqmP-00011G-GJ for geb-bug-gnu-emacs@m.gmane.org; Sun, 23 Dec 2018 00:34:01 +0100 Original-Received: from localhost ([::1]:45288 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gaqoW-0003jM-4O for geb-bug-gnu-emacs@m.gmane.org; Sat, 22 Dec 2018 18:36:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58216) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gaqoP-0003j1-83 for bug-gnu-emacs@gnu.org; Sat, 22 Dec 2018 18:36:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gaqoM-0007BW-48 for bug-gnu-emacs@gnu.org; Sat, 22 Dec 2018 18:36:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:56056) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gaqoL-0007BE-TC for bug-gnu-emacs@gnu.org; Sat, 22 Dec 2018 18:36:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gaqoL-0007T2-MV for bug-gnu-emacs@gnu.org; Sat, 22 Dec 2018 18:36:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 22 Dec 2018 23:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33566 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 33566-submit@debbugs.gnu.org id=B33566.154552175028687 (code B ref 33566); Sat, 22 Dec 2018 23:36:01 +0000 Original-Received: (at 33566) by debbugs.gnu.org; 22 Dec 2018 23:35:50 +0000 Original-Received: from localhost ([127.0.0.1]:60314 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gaqoA-0007Sd-In for submit@debbugs.gnu.org; Sat, 22 Dec 2018 18:35:50 -0500 Original-Received: from userp2120.oracle.com ([156.151.31.85]:54296) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gaqo8-0007SO-Sy for 33566@debbugs.gnu.org; Sat, 22 Dec 2018 18:35:49 -0500 Original-Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id wBMNYt4k111606; Sat, 22 Dec 2018 23:35:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=GmQIjnlAr7BnvYCO6vGYMRukaSkUghI31gC/rUELAVQ=; b=C/qdS4gXWv38YqpvGbYimxQPXEVcqq5J8Pk3y5erptJRvDAh9pUcNza5hRVXGY/EgFs6 4jYHP+wxROd+7Q9XaWlweuj0bu7DNBpKfrykfYq48jOvFLkRafcKltXtQcutNev0bCpT uGxp4UxeujKuIgKClmslj76pmqFEnS7dGyIEnEO7RRgOJyVza6r43YNBy09+cZctLDMM ljtdZBXvJYDQuMb/Qtel7s+nG4paaasW+zbzRlu7gKprBnUMlLu0a/HzBHoPCpr3YFbM +LARh8pPHhAzHjSpt+jH9wl8axQm15D80Vbs7Gse6T9XyMjnAAM9fjrkaKl/cajOMtAY xQ== Original-Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by userp2120.oracle.com with ESMTP id 2phdwqhd5u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 22 Dec 2018 23:35:42 +0000 Original-Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id wBMNZfO6010618 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 22 Dec 2018 23:35:41 GMT Original-Received: from abhmp0010.oracle.com (abhmp0010.oracle.com [141.146.116.16]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id wBMNZfrf017351; Sat, 22 Dec 2018 23:35:41 GMT In-Reply-To: <64ef54b7-8773-480c-943f-fcde67233332@default> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4783.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9115 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=849 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1812220214 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:153763 Archived-At: ping. Could someone please consider committing this patch. Thx. > I think the patch below fixes the code bug. > diff -u wid-edit.el wid-edit-2018-12-03a-patched.el > --- wid-edit.el=092018-12-03 12:37:30.626331700 -0800 > +++ wid-edit-2018-12-03a-patched.el=092018-12-03 12:43:05.440329000 -0800 > @@ -2746,7 +2746,7 @@ > "A widget which groups other widgets inside." > :convert-widget 'widget-types-convert-widget > :copy 'widget-types-copy > - :format "%v" > + :format ":\n%v" > :value-create 'widget-group-value-create > :value-get 'widget-editable-list-value-get > :default-get 'widget-group-default-get