From: Mauro Aranda <maurooaranda@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>, Eli Zaretskii <eliz@gnu.org>
Cc: Philip Kaludercic <philipk@posteo.net>, 65401@debbugs.gnu.org
Subject: bug#65401: 30.0.50; custom-theme-directory :type could be enhanced
Date: Mon, 21 Aug 2023 11:46:26 -0300 [thread overview]
Message-ID: <c6c28c6e-0ae6-a56d-360f-80e6bfc00ebc@gmail.com> (raw)
In-Reply-To: <jwv350cd18n.fsf-monnier+emacs@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 522 bytes --]
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>>> > - :type 'string
>>> > + :type 'directory
>>> > :group 'customize
>>> > - :version "22.1")
>>> > + :version "30.1")
>>>
>>> Does the version tag have to be bumped, for a metadata change this
like?
>>
>> Probably not. AFAIK, this is only used for showing "new and changed"
>> options when users upgrade, and this change will be invisible at
>> user level.
>
> Agreed.
>
>
> Stefan
Sending an updated patch. Thanks.
[-- Attachment #2: 0001-Improve-type-of-custom-theme-directory-Bug-65401.patch --]
[-- Type: text/x-patch, Size: 786 bytes --]
From a79d01b62d46ffe121e0b7db26803d4fecc30105 Mon Sep 17 00:00:00 2001
From: Mauro Aranda <maurooaranda@gmail.com>
Date: Sun, 20 Aug 2023 10:39:49 -0300
Subject: [PATCH] Improve type of custom-theme-directory (Bug#65401)
* lisp/custom.el (custom-theme-directory): Make it of type directory.
---
lisp/custom.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/custom.el b/lisp/custom.el
index 083349e3591..5c134ff7f13 100644
--- a/lisp/custom.el
+++ b/lisp/custom.el
@@ -1208,7 +1208,7 @@ custom-theme-directory
directory. By default, Emacs searches for custom themes in this
directory first---see `custom-theme-load-path'."
:initialize #'custom-initialize-delay
- :type 'string
+ :type 'directory
:group 'customize
:version "22.1")
--
2.34.1
next prev parent reply other threads:[~2023-08-21 14:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-20 10:48 bug#65401: 30.0.50; custom-theme-directory :type could be enhanced Mauro Aranda
2023-08-20 11:12 ` Eli Zaretskii
2023-08-20 11:28 ` Mauro Aranda
2023-08-20 12:26 ` Eli Zaretskii
2023-08-20 12:35 ` Mauro Aranda
2023-08-20 13:32 ` Eli Zaretskii
2023-08-20 13:43 ` Mauro Aranda
2023-08-21 8:00 ` Philip Kaludercic
2023-08-21 11:05 ` Eli Zaretskii
2023-08-21 12:39 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-21 14:46 ` Mauro Aranda [this message]
2023-08-26 8:02 ` Eli Zaretskii
2023-08-21 14:41 ` Mauro Aranda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6c28c6e-0ae6-a56d-360f-80e6bfc00ebc@gmail.com \
--to=maurooaranda@gmail.com \
--cc=65401@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=philipk@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.