From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#15047: 24.3.50; doc string of `find-listp-find-files' etc. Date: Wed, 7 Aug 2013 15:06:23 -0700 (PDT) Message-ID: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1375913308 3349 80.91.229.3 (7 Aug 2013 22:08:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 7 Aug 2013 22:08:28 +0000 (UTC) To: 15047@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Aug 08 00:08:28 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1V7Bu7-00077P-FF for geb-bug-gnu-emacs@m.gmane.org; Thu, 08 Aug 2013 00:08:27 +0200 Original-Received: from localhost ([::1]:53952 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V7Bu7-000489-0G for geb-bug-gnu-emacs@m.gmane.org; Wed, 07 Aug 2013 18:08:27 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34379) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V7Btt-00046w-2t for bug-gnu-emacs@gnu.org; Wed, 07 Aug 2013 18:08:23 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V7Bti-0006Bx-CW for bug-gnu-emacs@gnu.org; Wed, 07 Aug 2013 18:08:13 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:51944) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V7Bti-0006Bh-9A for bug-gnu-emacs@gnu.org; Wed, 07 Aug 2013 18:08:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1V7Bth-0005c1-Od for bug-gnu-emacs@gnu.org; Wed, 07 Aug 2013 18:08:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 07 Aug 2013 22:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 15047 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.137591322321463 (code B ref -1); Wed, 07 Aug 2013 22:08:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 7 Aug 2013 22:07:03 +0000 Original-Received: from localhost ([127.0.0.1]:46260 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V7Bsj-0005a6-W6 for submit@debbugs.gnu.org; Wed, 07 Aug 2013 18:07:02 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:60444) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V7Bsg-0005ZT-Rc for submit@debbugs.gnu.org; Wed, 07 Aug 2013 18:06:59 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V7BsR-0005tE-ID for submit@debbugs.gnu.org; Wed, 07 Aug 2013 18:06:53 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:52235) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V7BsR-0005t8-F0 for submit@debbugs.gnu.org; Wed, 07 Aug 2013 18:06:43 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33915) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V7BsI-0003Tq-SM for bug-gnu-emacs@gnu.org; Wed, 07 Aug 2013 18:06:43 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V7BsA-0005r2-92 for bug-gnu-emacs@gnu.org; Wed, 07 Aug 2013 18:06:34 -0400 Original-Received: from userp1040.oracle.com ([156.151.31.81]:37924) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V7BsA-0005qp-2A for bug-gnu-emacs@gnu.org; Wed, 07 Aug 2013 18:06:26 -0400 Original-Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237]) by userp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id r77M6OKM015506 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 7 Aug 2013 22:06:25 GMT Original-Received: from aserz7021.oracle.com (aserz7021.oracle.com [141.146.126.230]) by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r77M6Nr7011938 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Wed, 7 Aug 2013 22:06:24 GMT Original-Received: from abhmt117.oracle.com (abhmt117.oracle.com [141.146.116.69]) by aserz7021.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r77M6NCP011932 for ; Wed, 7 Aug 2013 22:06:23 GMT X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8 (707110) [OL 12.0.6668.5000 (x86)] X-Source-IP: acsinet21.oracle.com [141.146.126.237] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:77064 Archived-At: The doc should distinguish between the files _within_ a directory, i.e., descending into its subdirectories recursively, and the files in a directory, i.e., not including in descendent directories. Pick any terminology you like, but please make it clear. =20 1. `find-listp-find-files': The doc of does not at all indicate that it in fact searches also subdirectories, recursively. 2. `find-lisp-find-files-internal': The doc says that "DIRECTORY-PREDICATE is used to decide...", but it does not say how, which is central to the meaning of DIRECTORY-PREDICATE. Just say that if DIRECTORY-PREDICATE returns non-nil then descend into subdirs etc. 3. `find-lisp-find-dired-internal': The doc says "Run find...". Please change this to "Run `find'...". 4. `find-lisp-find-dired-filter': Please replace the doc string with something correct or useful. The command does not "change the filter..." or anything of the kind. And please wrap function names with `...' in doc. 5. `find-lisp-format': Add a doc string. You "lifted" this from ls-lisp.el, but you neglected to lift the doc string along with it. 6. `find-lisp-time-index', `find-lisp-format-time': Replace the code comments with doc strings. This is the 21st century; we can afford the extra cost. ;-) 7. `find-lisp-find-dired-insert-file': Add a doc string. In GNU Emacs 24.3.50.1 (i686-pc-mingw32) of 2013-08-02 on ODIEONE Bzr revision: 113660 lekktu@gmail.com-20130802160313-rbi3o6322mz0m3ye Windowing system distributor `Microsoft Corp.', version 6.1.7601 Configured using: `configure --prefix=3D/c/Devel/emacs/binary --enable-checking=3Dyes,glyphs CFLAGS=3D-O0 -g3 LDFLAGS=3D-Lc:/Devel/emacs/lib CPPFLAGS=3D-Ic:/Devel/emacs/include'