From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#41897: 28.0.50; JavaScript comment filling with mhtml-mode Date: Tue, 23 Jun 2020 03:02:48 +0300 Message-ID: References: <20200620171827.7855.qmail@mail.muc.de> <87d05ta8z9.fsf@simenheg@gmail.com> <20200622191750.GA11506@ACM> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="45551"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 Cc: 41897@debbugs.gnu.org To: Alan Mackenzie , Simen =?UTF-8?Q?Heggest=C3=B8yl?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jun 23 02:03:17 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jnWPF-000BlK-6t for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 23 Jun 2020 02:03:17 +0200 Original-Received: from localhost ([::1]:56246 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jnWPE-00013m-28 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 22 Jun 2020 20:03:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48072) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jnWP0-00012w-UQ for bug-gnu-emacs@gnu.org; Mon, 22 Jun 2020 20:03:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51618) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jnWP0-00033r-Jp for bug-gnu-emacs@gnu.org; Mon, 22 Jun 2020 20:03:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jnWP0-0006ht-Fm for bug-gnu-emacs@gnu.org; Mon, 22 Jun 2020 20:03:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 23 Jun 2020 00:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41897 X-GNU-PR-Package: emacs Original-Received: via spool by 41897-submit@debbugs.gnu.org id=B41897.159287058025772 (code B ref 41897); Tue, 23 Jun 2020 00:03:02 +0000 Original-Received: (at 41897) by debbugs.gnu.org; 23 Jun 2020 00:03:00 +0000 Original-Received: from localhost ([127.0.0.1]:34931 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jnWOx-0006hc-Oh for submit@debbugs.gnu.org; Mon, 22 Jun 2020 20:02:59 -0400 Original-Received: from mail-wm1-f48.google.com ([209.85.128.48]:35352) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jnWOw-0006hP-5a for 41897@debbugs.gnu.org; Mon, 22 Jun 2020 20:02:58 -0400 Original-Received: by mail-wm1-f48.google.com with SMTP id g21so1397295wmg.0 for <41897@debbugs.gnu.org>; Mon, 22 Jun 2020 17:02:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=HG0KYTybEVXZrohukBPUETzvx/m87tK9/5U2p1Psjys=; b=rANv4B3ktJprkPWATn86TpOijA9JKNWGnIKqUy3zyWHVA06wI+aqWEj/qZgHdxZQfl HIx5WeOH+2ZbUmxrI8PmVQI5D/bkCsj5Wr1e4cs870f4d95VKn+PRNIZwDk3Ztz2ISOT CEeT81uAaSHhsbmyQfRue8VUjeYdawXxTnGgFQGkhYZf4rlRo+xSz0dkil8ctHOe0htW cdtkoiMHRwyXoN7omJx5AJtVcSVEKSzbVltpY+1dieG9L1+YJcLm86lz9DFjZiWjfZfv mR8TcSDiOaeQo+KKvE3uw+MzdYwF8rKPL0BYgposs95imbww6htK0fgZ71UulGSAAkFs B3NA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=HG0KYTybEVXZrohukBPUETzvx/m87tK9/5U2p1Psjys=; b=JLP7qgiaJpYPI9Q4TXQjYk9wRs3+Rc+H1sSG71oHjkgVcrPBpO0y+PBzXMS3WqBnbR v2exYUUTLn9mC8xo6t8WgW41HJ7HBj47iDKFkwXA/QYAJHklxDt5Jo+PuX1Q68Of6k1c tWcVgyMUCz6vGpjmWFLiJ1l5MN5wyyuBG103hb8o9Ba8fhctyx51a4IPxPy9tYnCSfrH qBq+hNKUedf4jsJxOgubB02HatJ1/KttKQGomjy819d0Ybf2Rt/kqsdXh7hB/tmcUrvw v7tYd+4rfa6XHz4OtKj/J8wDqEAtr515RqpSxlxKUSXp1I5AXeswRwgB8whbzeHU4U4H kS7g== X-Gm-Message-State: AOAM530cRXJorGj5a5L46eP3cNkPP51t/+0TquAw69UH7jYL2h4dXQZv +hEhzUgTK4pICZI+eEyoqOmvnkqx X-Google-Smtp-Source: ABdhPJxG00ENj8LkVxIt+UhZS1d0AKiaN19m7BbeBHaHP1XfEqqmP6vmF/yWY3U76/0hN+myLuZA2g== X-Received: by 2002:a7b:c248:: with SMTP id b8mr20257806wmj.2.1592870571658; Mon, 22 Jun 2020 17:02:51 -0700 (PDT) Original-Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id d9sm19734636wre.28.2020.06.22.17.02.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Jun 2020 17:02:50 -0700 (PDT) In-Reply-To: <20200622191750.GA11506@ACM> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:182296 Archived-At: Hi Alan, On 22.06.2020 22:17, Alan Mackenzie wrote: > +(defun c-foreign-truncate-lit-pos-cache (beg _end) > + "Truncate CC Mode's literal cache. > + > +This function should be added to the `before-change-functions' > +hook by major modes that use CC Mode's filling functionality > +without initializing CC Mode. Currently (2020-06) these are > +js-mode and mhtml-mode." > + (c-truncate-lit-pos-cache beg)) Could you explain this part? Is that literal cache looked up once during filling, or is it used multiple times during the execution of c-fill-paragraph? If the latter (and it does serve as a cache this way), perhaps it could be cleared once, at the beginning of c-fill-paragraph, instead of adding a runtime cost to every edit? Or if that's undesirable, js-fill-paragraph could do that. This way, I think it would automatically make it compatible with mmm-mode. Or at least more compatible.