From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#23455: 25.0.93; profiler-report doesn't configure xref for elisp Date: Tue, 30 Jul 2019 02:15:58 +0300 Message-ID: References: <87oa8li7cu.wl-jch@pps.univ-paris-diderot.fr> <87ftmqb4w0.fsf@mouse.gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="150579"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 Cc: 23455@debbugs.gnu.org To: Lars Ingebrigtsen , Juliusz Chroboczek Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jul 30 01:17:09 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hsEtB-000d4W-9E for geb-bug-gnu-emacs@m.gmane.org; Tue, 30 Jul 2019 01:17:09 +0200 Original-Received: from localhost ([::1]:56928 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hsEt9-0001Zj-MP for geb-bug-gnu-emacs@m.gmane.org; Mon, 29 Jul 2019 19:17:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48136) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hsEt4-0001Zc-Rc for bug-gnu-emacs@gnu.org; Mon, 29 Jul 2019 19:17:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hsEt3-0006Dz-Uy for bug-gnu-emacs@gnu.org; Mon, 29 Jul 2019 19:17:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40484) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hsEt3-0006Dr-RH for bug-gnu-emacs@gnu.org; Mon, 29 Jul 2019 19:17:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hsEt3-0005W1-La for bug-gnu-emacs@gnu.org; Mon, 29 Jul 2019 19:17:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 Jul 2019 23:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23455 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 23455-submit@debbugs.gnu.org id=B23455.156444217021121 (code B ref 23455); Mon, 29 Jul 2019 23:17:01 +0000 Original-Received: (at 23455) by debbugs.gnu.org; 29 Jul 2019 23:16:10 +0000 Original-Received: from localhost ([127.0.0.1]:49305 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hsEsD-0005Ub-Pu for submit@debbugs.gnu.org; Mon, 29 Jul 2019 19:16:09 -0400 Original-Received: from mail-wr1-f45.google.com ([209.85.221.45]:32849) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hsEsC-0005UA-7Q for 23455@debbugs.gnu.org; Mon, 29 Jul 2019 19:16:08 -0400 Original-Received: by mail-wr1-f45.google.com with SMTP id n9so63724134wru.0 for <23455@debbugs.gnu.org>; Mon, 29 Jul 2019 16:16:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=nCkwUpr4ay71MQztuB4exovwt53CPxH3ZIcPKn3i/HU=; b=Y+ESnwP8mO9LmwGvzwKVUzDEmEnJgVo+gIZ83HRs9aHEXKM0KSZgq4yIYqD/bSswoK RbFKmXF8BC5Ip1+wLNpVxN+LPyLAxlp9NKsz6iVO3F6xFC36h+Fug0GvplXsmjQ6pxTl +2k/0kjtGCcd8rrM1qAz4+1seno7g0WeFk/7XHnWHTI/VNt8QZSfGbsmEkQhjn4lXI7l W/etOJeN0VFpztiHOHR+IA1qMhbZTQ1aws0+Ql4MeTk8pThMtu0+hB4t7WDm7umSSWzm iHRIBLJGiJ2ZNKZt3ofPMNtYxHUD3Ewxv/zQpgQAqSDXxoL8ThzBiUifDTAo2yBu6gkw uZ0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=nCkwUpr4ay71MQztuB4exovwt53CPxH3ZIcPKn3i/HU=; b=YvC38mGW7y9H502pBPT4mZ41GJPdhzz368/Rc+b+JQJq5/nXmIX2CuYyrDxHQDdI/i QOLWufCJ58boylDnXIZTohHnRRNiRtFAbKbhfUE80PB/5r4wL/wZY4GnTChvWeu/iMIS le+9uPK0jgRsonLT5/zNBgXR7TcZKUj2K+UpEc4uvNaMyeH3ncsqusP2cIzKk/ptHXaL c1/wheRLdIyvjrcMqaftHMgtzrQa+SXEmqUxzMl+TYHCizh9VKjhfQsqvrJLizR8O8uU 35bQ9LT6ASYA5ZkI5AANkS0dnfC1RyKoorWVAirE2jW9o/kl4pnRWZPI09Xt6jMJeH0V z1Xw== X-Gm-Message-State: APjAAAWT2AMAiakp2vJCAa7kVwBc3KHOX08d+8YsNnuNIpK4TfXQebUA jCxdx/MMXtIbsiMqTxTlX8tyU3Zoc8c= X-Google-Smtp-Source: APXvYqzjaYkFoZW9Na2yp+iUhPmGpMdpA3FbSqNj0RcSm44C2HlGUlKRHHT8y8p5JmrXD7vocI9ALQ== X-Received: by 2002:adf:fa42:: with SMTP id y2mr41381132wrr.170.1564442162071; Mon, 29 Jul 2019 16:16:02 -0700 (PDT) Original-Received: from [192.168.1.3] ([185.105.174.23]) by smtp.googlemail.com with ESMTPSA id l25sm48174041wme.13.2019.07.29.16.15.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 29 Jul 2019 16:16:01 -0700 (PDT) In-Reply-To: <87ftmqb4w0.fsf@mouse.gnus.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:164079 Archived-At: On 28.07.2019 17:38, Lars Ingebrigtsen wrote: > The following patch seems to make `M-.' work as expected in the report > buffers, but I'm wholly unfamiliar with how xref works -- I just > cargo-culted the code in elisp-mode.el. > > Perhaps somebody who knows how this works can say whether it looks OK: It does, thanks. Please feel free to install. > diff --git a/lisp/profiler.el b/lisp/profiler.el > index ee11ff68c5..92495e2de8 100644 > --- a/lisp/profiler.el > +++ b/lisp/profiler.el > @@ -615,9 +615,12 @@ profiler-report-setup-buffer > (profiler-report-render-calltree)) > buffer)) > > +(defun profiler--xref-backend () 'elisp) You could also use elisp--xref-backend directly, but this way we'll have a direct place for future improvements.