all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dgutov@yandex.ru>
To: Steve Purcell <steve@sanityinc.com>, 48180@debbugs.gnu.org
Subject: bug#48180: ruby-mode.el: fix font lock for puts and printf
Date: Mon, 3 May 2021 13:17:48 +0300	[thread overview]
Message-ID: <c654efe1-8019-b29a-98f8-519fa113794b@yandex.ru> (raw)
In-Reply-To: <m2v980bpgi.fsf@sanityinc.com>

Hi Steve,

On 03.05.2021 04:01, Steve Purcell wrote:
> Both these methods can be called without arguments, so the font
> locking of "bare" calls to either is incorrect.  The fix is to
> font-lock them as for other kernel methods which accepts zero or more
> arguments.

Is that important? Like, is anybody likely to call either without args? 
font-lock is not a precise facility (that anything depends on), so we 
can afford to be wrong in 0.01% cases.

If we institute this principle, I suppose we'll need to do this for all 
functions that can work without args? In my testing, that's also:

p, open, loop, warn, print

Also note that your title says 'printf', but the patch said 'print'.





  parent reply	other threads:[~2021-05-03 10:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-03  1:01 bug#48180: ruby-mode.el: fix font lock for puts and printf Steve Purcell
2021-05-03  7:41 ` Lars Ingebrigtsen
2021-05-03 10:17 ` Dmitry Gutov [this message]
2021-05-03 16:42   ` Juri Linkov
2021-05-03 20:31     ` Steve Purcell
2021-05-03 20:42       ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c654efe1-8019-b29a-98f8-519fa113794b@yandex.ru \
    --to=dgutov@yandex.ru \
    --cc=48180@debbugs.gnu.org \
    --cc=steve@sanityinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.