From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.devel Subject: RE: Omitting :group [was: master 7936c8a: * lisp/mb-depth.el (minibuffer-depth-indicator): New face.] Date: Thu, 7 Jan 2021 16:18:55 +0000 (UTC) Message-ID: References: <<86c3f5d3-b2be-4573-a7a5-0c8d94c0d193@default>> <<838s94lp35.fsf@gnu.org>> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21398"; mail-complaints-to="usenet@ciao.gmane.io" Cc: gabriel376@hotmail.com, emacs-devel@gnu.org, juri@linkov.net To: Eli Zaretskii , Drew Adams Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jan 07 17:22:22 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kxY3I-0005RT-TA for ged-emacs-devel@m.gmane-mx.org; Thu, 07 Jan 2021 17:22:20 +0100 Original-Received: from localhost ([::1]:60776 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kxY3H-0000Wj-UW for ged-emacs-devel@m.gmane-mx.org; Thu, 07 Jan 2021 11:22:19 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59682) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kxY0A-0007Us-O6 for emacs-devel@gnu.org; Thu, 07 Jan 2021 11:19:06 -0500 Original-Received: from aserp2120.oracle.com ([141.146.126.78]:53716) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kxY05-0005Us-RX; Thu, 07 Jan 2021 11:19:05 -0500 Original-Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 107GIxZj121941; Thu, 7 Jan 2021 16:18:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=/1DaTS5IU1xsE+B9X7yjCY13sPJQ9praUO+/n81h2sc=; b=gwJMYiNJk+SZax4z+hUxvev5RRVe90ZhRRCAyxkGbPdjM5uNaJvvzA2FrmyDEUQGttCJ GC/lxrir/ZMvW9tx0Qd9hYp5RrOk2gbqrjJwWgIgJdiACB64NbNacbZTZR6+oTs2tdl+ fR2A1Wal3ovTdtYtC1TVx47Y2cB4NgvBHwWBZ++oLMCgHFBspcpQWiNrnPigtKZ3LYCw X9RTLZfPj49GoBBGZfBBlR7Kvt8H19DfoFjHd0jt77D4yvjaUp+a0+eFVA2op15jzXJs leILwkOTurN3FCfFqf03RIhwioEY+aeMiMfNLZHMGH/Km9IeAC2DW070cShnvZsQ9BPX Rg== Original-Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by aserp2120.oracle.com with ESMTP id 35wepmd3nc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 07 Jan 2021 16:18:59 +0000 Original-Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 107GGXnI026327; Thu, 7 Jan 2021 16:18:56 GMT Original-Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserp3030.oracle.com with ESMTP id 35v4re70wm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 07 Jan 2021 16:18:56 +0000 Original-Received: from abhmp0016.oracle.com (abhmp0016.oracle.com [141.146.116.22]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 107GIuUg017990; Thu, 7 Jan 2021 16:18:56 GMT In-Reply-To: <<838s94lp35.fsf@gnu.org>> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.5095.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9857 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 mlxscore=0 bulkscore=0 suspectscore=0 spamscore=0 adultscore=0 malwarescore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2101070098 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9857 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 bulkscore=0 spamscore=0 impostorscore=0 phishscore=0 lowpriorityscore=0 suspectscore=0 priorityscore=1501 mlxscore=0 malwarescore=0 clxscore=1015 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2101070098 Received-SPF: pass client-ip=141.146.126.78; envelope-from=drew.adams@oracle.com; helo=aserp2120.oracle.com X-Spam_score_int: -45 X-Spam_score: -4.6 X-Spam_bar: ---- X-Spam_report: (-4.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.246, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:262693 Archived-At: > > > This change causes a byte-compilation warning: > > > In toplevel form: > > > mb-depth.el:38:1: Warning: defface for > > > `minibuffer-depth-indicator' fails to specify > > > containing group > > > > IMHO, we should adopt and promote a guideline > > that it's a good, not a bad, idea to always > > include an explicit `:group'. >=20 > Aren't you confusing :group in defcustom with :group in defface? Perhaps I am (am I)? What's the difference? (elisp) `Common Keywords' suggests that its description of :group applies to "the next few sections-'defcustom', 'defgroup', etc." And node `Group Definitions' suggests that a group defined by `defgroup' applies to all of the group's members, and that such members are declared using `:group'. `:group' is specified for use in many constructs, in many nodes of the Elisp manual. Shouldn't its behavior (and usage guidelines) be the same everywhere? FWIW, I don't see any special description of=20 `:group' in the doc about `defface'. I do see, in other nodes, cross-references to nodes that introduce/define customization groups - but I don't see any such xref in the node for `defface'.