From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Mendler Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] (icomplete-vertical-mode): Add support for affixations and, annotations Date: Tue, 1 Jun 2021 13:27:41 +0200 Message-ID: References: <87zgwlb4xc.fsf@gmail.com> <617d06ca-27bf-2ae8-26eb-1042123499d3@daniel-mendler.de> <87pmxhb1rs.fsf@gmail.com> <23510125-37b9-e87e-3590-5322f44772ce@daniel-mendler.de> <87y2c5nhsr.fsf@mail.linkov.net> <87h7irss50.fsf@mail.linkov.net> <43d1599e-2ba9-2efb-45c3-76c67d29a69d@daniel-mendler.de> <87tumrgqrb.fsf@gmail.com> <87tumq92pe.fsf@mail.linkov.net> <87lf82g10g.fsf@gmail.com> <87y2c24lww.fsf@mail.linkov.net> <871r9t2lsy.fsf@mail.linkov.net> <22880197-6d05-c821-2c58-328ed3cfc02e@daniel-mendler.de> <87eedruui3.fsf@gmail.com> <8dd915fe-fe67-2a45-67ff-8aaa3e9b9aca@daniel-mendler.de> <878s3zuq47.fsf@gmail.com> <09f2a253-84ba-5cfd-552e-0b89109864a5@daniel-mendler.de> <875yyxaoxp.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8713"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Dmitry Gutov , "emacs-devel@gnu.org" , monnier@iro.umontreal.ca, Juri Linkov To: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jun 01 13:29:49 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lo2aj-00027A-E1 for ged-emacs-devel@m.gmane-mx.org; Tue, 01 Jun 2021 13:29:49 +0200 Original-Received: from localhost ([::1]:40022 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lo2ai-0000tZ-GN for ged-emacs-devel@m.gmane-mx.org; Tue, 01 Jun 2021 07:29:48 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46088) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lo2Z6-0008S8-HL for emacs-devel@gnu.org; Tue, 01 Jun 2021 07:28:08 -0400 Original-Received: from server.qxqx.de ([2a01:4f8:121:346::180]:47041 helo=mail.qxqx.de) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lo2Z2-0001QX-J7 for emacs-devel@gnu.org; Tue, 01 Jun 2021 07:28:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=LnoUXytXZ7+oEcI86dr4fZKRNKAjyTVZ+P6/h0qrp2o=; b=dDikvDT75hcCkuUkAHdYqS6Amn mwwlE7ivrUF5mAaqhdp3xc/82boSpI/5HX3qGU/5NHjMcZhs3tmGT6sn41NJ/liEd1Nxf30NIbzz+ hvD1TUjJCmM5AB/pCuL9CXZvhadQXIarNqq1R585dOr5A2oviUM9FXDssKCaTf3lhFCY=; In-Reply-To: <875yyxaoxp.fsf@gmail.com> Content-Language: en-US Received-SPF: pass client-ip=2a01:4f8:121:346::180; envelope-from=mail@daniel-mendler.de; helo=mail.qxqx.de X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:270190 Archived-At: On 6/1/21 11:56 AM, João Távora wrote: >> From my side the changes in your icomplete-vertical-mode-improvements >> branch are fine. > > I didn't get a terrible amount of feedback, but I spent the week testing > that branch, making small adjustments, and verifying that the default > Icomplete and Fido behaviour are unchanged. So I've now pushed the > icomplete-vertical-mode rework to master. I quite like it, to be > honest. I also added little filtered/total indicator idea found in > Vertico and many other completers. > > Here's a gif showing how to use it with Fido, my preferred option. To > try it out, just M-x fido-mode and M-x fido-vertical-mode together. Thanks! I just gave it another try. It looks good and feels similar to my Vertico. It works also well with Marginalia. * I observed an issue with the last candidate with `icomplete-scroll=t` - The candidate is one line off the minibuffer screen. * Is it possible to disable the index/count indicator? In Vertico I use `vertico-count-format` for that, if nil, the indicator is disabled. * Do you plan to add more scroll commands, scroll forward/backward by one page as Vertico has it? See https://github.com/minad/vertico#key-bindings for the Vertico keybindings. * Do you plan to support the `group-function`? Daniel