From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.bugs Subject: bug#56682: locked narrowing Date: Wed, 30 Nov 2022 10:11:17 +0000 Message-ID: References: <83r11fc80o.fsf@gnu.org> <83o7wjc6o2.fsf@gnu.org> <83lernc5gu.fsf@gnu.org> <83k076dd7d.fsf@gnu.org> <83czcyd8jf.fsf@gnu.org> <83a682d66r.fsf@gnu.org> <837d36ceno.fsf@gnu.org> <37dd2827f54f8bbda5e3@heytings.org> <735c1d5b-0d64-a8e1-3aaa-91fc0248abd3@yandex.ru> <97049541-f5b4-ed3b-b8de-7c0bdc86f0f5@yandex.ru> <6e305c9b-7702-133a-3347-f64db05ade3f@yandex.ru> <83mt89kt10.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40516"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 56682@debbugs.gnu.org, monnier@iro.umontreal.ca, dgutov@yandex.ru To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 30 11:12:18 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p0K4f-000AHA-9i for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 30 Nov 2022 11:12:17 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p0K4S-0005Ca-HY; Wed, 30 Nov 2022 05:12:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p0K4Q-00055k-Gm for bug-gnu-emacs@gnu.org; Wed, 30 Nov 2022 05:12:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p0K4Q-0007dL-21 for bug-gnu-emacs@gnu.org; Wed, 30 Nov 2022 05:12:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p0K4P-0006uL-Ud for bug-gnu-emacs@gnu.org; Wed, 30 Nov 2022 05:12:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Nov 2022 10:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56682 X-GNU-PR-Package: emacs Original-Received: via spool by 56682-submit@debbugs.gnu.org id=B56682.166980308226544 (code B ref 56682); Wed, 30 Nov 2022 10:12:01 +0000 Original-Received: (at 56682) by debbugs.gnu.org; 30 Nov 2022 10:11:22 +0000 Original-Received: from localhost ([127.0.0.1]:59990 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p0K3m-0006u4-6j for submit@debbugs.gnu.org; Wed, 30 Nov 2022 05:11:22 -0500 Original-Received: from heytings.org ([95.142.160.155]:37524) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p0K3j-0006tv-4n for 56682@debbugs.gnu.org; Wed, 30 Nov 2022 05:11:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1669803077; bh=Lg+f+UT1ZK6Po9DKahtHHNNp+W/WWNK5eEkUAVtw+4w=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=1BeDaRDEeius5yRD0U2t6o5DJytS/jb6uZaV1EJpg0d+W3pXODYJKAu6qLb06airB Z34Q7h4Fv/0xC5sR+KI5ZyIvvJ+AQBoXAaoCodCWwHfCKIexduSUlW0yd8aweVLpyI 2SNIoJ7zcEe0uGe8sNpRRGg910sOyhau2FZzY5fA9ovmuPOZlcovEOSqSvakY5wICd x1s4GxdIElduy/bQWZXdhkY+hxwmGfJkID5Nqu3DOdNjM584Rq3jWQBd28I3lZIWDy 98Sm0sFXd45awVnRKCHXU5wa+D4LGzWZ2uwnoGPdH9BEdFEqoYLMvMLl5flVGpZytP YRdaq21imkVUA== In-Reply-To: <83mt89kt10.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:249474 Archived-At: > > I think this is just one aspect of the issue. The loop under this > condition "punishes" large buffers with no long lines because we search > the entire buffer top to bottom. To make this scale better, I think we > should only search in some predefined vicinity of the window, perhaps > the same region to which we narrow the buffer when we do detect long > lines. We can then repeat the search if point moves far away from its > last value. > > There's no need to search the whole buffer, that will cause delays in > very large buffers for no good reason. > > We've talked about this a few months ago, and you said fixing this was > part of your todo. I think now is the time. > Yes, it was and still is part of my todo. At that point of time I was not at all expecting that Emacs 29 would be released three months later. What I had and still have in mind is too large a change for Emacs 29, so at first glance I think for now we'll have to live with the current solution. Note that, apart from Dmitry, nobody reported a problem with that detection mechanism, and Dmitry's recipe with which he spotted that problem does not reflect actual usage. And note that with the patch I just sent even Dmitry's recipe is fixed. I'll see if I can design something smaller which would be suitable for Emacs 29, however.