From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.bugs Subject: bug#56682: locked narrowing Date: Wed, 30 Nov 2022 13:52:48 +0000 Message-ID: References: <83r11fc80o.fsf@gnu.org> <83o7wjc6o2.fsf@gnu.org> <83lernc5gu.fsf@gnu.org> <83k076dd7d.fsf@gnu.org> <83czcyd8jf.fsf@gnu.org> <83a682d66r.fsf@gnu.org> <837d36ceno.fsf@gnu.org> <37dd2827f54f8bbda5e3@heytings.org> <735c1d5b-0d64-a8e1-3aaa-91fc0248abd3@yandex.ru> <97049541-f5b4-ed3b-b8de-7c0bdc86f0f5@yandex.ru> <6e305c9b-7702-133a-3347-f64db05ade3f@yandex.ru> <83h6yglguf.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24722"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 56682@debbugs.gnu.org, monnier@iro.umontreal.ca, dgutov@yandex.ru To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 30 14:54:12 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p0NXQ-0006CA-Ga for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 30 Nov 2022 14:54:12 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p0NWn-0004jC-St; Wed, 30 Nov 2022 08:53:33 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p0NWm-0004ew-GY for bug-gnu-emacs@gnu.org; Wed, 30 Nov 2022 08:53:32 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p0NWI-0003dM-4I for bug-gnu-emacs@gnu.org; Wed, 30 Nov 2022 08:53:30 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p0NWH-0005U4-S1 for bug-gnu-emacs@gnu.org; Wed, 30 Nov 2022 08:53:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Nov 2022 13:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56682 X-GNU-PR-Package: emacs Original-Received: via spool by 56682-submit@debbugs.gnu.org id=B56682.166981637121074 (code B ref 56682); Wed, 30 Nov 2022 13:53:01 +0000 Original-Received: (at 56682) by debbugs.gnu.org; 30 Nov 2022 13:52:51 +0000 Original-Received: from localhost ([127.0.0.1]:32925 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p0NW7-0005Tq-IO for submit@debbugs.gnu.org; Wed, 30 Nov 2022 08:52:51 -0500 Original-Received: from heytings.org ([95.142.160.155]:37798) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p0NW6-0005Tj-6H for 56682@debbugs.gnu.org; Wed, 30 Nov 2022 08:52:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1669816368; bh=a8B5rQEKXo9JyeN7vJWpJXhBVNPGM4TBDWIse6z5uxI=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=6bN9RsXiUzTPRbIClvyPZS9IFjHzbOsQcKVtVXTjXKXrG5U5iocJUnTo1Ko1bm5l3 5LHo4p6yHuYFuodtlQ+lOAAncEwNosaIn/0aFXcvnjc3EgcmbEVdvo9P1MbonL+0WL 8ENMXFAKRzZrPSJmqNA9qs4QD8q/bd6VqVFqOZElqEkolp+Yo2VuId1GLWDNi6UunX LRRW/rXiIrvxf3a+F3ivrA++XGj+RXi7VAsQNPuoujM9JOwWRF9MNNw3vaRkWwlGGp tuQF8VGuXuWtg5ofGF+9MCYfznj/YA3SSQ+As2s6EnqtSp7r6JpgiQkiQlWI6IEdge KRPix39IGiyVQ== In-Reply-To: <83h6yglguf.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:249498 Archived-At: >> After looking at this closely, it turns out that the change in >> 1c837c42c2 doesn't do what it was meant to do. Sigh... Dmitry, can >> you confirm that the following change fixes this? > > ??? You are reverting what I believe was a fix for bug#57207, right? > No, I'm not reverting, I'm fixing. The condition before 1c837c42c2 was "MODIFF - UNCHANGED_MODIFIED > 8", with 1c837c42c2 it became "CHARS_MODIFF - CHARS_UNCHANGED_MODIFIED > 8", which appeared correct at that time but is not, with the patch it becomes "CHARS_MODIFF - UNCHANGED_MODIFIED > 8". > > How did you reach the conclusion that the change doesn't do what it was > supposed to? please tell more about what you saw and your conclusions. > The first condition triggered the long line detection too much: it was triggered when the the only changes in the buffer were fontification changes. The second condition fixes that problem, but still triggers the long line detection too much: it is still triggered when the main (but not _only_) changes in the buffer are fontification changes, IOW, it is triggered even if a single character is inserted and "enough" fontification changes are made. The condition in the patch is correct: the long line detection mechanism is triggered only when many characters are inserted.