From: Wolfgang Scherer <Wolfgang.Scherer@gmx.de>
To: 37214@debbugs.gnu.org
Subject: bug#37214: [PATCH] vc-svn error messages are used as ignore list
Date: Wed, 28 Aug 2019 21:06:13 +0200 [thread overview]
Message-ID: <c5c548ef-0c74-4dc2-72ae-b9c068efa852@gmx.de> (raw)
In-Reply-To: <handler.37214.B.156701847419761.ack@debbugs.gnu.org>
[-- Attachment #1: Type: text/plain, Size: 23 bytes --]
Forgot the patch file.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Do-not-use-error-messages-as-list-of-ignored-files.patch --]
[-- Type: text/x-patch; name="0001-Do-not-use-error-messages-as-list-of-ignored-files.patch", Size: 1167 bytes --]
From 877dc0839bd4682488c8ea35e9f24a4445bc03fc Mon Sep 17 00:00:00 2001
From: Wolfgang Scherer <wolfgang.scherer@gmx.de>
Date: Wed, 28 Aug 2019 20:03:30 +0200
Subject: [PATCH] Do not use error messages as list of ignored files
* lisp/vc/vc-svn.el: (vc-svn-ignore-completion-table) Ignore buffer
contents, if exit status is not 0. Split buffer by lines.
---
lisp/vc/vc-svn.el | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lisp/vc/vc-svn.el b/lisp/vc/vc-svn.el
index 3c50c8f..f25a00d 100644
--- a/lisp/vc/vc-svn.el
+++ b/lisp/vc/vc-svn.el
@@ -366,8 +366,8 @@ FILE is a file wildcard, relative to the root directory of DIRECTORY."
(defun vc-svn-ignore-completion-table (directory)
"Return the list of ignored files in DIRECTORY."
(with-temp-buffer
- (vc-svn-command t t nil "propget" "svn:ignore" (expand-file-name directory))
- (split-string (buffer-string))))
+ (if (= (vc-svn-command t t nil "propget" "svn:ignore" (expand-file-name directory)) 0)
+ (split-string (buffer-string) "\n"))))
(defun vc-svn-find-admin-dir (file)
"Return the administrative directory of FILE."
--
2.7.4
next prev parent reply other threads:[~2019-08-28 19:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-28 18:54 bug#37214: [PATCH] vc-svn error messages are used as ignore list Wolfgang Scherer
[not found] ` <handler.37214.B.156701847419761.ack@debbugs.gnu.org>
2019-08-28 19:06 ` Wolfgang Scherer [this message]
2019-09-15 13:16 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5c548ef-0c74-4dc2-72ae-b9c068efa852@gmx.de \
--to=wolfgang.scherer@gmx.de \
--cc=37214@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.