From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#36526: 26.2; Open diff at current location (feature request with suggested code) Date: Thu, 16 Jan 2020 01:50:34 +0300 Message-ID: References: <35d4b535-1e93-ef31-ca63-044721c1314f@gmail.com> <875zk3t7ji.fsf@marxist.se> <875zhdh342.fsf@marxist.se> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="43043"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 Cc: 36526@debbugs.gnu.org To: Stefan Kangas , Campbell Barton Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 15 23:58:37 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1irrcT-000BAL-15 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 15 Jan 2020 23:58:37 +0100 Original-Received: from localhost ([::1]:33770 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1irrcS-0000Eq-2x for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 15 Jan 2020 17:58:36 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41609) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1irrV9-0003wX-Ry for bug-gnu-emacs@gnu.org; Wed, 15 Jan 2020 17:51:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1irrV8-0005A6-Ka for bug-gnu-emacs@gnu.org; Wed, 15 Jan 2020 17:51:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58720) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1irrV8-00059p-ET for bug-gnu-emacs@gnu.org; Wed, 15 Jan 2020 17:51:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1irrV8-0006hV-EF for bug-gnu-emacs@gnu.org; Wed, 15 Jan 2020 17:51:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 Jan 2020 22:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36526 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch moreinfo Original-Received: via spool by 36526-submit@debbugs.gnu.org id=B36526.157912864425735 (code B ref 36526); Wed, 15 Jan 2020 22:51:02 +0000 Original-Received: (at 36526) by debbugs.gnu.org; 15 Jan 2020 22:50:44 +0000 Original-Received: from localhost ([127.0.0.1]:36460 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1irrUp-0006h0-PX for submit@debbugs.gnu.org; Wed, 15 Jan 2020 17:50:44 -0500 Original-Received: from mail-lj1-f178.google.com ([209.85.208.178]:34579) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1irrUo-0006gn-53 for 36526@debbugs.gnu.org; Wed, 15 Jan 2020 17:50:43 -0500 Original-Received: by mail-lj1-f178.google.com with SMTP id z22so20433515ljg.1 for <36526@debbugs.gnu.org>; Wed, 15 Jan 2020 14:50:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=k+ArKV9h8rKRbi9dRukRROBbXnMk7kKaQneftydkRsQ=; b=UB3iUg6fCG1ivAtRETuNP3O6l5JyOac3n8zIETlfDctBxrdg2/ZOoVeEwEeRM19ycX ZyuhkCeBjFKtYNbTGbZqcW4SNjiswuLE8xAqiBbq5PxtsUvmqi5oxETXIZGbkbHFyUcT EFl7ENoGY6w0DcEmrETjUg3iji7h2/rcE/go0xFJJP1/hwl9bd0cQX3a09/iC74RvP1c A4v4gCx4uKx4HSoegCQ2ugaKQOiAevVhkgqAbqVO6LFwHWP2xicZY3nUryyegwSVj63j Y19u2m5pvYWG1WzGrVqnhqg0GZ/JhE3lLU2op94jYkUzSWB6grao9FD/Tn/on74Vey1L 7xSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=k+ArKV9h8rKRbi9dRukRROBbXnMk7kKaQneftydkRsQ=; b=NSVLGBbndAL0aNurGqw+OMyVV9Dy1oLsX2oF2UtzgsAihTNzq7OCWTu1sPZI/M0bGv Ot8L8CLOQ++/y4uAHNu1Zh4xtLem+fkEW3qkRAcp0ZLCRxyGlPgoYpNNwaZWgF52E+ef QiTmxAAvuO5GSHrcgp0q1a30zp/hMmB+pO/lDL6E9j0NJ9mKRwLbcSC9aTJOB/6oJrkW F2n6aLKa2BEQaS/z57FSJwHyCCac7bjkktNwdtw1tTF9kvtj46aIWnF0f6snFqJvJuLC vZceCd56VIDQswhIUyRxQXB2Se5gCwQfTWVq+SjnrVgVs1wrv0o1K2OL7XhsvDaY35Ux z92Q== X-Gm-Message-State: APjAAAVT3Jh7p1KFs0O7c0Hry+HiqL0LWjs4lLNhzQGV8nDL6DbwlVjM 59bDLqe8maGRe3OiP8GizoF+jgeZ2Y0= X-Google-Smtp-Source: APXvYqwBRsk9gBtwcs8ziCD5l6G0CHr26an77Bq+6BBa9RRGkJclBwsAvgSN5WL1E0HzkQ8KkM9U4Q== X-Received: by 2002:a2e:880c:: with SMTP id x12mr408533ljh.44.1579128635660; Wed, 15 Jan 2020 14:50:35 -0800 (PST) Original-Received: from [192.168.1.142] ([178.252.127.239]) by smtp.googlemail.com with ESMTPSA id s22sm9974643ljm.41.2020.01.15.14.50.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 15 Jan 2020 14:50:34 -0800 (PST) In-Reply-To: <875zhdh342.fsf@marxist.se> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:174678 Archived-At: On 15.01.2020 5:20, Stefan Kangas wrote: > I've watched your video, and I think it looks interesting. I would > think it useful enough to include, and it certainly helps that you are > willing to do the work to get it done. > > Unfortunately, I'm not a heavy vc user, so I don't feel fully > qualified to comment on this use case. > > Could someone else please take a look at this proposal and give > Campbell a more informed reply? Speaking of the "open diff at point" feature, it's very reminiscent of the feature in a package of mine: https://github.com/dgutov/diff-hl/blob/fb9eb1cd3c4c6ed24b93de1a7cfb369d2983be74/diff-hl.el#L373-L404 And the implementation is much shorter there. So far, I don't understand why. I would be happy to facilitate moving this feature to the core, but for obvious reasons (chiefly ease of review) I'd prefer to to be based off my own code. Or to see a good explanation why it's not a good choice. If the implementation in the package above doesn't cut it for some reasons, similarly I'd prefer to see a patch against that code rather than a full reimplementation. If feasible, of course.