From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mauro Aranda Newsgroups: gmane.emacs.bugs Subject: bug#64046: 30.0.50; Quoting in customize choice tags Date: Thu, 20 Jul 2023 16:11:33 -0300 Message-ID: References: <8ca48b5a-1619-8da8-ae3a-6ae96351a19d@gmail.com> <87v8eelh2s.fsf@gmx.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40917"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Cc: 64046@debbugs.gnu.org To: Stephen Berman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jul 20 21:12:12 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qMZ4O-000AKs-BP for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 20 Jul 2023 21:12:12 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qMZ4F-00081i-5f; Thu, 20 Jul 2023 15:12:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qMZ4E-00081U-1K for bug-gnu-emacs@gnu.org; Thu, 20 Jul 2023 15:12:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qMZ4D-0001gd-QC for bug-gnu-emacs@gnu.org; Thu, 20 Jul 2023 15:12:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qMZ4D-00063L-Lu for bug-gnu-emacs@gnu.org; Thu, 20 Jul 2023 15:12:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Jul 2023 19:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64046 X-GNU-PR-Package: emacs Original-Received: via spool by 64046-submit@debbugs.gnu.org id=B64046.168988030723221 (code B ref 64046); Thu, 20 Jul 2023 19:12:01 +0000 Original-Received: (at 64046) by debbugs.gnu.org; 20 Jul 2023 19:11:47 +0000 Original-Received: from localhost ([127.0.0.1]:59916 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qMZ3z-00062S-Bs for submit@debbugs.gnu.org; Thu, 20 Jul 2023 15:11:47 -0400 Original-Received: from mail-ot1-x32c.google.com ([2607:f8b0:4864:20::32c]:42405) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qMZ3u-000625-JH for 64046@debbugs.gnu.org; Thu, 20 Jul 2023 15:11:46 -0400 Original-Received: by mail-ot1-x32c.google.com with SMTP id 46e09a7af769-6b9f46ec07aso762384a34.1 for <64046@debbugs.gnu.org>; Thu, 20 Jul 2023 12:11:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689880297; x=1690485097; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/8znv7rzQ3wMcDAO1j4zSeqOZPB1vja/yly87ttlBEM=; b=pN+8DY7LA9DAVBADuLA1WRJ1SCqOBAbuzmsLCaJCcu6wyAdyecgrYkPm8eo7KRU3Re YlNgeyS6pQWQqkLyYcqIR969vFESwVtEL/Lg1nuHJeVNtN2wMANAJgkPwhautEzsZs3F hGp360PWJaCJ6dxGiHXSjz+VLD10XI56Cd81fA+x+ZL9bSPklLAXbXm2PBnTGfqyLIk+ yet/niN7C7/1p0WsK09zodJYkJK/4KQ1XvIQKa0PxuzsSh9pvnkwgzfVEvzwvEKsOhRt e7rxuNCgKuOS6wViu39z6jzrSXW4fwR8x6QqVngGevhe0gQK6mX9YeqrMyTQz7Uo1XWL aU5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689880297; x=1690485097; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/8znv7rzQ3wMcDAO1j4zSeqOZPB1vja/yly87ttlBEM=; b=lKlu+4jYwqLDByihLayqOp5rtoT1R6C1Jy9RRwzClSjalWSnnLQqaWoQOkhuS7LOh6 5HJz5EGOgktGjbHSg6yKKrF8tiwRSBJJOSJcQ7FnyU4xQpkMzALtruZTSkVxO0Um805/ ynACoEimy9QOEVxkiuXic+3aXwtclnIXfBpxYmGLd1Kb9KP1y8dayWB4xlPcMtBmUin0 Xb7Fg/D11wIGP4yEJ/P3Fs5h61HffCowtwvY1S0WqG0O9MOKn/8zn9/PDliXWV9CjJyC QsL37MDgUuiFX1aPfC6WMPyXkVG5ciAjZLN+YmKjtOljNNTYQJxXRBFrZ59EzM0S3mkW 2QLw== X-Gm-Message-State: ABy/qLY5zerkvRXOzKxwGw3mu4LYwx017WDpejBnaM3VUOXQFBT0Z1Vf mxEzT0fqMCfhG7tayTphnxQ= X-Google-Smtp-Source: APBJJlHScn7G99Bst8Ue9NuhK+qaYtaJ+URk2xJ6zHezceoJEQDU1qVo1pAW2c99kj1HQlpytNn3HA== X-Received: by 2002:a05:6830:78b:b0:6b9:57d2:8ec1 with SMTP id w11-20020a056830078b00b006b957d28ec1mr2718438ots.2.1689880296965; Thu, 20 Jul 2023 12:11:36 -0700 (PDT) Original-Received: from [192.168.0.234] ([186.127.128.249]) by smtp.gmail.com with ESMTPSA id q2-20020a9d7c82000000b006b73c264e30sm725452otn.17.2023.07.20.12.11.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Jul 2023 12:11:36 -0700 (PDT) Content-Language: en-US In-Reply-To: <87v8eelh2s.fsf@gmx.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:265636 Archived-At: Stephen Berman writes: > On Sat, 15 Jul 2023 10:20:17 -0300 Mauro Aranda wrote: > >> Turns out this code introduces regressions when customizing faces. >> >> With emacs -Q: >> M-x customize-face RET default >> Action the State button and choose: "For All Kinds of Displays" >> Action the Display menu and select "specific display" >> Wrong type argument: number-or-marker-p, "        " >> >> The substitute-command-keys operation is too destructive, and messes >> with things it shouldn't be modifying, like the :offset property of >> widgets in this case. > Sorry for not responding sooner; I was travelling and only now had time > to look into this.  If I debugged it correctly, the problem is that the > value of :extra-offset, 9, satisfies char-or-string-p, so then due to my > patch substitute-command-keys turns it into a string containing a TAB. No trouble at all.  And yes, that sounds correct to me. > The cases intended to be fixed by my patch are where strings with grave > quoting occur, which should be turned into strings with curve quoting. > If so, then testing for stringp suffices, and the attached patch avoids > the regression you found and gives the desired results for the other > cases discussed in this bug.  I don't know why I used char-or-string-p > instead of stringp in my original patch, and don't see a reason for it > now.  Or do you know of cases where testing for stringp is insufficient? I don't know, but I feel like stringp should suffice.  So please install your fix, and I will be alert if something else breaks.