From: Daniel Colascione <dancol@dancol.org>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: Stefan Monnier <monnier@iro.umontreal.ca>, emacs-devel@gnu.org
Subject: Re: [PATCH] Really prevent quitting in sensitive contexts
Date: Mon, 13 Apr 2020 23:56:14 -0700 [thread overview]
Message-ID: <c55941c2-319f-af05-01f0-d5c20fdebf11@dancol.org> (raw)
In-Reply-To: <87tv2tga3i.fsf@gmx.de>
On 3/12/20 3:07 AM, Michael Albinus wrote:
> Daniel Colascione <dancol@dancol.org> writes:
>
>>> Are there bug#NNN where these are discussed?
>>
>> No. The motiviation is Tramp inflooping after a quit because it uses
>> with-local-quit inside tramp-accept-process-output, which causes
>> tramp-wait-for-regexp to retry infinitely and quickly.
>>
>> I found *that* behavior trying to figure out why M-x compile over
>> Tramp was hanging not only Emacs, but also the SSH connection more
>> generally. I *think* it has something to do with compilation-filter
>> calling file-truename, which invokes Tramp's handler, which wants to
>> talk over the same SSH connection that's spewing compilation messages,
>> deadlocking something somewhere.
>
> Please write a bug report, it should be solved in Tramp.
No, it shouldn't. This use of with-local-quit can *never* be correct
because a stray C-g can *always* interfere with a filter. Don't do
long-running operations in process filters. Period. The fix isn't to
make quitting these operations possible in some defined manner. The fix
is not to do them in the first place.
next prev parent reply other threads:[~2020-04-14 6:56 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-12 2:05 [PATCH] Really prevent quitting in sensitive contexts Daniel Colascione
2020-03-12 2:20 ` Stefan Monnier
2020-03-12 2:32 ` Daniel Colascione
2020-03-12 10:07 ` Michael Albinus
2020-03-12 10:21 ` Robert Pluim
2020-03-12 10:33 ` Michael Albinus
2020-03-13 10:00 ` Michael Albinus
2020-04-14 6:56 ` Daniel Colascione [this message]
2020-04-14 8:40 ` Michael Albinus
2020-03-12 3:29 ` Óscar Fuentes
2020-03-12 7:21 ` Eli Zaretskii
2020-03-12 13:31 ` Richard Copley
2020-03-12 17:36 ` Drew Adams
2020-03-12 22:06 ` Stefan Monnier
2020-03-12 23:14 ` Richard Copley
2020-03-12 23:35 ` Stefan Monnier
2020-03-12 23:56 ` Richard Copley
2020-03-14 15:31 ` Drew Adams
2020-03-14 18:21 ` Stefan Monnier
2020-03-14 18:36 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c55941c2-319f-af05-01f0-d5c20fdebf11@dancol.org \
--to=dancol@dancol.org \
--cc=emacs-devel@gnu.org \
--cc=michael.albinus@gmx.de \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.