From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Florian Rommel Newsgroups: gmane.emacs.devel Subject: Re: Support fullscreen values fullheight and fullwidth on pgtk Date: Thu, 07 Jul 2022 20:52:53 +0200 Message-ID: References: <87r1477ggj.fsf@yahoo.com> <87sfom5f64.fsf@yahoo.com> <8735gl446y.fsf@yahoo.com> <763362fd85bae99fd8772ca219a7c3561200fb40.camel@florommel.de> <87czfn2a2r.fsf@yahoo.com> <83y1ybacpl.fsf@gnu.org> <789eeae59ff5b6b8ea6a86f2363aa87b4850fa17.camel@florommel.de> <221b39fb759fed7ca2b32b20c4fcab8508fb805b.camel@florommel.de> <87k08uv33z.fsf@yahoo.com> <87sfnhty8v.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-zYPkitaB8COiThseg7to" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18657"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Evolution 3.44.3 Cc: Eli Zaretskii , emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jul 07 21:18:09 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o9X0q-0004YM-L9 for ged-emacs-devel@m.gmane-mx.org; Thu, 07 Jul 2022 21:18:08 +0200 Original-Received: from localhost ([::1]:34650 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o9X0p-0002DP-BX for ged-emacs-devel@m.gmane-mx.org; Thu, 07 Jul 2022 15:18:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54658) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o9Wcx-0003dP-N9 for emacs-devel@gnu.org; Thu, 07 Jul 2022 14:53:27 -0400 Original-Received: from read.uberspace.de ([185.26.156.133]:40616) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o9Wcv-0001GV-L6 for emacs-devel@gnu.org; Thu, 07 Jul 2022 14:53:27 -0400 Original-Received: (qmail 3475 invoked by uid 990); 7 Jul 2022 18:53:16 -0000 Authentication-Results: read.uberspace.de; auth=pass (plain) In-Reply-To: <87sfnhty8v.fsf@yahoo.com> X-Rspamd-Bar: - X-Rspamd-Report: BAYES_HAM(-2.999993) MIME_GOOD(-0.1) MIME_BASE64_TEXT_BOGUS(1) MIME_BASE64_TEXT(0.1) X-Rspamd-Score: -1.999993 Original-Received: from unknown (HELO unkown) (::1) by read.uberspace.de (Haraka/2.8.28) with ESMTPSA; Thu, 07 Jul 2022 20:53:16 +0200 Received-SPF: pass client-ip=185.26.156.133; envelope-from=mail@florommel.de; helo=read.uberspace.de X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Thu, 07 Jul 2022 14:59:40 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:291933 Archived-At: --=-zYPkitaB8COiThseg7to Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 2022-07-04 at 10:20 +0800, Po Lu wrote: > Thanks, now installed. Unfortunately, I just discrovered that the change causes a problem with `toggle-frame-fullscreen'. `toggle-frame-fullscreen' saves the current window state and tries to restore it. Because GTK does not support setting fullheight or fullwidth (and we therefore ignore these values in (set-frame-parameter 'fullscreen)), we cannot change back once the fullscreen state changes from 'fullheight or 'fullwidth to 'fullboth. Apart from reverting the commit, we could fix this by setting the 'fullscreen parameter to nil and restoring the frame (this is the closest to fullheight and fullwidth we can get with gtk), see the attached patch. --=-zYPkitaB8COiThseg7to Content-Disposition: attachment; filename="0001-Fix-setting-fullscreen-frame-parameter-on-PGTK.patch" Content-Type: text/x-patch; name="0001-Fix-setting-fullscreen-frame-parameter-on-PGTK.patch"; charset="UTF-8" Content-Transfer-Encoding: base64 RnJvbSAxOWE3ZTZlZTNkZmQ5NGY1OWU1OGNmMjAzMmJlOTFjN2ZhZmY1YjYwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBGbG9yaWFuIFJvbW1lbCA8bWFpbEBmbG9yb21tZWwuZGU+CkRh dGU6IFRodSwgNyBKdWwgMjAyMiAxOTozNzoxOSArMDIwMApTdWJqZWN0OiBbUEFUQ0hdIEZpeCBz ZXR0aW5nIGZ1bGxzY3JlZW4gZnJhbWUgcGFyYW1ldGVyIG9uIFBHVEsKClRoaXMgZml4ZXMgYSBw cm9ibGVtIHdpdGggYHRvZ2dsZS1mcmFtZS1mdWxsc2NyZWVuJyB3aGljaCB0cmllcyB0bwpyZXNl dCB0aGUgcHJldmlvdXMgdmFsdWUgb2YgdGhlIGZyYW1lLXBhcmFtZXRlci4KCiogc3JjL3BndGt0 ZXJtLmMgKHNldF9mdWxsc2NyZWVuX3N0YXRlKTogU2V0IGZ1bGxzY3JlZW4gcGFyYW1ldGVyIHRv Cm5pbCBmb3IgZnVsbGhlaWdodCBhbmQgZnVsbHdpZHRoLgoqIGRvYy9saXNwcmVmL2ZyYW1lcy50 ZXhpIChTaXplIFBhcmFtZXRlcnMpOiBVcGRhdGUgZG9jdW1lbnRhdGlvbi4KLS0tCiBkb2MvbGlz cHJlZi9mcmFtZXMudGV4aSB8IDE5ICsrKysrKysrKystLS0tLS0tLS0KIHNyYy9wZ3RrdGVybS5j ICAgICAgICAgIHwgIDkgKysrKy0tLS0tCiAyIGZpbGVzIGNoYW5nZWQsIDE0IGluc2VydGlvbnMo KyksIDE0IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2RvYy9saXNwcmVmL2ZyYW1lcy50ZXhp IGIvZG9jL2xpc3ByZWYvZnJhbWVzLnRleGkKaW5kZXggZWQ1NmZhNzc3ZC4uNTI4ODZhZGE5MCAx MDA2NDQKLS0tIGEvZG9jL2xpc3ByZWYvZnJhbWVzLnRleGkKKysrIGIvZG9jL2xpc3ByZWYvZnJh bWVzLnRleGkKQEAgLTE3NDcsMTUgKzE3NDcsMTYgQEAgU2l6ZSBQYXJhbWV0ZXJzCiBUaGlzIHBh cmFtZXRlciBzcGVjaWZpZXMgd2hldGhlciB0byBtYXhpbWl6ZSB0aGUgZnJhbWUncyB3aWR0aCwg aGVpZ2h0CiBvciBib3RoLiAgSXRzIHZhbHVlIGNhbiBiZSBAY29kZXtmdWxsd2lkdGh9LCBAY29k ZXtmdWxsaGVpZ2h0fSwKIEBjb2Rle2Z1bGxib3RofSwgb3IgQGNvZGV7bWF4aW1pemVkfS5AZm9v dG5vdGV7T24gUEdUSyBmcmFtZXMsIHNldHRpbmcKLXRoZSB2YWx1ZXMgQGNvZGV7ZnVsbGhlaWdo dH0gYW5kIEBjb2Rle2Z1bGx3aWR0aH0gaGFzIG5vIGVmZmVjdC59ICBBCi1AZGZue2Z1bGx3aWR0 aH0gZnJhbWUgaXMgYXMgd2lkZSBhcyBwb3NzaWJsZSwgYSBAZGZue2Z1bGxoZWlnaHR9IGZyYW1l Ci1pcyBhcyB0YWxsIGFzIHBvc3NpYmxlLCBhbmQgYSBAZGZue2Z1bGxib3RofSBmcmFtZSBpcyBi b3RoIGFzIHdpZGUgYW5kCi1hcyB0YWxsIGFzIHBvc3NpYmxlLiAgQSBAZGZue21heGltaXplZH0g ZnJhbWUgaXMgbGlrZSBhIGBgZnVsbGJvdGgnJwotZnJhbWUsIGV4Y2VwdCB0aGF0IGl0IHVzdWFs bHkga2VlcHMgaXRzIHRpdGxlIGJhciBhbmQgdGhlIGJ1dHRvbnMgZm9yCi1yZXNpemluZyBhbmQg Y2xvc2luZyB0aGUgZnJhbWUuICBBbHNvLCBtYXhpbWl6ZWQgZnJhbWVzIHR5cGljYWxseQotYXZv aWQgaGlkaW5nIGFueSB0YXNrIGJhciBvciBwYW5lbHMgZGlzcGxheWVkIG9uIHRoZSBkZXNrdG9w LiAgQQotYGBmdWxsYm90aCcnIGZyYW1lLCBvbiB0aGUgb3RoZXIgaGFuZCwgdXN1YWxseSBvbWl0 cyB0aGUgdGl0bGUgYmFyIGFuZAotb2NjdXBpZXMgdGhlIGVudGlyZSBhdmFpbGFibGUgc2NyZWVu IHNwYWNlLgordGhlIHZhbHVlcyBAY29kZXtmdWxsaGVpZ2h0fSBhbmQgQGNvZGV7ZnVsbHdpZHRo fSByZXNldHMgdGhlIHBhcmFtZXRlcgordG8gbmlsLn0gIEEgQGRmbntmdWxsd2lkdGh9IGZyYW1l IGlzIGFzIHdpZGUgYXMgcG9zc2libGUsIGEKK0BkZm57ZnVsbGhlaWdodH0gZnJhbWUgaXMgYXMg dGFsbCBhcyBwb3NzaWJsZSwgYW5kIGEgQGRmbntmdWxsYm90aH0KK2ZyYW1lIGlzIGJvdGggYXMg d2lkZSBhbmQgYXMgdGFsbCBhcyBwb3NzaWJsZS4gIEEgQGRmbnttYXhpbWl6ZWR9CitmcmFtZSBp cyBsaWtlIGEgYGBmdWxsYm90aCcnIGZyYW1lLCBleGNlcHQgdGhhdCBpdCB1c3VhbGx5IGtlZXBz IGl0cwordGl0bGUgYmFyIGFuZCB0aGUgYnV0dG9ucyBmb3IgcmVzaXppbmcgYW5kIGNsb3Npbmcg dGhlIGZyYW1lLiAgQWxzbywKK21heGltaXplZCBmcmFtZXMgdHlwaWNhbGx5IGF2b2lkIGhpZGlu ZyBhbnkgdGFzayBiYXIgb3IgcGFuZWxzCitkaXNwbGF5ZWQgb24gdGhlIGRlc2t0b3AuICBBIGBg ZnVsbGJvdGgnJyBmcmFtZSwgb24gdGhlIG90aGVyIGhhbmQsCit1c3VhbGx5IG9taXRzIHRoZSB0 aXRsZSBiYXIgYW5kIG9jY3VwaWVzIHRoZSBlbnRpcmUgYXZhaWxhYmxlIHNjcmVlbgorc3BhY2Uu CiAKIEZ1bGwtaGVpZ2h0IGFuZCBmdWxsLXdpZHRoIGZyYW1lcyBhcmUgbW9yZSBzaW1pbGFyIHRv IG1heGltaXplZAogZnJhbWVzIGluIHRoaXMgcmVnYXJkLiAgSG93ZXZlciwgdGhlc2UgdHlwaWNh bGx5IGRpc3BsYXkgYW4gZXh0ZXJuYWwKZGlmZiAtLWdpdCBhL3NyYy9wZ3RrdGVybS5jIGIvc3Jj L3BndGt0ZXJtLmMKaW5kZXggYjI4M2NlZjdjZC4uOGU2OTg1ZGYzNSAxMDA2NDQKLS0tIGEvc3Jj L3BndGt0ZXJtLmMKKysrIGIvc3JjL3BndGt0ZXJtLmMKQEAgLTQ0MDEsNiArNDQwMSwxMCBAQCBz ZXRfZnVsbHNjcmVlbl9zdGF0ZSAoc3RydWN0IGZyYW1lICpmKQogICBHdGtXaW5kb3cgKndpZGdl dCA9IEdUS19XSU5ET1cgKEZSQU1FX0dUS19PVVRFUl9XSURHRVQgKGYpKTsKICAgc3dpdGNoIChm LT53YW50X2Z1bGxzY3JlZW4pCiAgICAgeworICAgIGNhc2UgRlVMTFNDUkVFTl9XSURUSDoKKyAg ICBjYXNlIEZVTExTQ1JFRU5fSEVJR0hUOgorICAgICAgLyogTm90IHN1cHBvcnRlZCBieSBndGsu CisgICAgICAgICBTZXQgaXQgdG8gbmlsIGluc3RlYWQsIHRvIG5vdCBicmVhayBgdG9nZ2xlLWZy YW1lLWZ1bGxzY3JlZW4nICovCiAgICAgY2FzZSBGVUxMU0NSRUVOX05PTkU6CiAgICAgICBndGtf d2luZG93X3VuZnVsbHNjcmVlbiAod2lkZ2V0KTsKICAgICAgIGd0a193aW5kb3dfdW5tYXhpbWl6 ZSAod2lkZ2V0KTsKQEAgLTQ0MTgsMTEgKzQ0MjIsNiBAQCBzZXRfZnVsbHNjcmVlbl9zdGF0ZSAo c3RydWN0IGZyYW1lICpmKQogICAgICAgZ3RrX3dpbmRvd19tYXhpbWl6ZSAod2lkZ2V0KTsKICAg ICAgIHN0b3JlX2ZyYW1lX3BhcmFtIChmLCBRZnVsbHNjcmVlbiwgUW1heGltaXplZCk7CiAgICAg ICBicmVhazsKLQotICAgIGNhc2UgRlVMTFNDUkVFTl9XSURUSDoKLSAgICBjYXNlIEZVTExTQ1JF RU5fSEVJR0hUOgotICAgICAgLyogTm90IHN1cHBvcnRlZCBieSBndGsuIElnbm9yZSB0aGVtLiAq LwotICAgICAgYnJlYWs7CiAgICAgfQogCiAgIGYtPndhbnRfZnVsbHNjcmVlbiA9IEZVTExTQ1JF RU5fTk9ORTsKLS0gCjIuMzcuMAoK --=-zYPkitaB8COiThseg7to--