From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#74361: [PATCH] New option xref-navigation-display-window-action Date: Tue, 19 Nov 2024 03:21:26 +0200 Message-ID: References: <86ldxkitjn.fsf@gnu.org> <5a2abf5e-011b-43d0-b34a-e06e354badc5@gutov.dev> <8634jrin5v.fsf@gnu.org> <86ikskvie0.fsf@gnu.org> <97e7ec85-7e5c-4aa4-a85f-b5f40adc8de6@gutov.dev> <8634jov5ir.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13667"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: rudalics@gmx.at, 74361@debbugs.gnu.org, juri@linkov.net To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 19 02:22:23 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tDCwg-0003O2-5z for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 19 Nov 2024 02:22:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tDCwQ-0006BE-7X; Mon, 18 Nov 2024 20:22:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tDCwN-0006Aq-CB for bug-gnu-emacs@gnu.org; Mon, 18 Nov 2024 20:22:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tDCwM-00042W-EH for bug-gnu-emacs@gnu.org; Mon, 18 Nov 2024 20:22:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=In-Reply-To:From:References:MIME-Version:Date:To:Subject; bh=7Mt/g4oiMdFokg0Dj+arR89jgZAgwGaQQa/htXwWyyk=; b=cIklshUC0UHQpKU6Z95hwP4ysGxJXQwA3LxBWpUQoc+h56tYPaEYalRztZ8aUfMczPnTmIZcdwAdjz/UT5Fsd1MUMQeRMBMWSWxnvF6zv9ZbwSD2Go511Uh9Jv22ORYswoPAA5hoL2niaMlXhLXmik4IuMkeOBn2EpiYdG5U1Be3g0q4Se1bjIssoYxtmkItdYWdka8Yv3fVs49vrL9rLepzckwyNTWGXAK36ANLpi4EhzoH7wG7PybIcWheFgS/m8Fba1cz68dpl5oMF4+dnI9gSZ4Fa0Q55UF2NxUwf8ATXkvcshnTwLkzkGb1RxAynhTObYiBWroVT4awNEEb2Q==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tDCwL-00063o-So for bug-gnu-emacs@gnu.org; Mon, 18 Nov 2024 20:22:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 19 Nov 2024 01:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74361 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 74361-submit@debbugs.gnu.org id=B74361.173197930023251 (code B ref 74361); Tue, 19 Nov 2024 01:22:01 +0000 Original-Received: (at 74361) by debbugs.gnu.org; 19 Nov 2024 01:21:40 +0000 Original-Received: from localhost ([127.0.0.1]:39846 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tDCvz-00062w-GQ for submit@debbugs.gnu.org; Mon, 18 Nov 2024 20:21:40 -0500 Original-Received: from fhigh-a4-smtp.messagingengine.com ([103.168.172.155]:40897) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tDCvw-00062e-7Y for 74361@debbugs.gnu.org; Mon, 18 Nov 2024 20:21:38 -0500 Original-Received: from phl-compute-09.internal (phl-compute-09.phl.internal [10.202.2.49]) by mailfhigh.phl.internal (Postfix) with ESMTP id DF1331140108; Mon, 18 Nov 2024 20:21:30 -0500 (EST) Original-Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-09.internal (MEProxy); Mon, 18 Nov 2024 20:21:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1731979290; x=1732065690; bh=7Mt/g4oiMdFokg0Dj+arR89jgZAgwGaQQa/htXwWyyk=; b= f/HRxm1RbXF7o4tMw2oBXoMIGgVmVroLbhTLHXiX+/4p3MLoOJ0UvU41XYQ0CrhL 9AQQ16cNkOAwWaRmCZl2+hf8EAZjJDrZjzqJquDpbEsKs7jPvMV09P2hXtFL51+6 i2HvzAUgW5JLNR0tyizDp6Gi93q1mcXcUWNunrAa6BHUKeeKyCM5tUGjHDBunPQh ddTaWG0Eo66YgZnwIX4U8zYvexbXUfcWaAEethCEk+zefUxr3R8aUisIAbazSB5Y syLby3AOwZ76+iRV+EkbqlRqwEAVEtuCf75qxLFmgNmhrjxBpWl8OGhoqH2ei87Z jFrLLuP/5tO2HV74xJ4eGQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1731979290; x= 1732065690; bh=7Mt/g4oiMdFokg0Dj+arR89jgZAgwGaQQa/htXwWyyk=; b=a FOy5El8LnnmAfpLyhiV3azuwlUwL3vaZ5pzS6NdFb9qQ7OYvEvTWH28KMiTI1Wd8 zLynf3KWbtm6aEi9b8RkJCfgMVJrR6HwpkeciwtKIgKlZMbhvapsI8u8WOQFbDD1 djZ7JaSrQuynf3snrSSJdFdynCa+m3hS9QulWE9P9IIRa4mhZNyUpFwmRZuXpIiY OsoP6Ei6rXEqpv2+rsfVrvadYwfw5FSsrrreC9dfBWP379Gq0FKY5HW2/GeX5GlZ I9eIdcj5hNKuVTGy+m9szDdeXq1C2cPxT5VwCGk0WHzq4JZ/dvGj+5HlGdBphREv fejC3E9RmdLpRq1nAaZqg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrfedugdefgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdpuffr tefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnth hsucdlqddutddtmdenucfjughrpefkffggfgfuvfevfhfhjggtgfesthejredttddvjeen ucfhrhhomhepffhmihhtrhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvg hvqeenucggtffrrghtthgvrhhnpeetudeljeegheetgfehgeejkeeuhedvveeikeeufedt vddtveefhfdvveegudejheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmh grihhlfhhrohhmpegumhhithhrhiesghhuthhovhdruggvvhdpnhgspghrtghpthhtohep gedpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepvghlihiisehgnhhurdhorhhgpd hrtghpthhtoheprhhuuggrlhhitghssehgmhigrdgrthdprhgtphhtthhopeejgeefiedu seguvggssghughhsrdhgnhhurdhorhhgpdhrtghpthhtohepjhhurhhisehlihhnkhhovh drnhgvth X-ME-Proxy: Feedback-ID: i07de48aa:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 18 Nov 2024 20:21:29 -0500 (EST) Content-Language: en-US In-Reply-To: <8634jov5ir.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:295620 Archived-At: On 18/11/2024 19:03, Eli Zaretskii wrote: >> IIUC your suggestion was: >> >> If non-nil, the `display-buffer' action for showing results of Xref >> commands. >> >> And those are commands belonging to the package (for the moment), and as >> such fitting the description. > > Not in my book (they are replacement commands), but feel free to find > better text. Okay, if the phrasing still makes sense to you with the above details, let's use this version. >>>> Also, there is a nuance: when the Xref buffer itself is shown (i.e. when >>>> there are multiple locations matching a xref-find-definitions search), >>>> we're not going to pass (category . xref) to display-buffer either - it >>>> is reserved for displaying the buffers of destination locations. >>> >>> And this is a separate issue, not related to the doc string? >> >> Still about the doc string. > > But not important enough to affect the first line of it. > >> If we say "showing results of Xref >> commands", then the Xref buffer with the list of locations also matches >> that description, doesn't it? Or rather it might be the first thing a >> user would think of - but our customization wouldn't apply to it >> immediately. > > The rest of the doc string could explain this subtlety. Fair point, thanks. Next step is to find the appropriate place for it. Maybe not a docstring if the user option to customize will be the global one (display-buffer-alist), but either in Commentary or somewhere in the manual. Speaking of the reference that we used for this solution, it seems that (category . comint) is only mentioned in NEWS and in the obsoletion message for 'display-comint-buffer-action'. There is also a hit for it in the manual, but only in the form "If the caller display-buffer passes a category as a symbol ...", not saying exactly that comint modes do or should do that. Maybe that's something to be fixed as well.