From: martin rudalics <rudalics@gmx.at>
To: Juri Linkov <juri@linkov.net>
Cc: Davor Rotim <drot@firemail.cc>, 39822@debbugs.gnu.org
Subject: bug#39822: 27.0.90; Cannot set *Completions* buffer height using display-buffer-alist
Date: Thu, 5 Mar 2020 10:13:13 +0100 [thread overview]
Message-ID: <c4cfc303-96e0-0836-b115-e2aab0cbd247@gmx.at> (raw)
In-Reply-To: <87pndrpt8t.fsf@mail.linkov.net>
>> IIUC it neither runs the hooks for temporary buffers nor does it obey
>> 'temp-buffer-resize-mode'.
>
> I don't know why it should run hooks and 'temp-buffer-resize-mode'.
> Why other clients of display-buffer don't need these hooks?
>
>>> and nothing more, without hassles of with-displayed-buffer-window.
>>> And still it fits the window nicely into the buffer height.
>>
>> How comes?
>
> Maybe this means it's possible to avoid using with-displayed-buffer-window?
>
>>> Why the above 3 commands couldn't do the same by abandoning
>>> with-displayed-buffer-window?
>>
>> It depends on how much of the stuff in 'temp-buffer-window-setup' and
>> 'temp-buffer-window-show' they really need.
>
> Maybe they need none of these?
'display-buffer--maybe-at-bottom' handles this by using
(let ((alist (append alist `(,(if temp-buffer-resize-mode
'(window-height . resize-temp-buffer-window)
'(window-height . fit-window-to-buffer))
,(when temp-buffer-resize-mode
'(preserve-size . (nil . t)))))))
The question is now whether we want to do that in one place (that is, in
the temporary buffer setup and show functions) or in many places (like
in the buffer display action functions).
martin
next prev parent reply other threads:[~2020-03-05 9:13 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-28 14:05 bug#39822: 27.0.90; Cannot set *Completions* buffer height using display-buffer-alist Davor Rotim
2020-02-29 7:53 ` martin rudalics
2020-02-29 15:26 ` Davor Rotim
2020-02-29 16:05 ` martin rudalics
2020-02-29 21:10 ` Juri Linkov
2020-03-01 8:52 ` martin rudalics
2020-03-01 23:29 ` Juri Linkov
2020-03-03 14:40 ` martin rudalics
2020-03-03 23:06 ` Juri Linkov
2020-03-04 17:30 ` martin rudalics
2020-03-04 23:58 ` Juri Linkov
2020-03-05 9:13 ` martin rudalics [this message]
2020-03-05 23:43 ` Juri Linkov
2020-03-09 9:02 ` martin rudalics
2020-03-12 22:54 ` Juri Linkov
2020-03-13 9:38 ` martin rudalics
2020-03-14 23:24 ` Juri Linkov
2020-03-15 17:49 ` martin rudalics
2020-03-15 23:47 ` Juri Linkov
2020-03-16 9:24 ` martin rudalics
2020-03-28 23:36 ` Juri Linkov
2020-03-29 9:10 ` martin rudalics
2020-03-29 22:57 ` Juri Linkov
2020-03-30 22:53 ` Juri Linkov
2020-03-31 8:38 ` martin rudalics
2020-04-02 21:50 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4cfc303-96e0-0836-b115-e2aab0cbd247@gmx.at \
--to=rudalics@gmx.at \
--cc=39822@debbugs.gnu.org \
--cc=drot@firemail.cc \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.