From: Dmitry Gutov <dgutov@yandex.ru>
To: "Simen Heggestøyl" <simenheg@gmail.com>
Cc: 22923@debbugs.gnu.org, Stefan Monnier <monnier@iro.umontreal.ca>
Subject: bug#22923: [PATCH] Support completion of attribute values in CSS mode
Date: Sun, 20 Mar 2016 03:17:12 +0200 [thread overview]
Message-ID: <c4a776a3-aad6-c4da-c4b3-4fb558972f85@yandex.ru> (raw)
In-Reply-To: <1458391338.13455.0@smtp.gmail.com>
Hi again, Simen,
On 03/19/2016 02:42 PM, Simen Heggestøyl wrote:
> Yes, it allows us to stay close to the CSS spec, which is my view is
> very valuable when maintaining these lists.
Sure, but by "current approach" I meant what Company does. Please clarify:
> Here is a concrete example: the value class `image' is defined as
> follows in the CSS Image Values spec [1]:
>
> <image> = <url> | <image-list> | <element-reference> | <gradient>
>
> Which translates naturally to:
>
> ("image" uri image-list element-reference gradient)
>
> It is not a CSS property, so it should go into the value class alist. It
> is referenced by the `border-image-source' property as well as the
> `bg-image' value class (which in turn is referenced by the
> `background-image' property and `bg-layer' value class).
If you were adding it to company-css, wouldn't you just add it to
company-css-value-classes? And then refer to it in background-image
value inside company-css-property-alist?
What the limitation of that approach? Do value classes in the spec refer
back to the actual properties sometimes?
> My point is that even though it would be possible to eliminate the need
> for this value class by expanding it where it is referenced, I think
> that by keeping it, it'll be much easier to make updates to it when the
> CSS spec changes. I think it is worth the added complexity.
I'm not sure I follow. Expanding it in company-css-property-alist?
next prev parent reply other threads:[~2016-03-20 1:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-06 13:53 bug#22923: [PATCH] Support completion of attribute values in CSS mode Simen Heggestøyl
2016-03-06 19:10 ` Dmitry Gutov
2016-03-09 19:01 ` Simen Heggestøyl
2016-03-11 1:25 ` Dmitry Gutov
2016-03-19 12:42 ` Simen Heggestøyl
2016-03-20 1:17 ` Dmitry Gutov [this message]
2016-03-21 9:14 ` Simen Heggestøyl
2016-03-21 11:02 ` Dmitry Gutov
2016-03-23 18:17 ` Simen Heggestøyl
2016-03-23 23:08 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4a776a3-aad6-c4da-c4b3-4fb558972f85@yandex.ru \
--to=dgutov@yandex.ru \
--cc=22923@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=simenheg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.