From: David Ponce <da_vid@orange.fr>
To: Alan Third <alan@idiocy.org>, Eli Zaretskii <eliz@gnu.org>,
64908@debbugs.gnu.org
Subject: bug#64908: 29.1; svg parse failure
Date: Sat, 5 Aug 2023 17:53:52 +0200 [thread overview]
Message-ID: <c44299ef-c35c-7893-0122-1f8bf4a3d5aa@orange.fr> (raw)
In-Reply-To: <ZM5nS6i5DMCYPHl1@idiocy.org>
On 05/08/2023 17:14, Alan Third wrote:
> On Sat, Aug 05, 2023 at 02:32:07PM +0200, David Ponce wrote:
>> On 05/08/2023 11:58, Alan Third wrote:
>> I did test your V2 patch, and it seems to work well.
>> I tend to agree with your reasoning, even if I am not enough a
>> librsvg expert to fully understand all the details.
>
> Thanks!
>
>> One case however is not working, when the svg image just specify
>> percentage for width and height without a viewbox, like this:
>>
>> '(image :type svg :data
>> "<svg xmlns=\"http://www.w3.org/2000/svg\" width=\"100%\" height=\"100%\">
>> <defs id=\"defs3051\">
>> <style type=\"text/css\" id=\"current-color-scheme\">
>> .ColorScheme-Text {
>> color:#232629;
>> }
>> </style>
>> </defs>
>> <path
>> style=\"fill:currentColor;fill-opacity:1;stroke:none\"
>> d=\"m7.707031 3l-.707031.707031 6.125 6.125 1.167969 1.167969-1.167969 1.167969-6.125 6.125.707031.707031 6.125-6.125 1.875-1.875-1.875-1.875-6.125-6.125\"
>> class=\"ColorScheme-Text\"
>> />
>> </svg>"
>> :scale 1)
>>
>> I can display a such image in firefox, gwenview, or inkscape, but not in Emacs.
>> I guess it works in applications that provide a default viewbox when not defined.
>> And it is failing in Emacs because no default viewbox is provided.
>
> Very strange, it works here. rsvg_handle_get_geometry_for_layer should
> handle this fine. I wonder if something subtle has changed with
> 2.56... I can't fine anything in the documentation to say this has
> changed...
>
> We can always provide an absolute fallback of 100x100 or something. I
> think that's what we used to do. But it would be good to know if
> something is actually broken here. Are you able to check the return
> value of rsvg_handle_get_geometry_for_layer and see if it's throwing
> up an error?
Using this image spec:
'(image :type svg :data
"<svg xmlns=\"http://www.w3.org/2000/svg\" width=\"100%\" height=\"100%\">
<defs id=\"defs3051\">
<style type=\"text/css\" id=\"current-color-scheme\">
.ColorScheme-Text {
color:#232629;
}
</style>
</defs>
<path
style=\"fill:currentColor;fill-opacity:1;stroke:none\"
d=\"m7.707031 3l-.707031.707031 6.125 6.125 1.167969 1.167969-1.167969 1.167969-6.125 6.125.707031.707031 6.125-6.125 1.875-1.875-1.875-1.875-6.125-6.125\"
class=\"ColorScheme-Text\"
/>
</svg>"
:scale 1 :width 22 :height 22)
rsvg_handle_get_geometry_for_layer returns 1, and insert-image displays
a black square of 22x22 pixels.
next prev parent reply other threads:[~2023-08-05 15:53 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-28 1:10 bug#64908: 29.1; svg parse failure Daniel Vianna
2023-07-28 6:05 ` Eli Zaretskii
[not found] ` <CAMLJ+NHO38NYGPctAj9MmMwy4tz8aSqHgLDWQhQaDm7FUP7Yqw@mail.gmail.com>
2023-07-28 11:00 ` Eli Zaretskii
2023-07-28 12:48 ` Visuwesh
2023-08-03 8:11 ` Eli Zaretskii
2023-08-03 19:16 ` David Ponce
2023-08-04 5:23 ` Eli Zaretskii
2023-08-04 7:55 ` David Ponce
2023-08-04 10:26 ` Eli Zaretskii
2023-08-04 16:23 ` David Ponce
2023-08-04 18:32 ` Alan Third
2023-08-04 19:08 ` Eli Zaretskii
2023-08-04 21:08 ` David Ponce
2023-08-05 8:30 ` David Ponce
2023-08-05 9:58 ` Alan Third
2023-08-05 10:07 ` Eli Zaretskii
2023-08-05 10:24 ` Alan Third
2023-08-05 10:41 ` Eli Zaretskii
2023-08-05 12:32 ` David Ponce
2023-08-05 15:14 ` Alan Third
2023-08-05 15:53 ` David Ponce [this message]
2023-08-05 16:02 ` Alan Third
2023-08-05 16:24 ` David Ponce
2023-08-05 16:31 ` Alan Third
2023-08-05 17:37 ` David Ponce
2023-08-05 17:39 ` Alan Third
2023-08-05 18:00 ` David Ponce
2023-08-05 18:31 ` Alan Third
2023-08-05 20:04 ` David Ponce
2023-08-08 13:58 ` David Ponce
2023-08-08 21:18 ` Alan Third
2023-08-08 22:22 ` David Ponce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c44299ef-c35c-7893-0122-1f8bf4a3d5aa@orange.fr \
--to=da_vid@orange.fr \
--cc=64908@debbugs.gnu.org \
--cc=alan@idiocy.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.