From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#23484: 25.1.50; undo doesn't work properly in xref-query-replace-in-results Date: Sun, 8 May 2016 23:26:19 +0300 Message-ID: References: <86d1owl682.fsf@yandex.ru> <87inyoxpz8.fsf@mail.linkov.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1462739245 13416 80.91.229.3 (8 May 2016 20:27:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 8 May 2016 20:27:25 +0000 (UTC) Cc: 23484@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun May 08 22:27:14 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1azVIH-0001yV-Cy for geb-bug-gnu-emacs@m.gmane.org; Sun, 08 May 2016 22:27:13 +0200 Original-Received: from localhost ([::1]:38010 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1azVIG-0002LG-IW for geb-bug-gnu-emacs@m.gmane.org; Sun, 08 May 2016 16:27:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55322) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1azVIB-0002GP-PQ for bug-gnu-emacs@gnu.org; Sun, 08 May 2016 16:27:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1azVI6-0005c3-NF for bug-gnu-emacs@gnu.org; Sun, 08 May 2016 16:27:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:59430) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1azVI6-0005bx-IW for bug-gnu-emacs@gnu.org; Sun, 08 May 2016 16:27:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1azVI6-0004EE-Dt for bug-gnu-emacs@gnu.org; Sun, 08 May 2016 16:27:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 08 May 2016 20:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23484 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23484-submit@debbugs.gnu.org id=B23484.146273918816206 (code B ref 23484); Sun, 08 May 2016 20:27:02 +0000 Original-Received: (at 23484) by debbugs.gnu.org; 8 May 2016 20:26:28 +0000 Original-Received: from localhost ([127.0.0.1]:43534 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1azVHY-0004DK-3d for submit@debbugs.gnu.org; Sun, 08 May 2016 16:26:28 -0400 Original-Received: from mail-wm0-f42.google.com ([74.125.82.42]:38245) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1azVHX-0004D8-4g for 23484@debbugs.gnu.org; Sun, 08 May 2016 16:26:27 -0400 Original-Received: by mail-wm0-f42.google.com with SMTP id g17so155416667wme.1 for <23484@debbugs.gnu.org>; Sun, 08 May 2016 13:26:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=nUynnEEa3rxtec2fyiCsK/7A46pcWKsgq3/j658O+fs=; b=ef4qsC8vxiZrbDH9FhCIy8sBveNaviPa3mE9lxlXx/hffNnfg+LQFVnrIjp5KsupjT m3QLz+ssDl75vzP3yRdhX7fYGN+AuIa2WhR4YpSQER3MCvMHFLFP8sknsTIb0syvUnbQ XqtTk7Zi3meruvDxytlqnkrzCSrK14Q5vQleoaFRocuMXX+OXXOkWQxYFznYJ4ZpOq8N 4wPNv9H0Wq+SgnX5g1pxsKfLxBHIMInyGmxyviUdXuNs2G/w/+yYD4mGhyaef1su0oXd wykTR/v/ilMG1ZSLEcTakoGRSdd/BkHIs5H6QkC9+fU/fUjD3sYsZCwU6bgIEHE0BceX OHZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=nUynnEEa3rxtec2fyiCsK/7A46pcWKsgq3/j658O+fs=; b=nLxVaI7svTw07Iu5D3lhFxKQt6MbXN3wsYOv2I5+Z18aogWYY8FnYUrwvxEjhcODQi 7QlKNRa9KV/wgLLqFnSn+9owt99PBjDxINysl6hJJA0dV2Wj4iZ4xYC0nD/yegxhqF01 Sr6hknbWt/Z85VJk/qrfQDM6ran8TN3FDcaJIw8Z0g8N5WarsTyrp4s0qZb637zTkgxh Oeeux9q7dH0hHM3A70kCneelp0+yScKyYRbHhXoJjyQB0VOmVGNLAXIKStXNu94uSvec 3tZqeaRWGXLw/eu+P9fnjlq7Ey4XhUMHIuU6Ijj89bIw42W/Rc6/wPFVhtIwFKMuAAZz Z2iQ== X-Gm-Message-State: AOPr4FW0AkOj5uZk1PGRdYk52EgKB5AoZ9URwEUMnu+ie3sIjHn7m4+5nIqKAIdpFaKNZA== X-Received: by 10.28.165.216 with SMTP id o207mr7199735wme.31.1462739181433; Sun, 08 May 2016 13:26:21 -0700 (PDT) Original-Received: from [192.168.1.2] ([185.105.175.24]) by smtp.googlemail.com with ESMTPSA id m20sm20596095wma.23.2016.05.08.13.26.19 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 08 May 2016 13:26:20 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1 In-Reply-To: <87inyoxpz8.fsf@mail.linkov.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:118003 Archived-At: On 05/08/2016 11:19 PM, Juri Linkov wrote: > I can't reproduce this when using normal query-replace. Correct. > Is this caused by binding local variables in xref--query-replace-1? No, it's caused by perform-replace not using the said variables in a consistent fashion. > Then maybe there is a better way to achieve the same. Maybe there is, but I don't know it. > You don't need isearch-filter-predicate when doing undo > because a previous replacement already checked it, no? Not sure. It's possible the problem is caused by FROM being `.*'. The post-undo code initiates new searches at the positions of the previous matches using `looking-at'.