From: Dmitry Gutov <dgutov@yandex.ru>
To: Juri Linkov <juri@linkov.net>
Cc: 23484@debbugs.gnu.org
Subject: bug#23484: 25.1.50; undo doesn't work properly in xref-query-replace-in-results
Date: Sun, 8 May 2016 23:26:19 +0300 [thread overview]
Message-ID: <c40255e3-2dd2-df4c-57e0-c072657a8565@yandex.ru> (raw)
In-Reply-To: <87inyoxpz8.fsf@mail.linkov.net>
On 05/08/2016 11:19 PM, Juri Linkov wrote:
> I can't reproduce this when using normal query-replace.
Correct.
> Is this caused by binding local variables in xref--query-replace-1?
No, it's caused by perform-replace not using the said variables in a
consistent fashion.
> Then maybe there is a better way to achieve the same.
Maybe there is, but I don't know it.
> You don't need isearch-filter-predicate when doing undo
> because a previous replacement already checked it, no?
Not sure. It's possible the problem is caused by FROM being `.*'. The
post-undo code initiates new searches at the positions of the previous
matches using `looking-at'.
next prev parent reply other threads:[~2016-05-08 20:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-08 19:06 bug#23484: 25.1.50; undo doesn't work properly in xref-query-replace-in-results Dmitry Gutov
2016-05-08 20:19 ` Juri Linkov
2016-05-08 20:26 ` Dmitry Gutov [this message]
2016-05-09 20:01 ` Juri Linkov
2016-05-09 20:10 ` Dmitry Gutov
2016-05-09 20:19 ` Dmitry Gutov
2016-05-10 21:34 ` Juri Linkov
2016-05-10 22:03 ` Dmitry Gutov
2016-05-11 20:48 ` Juri Linkov
2016-05-11 21:11 ` Dmitry Gutov
2016-05-12 20:57 ` Juri Linkov
2016-05-12 22:01 ` Dmitry Gutov
2016-05-14 20:34 ` Juri Linkov
2016-05-14 21:13 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c40255e3-2dd2-df4c-57e0-c072657a8565@yandex.ru \
--to=dgutov@yandex.ru \
--cc=23484@debbugs.gnu.org \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.