From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#20896: patch to add chained indentation Date: Fri, 13 Jan 2017 04:09:18 +0300 Message-ID: References: <87a8vnlrxs.fsf@gmx.us> <87tw97zav3.fsf@tromey.com> <8760llylhq.fsf@tromey.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1484269828 8837 195.159.176.226 (13 Jan 2017 01:10:28 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 13 Jan 2017 01:10:28 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:50.0) Gecko/20100101 Thunderbird/50.0 Cc: 20896@debbugs.gnu.org, Daniel Colascione To: Tom Tromey Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jan 13 02:10:18 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cRqNb-0000Wi-Tv for geb-bug-gnu-emacs@m.gmane.org; Fri, 13 Jan 2017 02:10:08 +0100 Original-Received: from localhost ([::1]:38483 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cRqNg-0006WE-CP for geb-bug-gnu-emacs@m.gmane.org; Thu, 12 Jan 2017 20:10:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34819) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cRqNa-0006V1-I9 for bug-gnu-emacs@gnu.org; Thu, 12 Jan 2017 20:10:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cRqNW-0000bo-AY for bug-gnu-emacs@gnu.org; Thu, 12 Jan 2017 20:10:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:36494) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cRqNW-0000bb-5f for bug-gnu-emacs@gnu.org; Thu, 12 Jan 2017 20:10:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cRqNV-0001iQ-TZ for bug-gnu-emacs@gnu.org; Thu, 12 Jan 2017 20:10:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 13 Jan 2017 01:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20896 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20896-submit@debbugs.gnu.org id=B20896.14842697686546 (code B ref 20896); Fri, 13 Jan 2017 01:10:01 +0000 Original-Received: (at 20896) by debbugs.gnu.org; 13 Jan 2017 01:09:28 +0000 Original-Received: from localhost ([127.0.0.1]:51893 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cRqMy-0001hV-Gs for submit@debbugs.gnu.org; Thu, 12 Jan 2017 20:09:28 -0500 Original-Received: from mail-lf0-f67.google.com ([209.85.215.67]:36617) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cRqMw-0001hJ-ND for 20896@debbugs.gnu.org; Thu, 12 Jan 2017 20:09:27 -0500 Original-Received: by mail-lf0-f67.google.com with SMTP id h65so3853312lfi.3 for <20896@debbugs.gnu.org>; Thu, 12 Jan 2017 17:09:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=MlivI4KJXLr9M6wYvyFWR5XNLf4VQGn4TuUgMrK/9wI=; b=HyUel8aA1EWKO3DI1DPaBrtTHkCh9Ryld2vMr4PwILCveyrh722RNm6RkX1m5U1rer K51AMlkNVZl0SXUA+Lz6cptWnEpS/IaiAfj39Fjx9TenG/MBJAkz9SuY9KsVu+fpJ9LH qhTcTcXUYTPfgMnTxyDFQjSHInwjKiNvAOFQopHmKgZshwVxomFTpqS+rmzMUdbR361+ 5qK0jY+KKjo/5S0KrdfC3YFUCh8DRUPcnLpPWvxpBdkivy3I2WtPNOG0dqBQT5ieMwLV 5jQzgytnEjqW0DK/LoBe3nqticG/tCZKE06C3sPXM2vemcn6p155fx4xuxryrOiVGigp 4weQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=MlivI4KJXLr9M6wYvyFWR5XNLf4VQGn4TuUgMrK/9wI=; b=YS3ZTF5IK1UCALsYHAPSsNuKuAujP+8aSOI9vsXLE5iSGO5MCC13Z9HQrST+AU1pUf bLR+G4P4j17txBBhqCq6lhfNxh8t/Eyjq4RYBSs1bjYRXyB9d6WdYPCgHsX5oN9Fmfc/ 3yEo+y/OOLcr7+z9y5+Vol2RexjG4qGAX+RI4gMXqx7RW5G/bK0uiuazUu6nvnK8m753 sazqMt+rlLOd6VsZLXu0IKJshMiFlRyVbcVLOBXF46ppg6+6/cV6LIWi97M/cpkq9OXu INdIxGWKuPwRUoNbqrGvHDjWOe4CgOGjcozy0PfL09jqwLwNHrFKr1C5g8ueTwzE/1dP 4psQ== X-Gm-Message-State: AIkVDXIT7I5kwukL6Nqg6V6LpcWSgzNP4OOYbwi4B2MCow9cF2G0TwTNC3XneP2ofW/XFA== X-Received: by 10.25.22.201 with SMTP id 70mr6764418lfw.97.1484269760666; Thu, 12 Jan 2017 17:09:20 -0800 (PST) Original-Received: from [192.168.1.174] ([178.252.127.239]) by smtp.googlemail.com with ESMTPSA id c66sm3087745ljd.44.2017.01.12.17.09.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 12 Jan 2017 17:09:19 -0800 (PST) In-Reply-To: <8760llylhq.fsf@tromey.com> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:128046 Archived-At: On 12.01.2017 07:01, Tom Tromey wrote: > I'll redo the test this way. Thanks. > Dmitry> As for review: js--skip-term-backward seems to be doing something > Dmitry> similar to the loop in js--multi-line-declaration-indentation. > Dmitry> Maybe a extraction and unification is in order. > > I don't really see it. Could you explain more? The `while' loop jumps to the beginning of the current "assignment expression". `js--skip-terms-backward' is similar because it skips to the beginning of the call chain. It's more narrow, though (the other function also jumps over binary operators). Anyway, I'm not so sure there's much value in unifying the implementations anymore.