all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dgutov@yandex.ru>
To: Tom Tromey <tom@tromey.com>
Cc: 20896@debbugs.gnu.org, Daniel Colascione <dan.colascione@gmail.com>
Subject: bug#20896: patch to add chained indentation
Date: Fri, 13 Jan 2017 04:09:18 +0300	[thread overview]
Message-ID: <c3d0179c-a695-9de2-29be-eb74a25a07b6@yandex.ru> (raw)
In-Reply-To: <8760llylhq.fsf@tromey.com>

On 12.01.2017 07:01, Tom Tromey wrote:

> I'll redo the test this way.

Thanks.

> Dmitry> As for review: js--skip-term-backward seems to be doing something
> Dmitry> similar to the loop in js--multi-line-declaration-indentation.
> Dmitry> Maybe a extraction and unification is in order.
>
> I don't really see it.  Could you explain more?

The `while' loop jumps to the beginning of the current "assignment 
expression".

`js--skip-terms-backward' is similar because it skips to the beginning 
of the call chain. It's more narrow, though (the other function also 
jumps over binary operators).

Anyway, I'm not so sure there's much value in unifying the 
implementations anymore.





  reply	other threads:[~2017-01-13  1:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-25 15:37 bug#20896: 25.0.50; [js-mode][FR] support chain syntax indentation Rasmus
2015-06-26  0:14 ` Rasmus
2017-01-10  6:29 ` bug#20896: patch to add chained indentation Tom Tromey
2017-01-12  1:57   ` Dmitry Gutov
2017-01-12  4:01     ` Tom Tromey
2017-01-13  1:09       ` Dmitry Gutov [this message]
2017-01-14 17:45 ` bug#20896: done Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c3d0179c-a695-9de2-29be-eb74a25a07b6@yandex.ru \
    --to=dgutov@yandex.ru \
    --cc=20896@debbugs.gnu.org \
    --cc=dan.colascione@gmail.com \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.