From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Daniel Colascione Newsgroups: gmane.emacs.devel Subject: Re: [RFC PATCH] Per-window face support Date: Sat, 16 Jun 2018 07:24:13 -0700 Message-ID: References: <5e08587a56ad528599ed5fb259be6335.squirrel@dancol.org> <83muw5vdtr.fsf@gnu.org> <83zhzvyqfy.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1529158992 5756 195.159.176.226 (16 Jun 2018 14:23:12 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 16 Jun 2018 14:23:12 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jun 16 16:23:08 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fUC6d-0001G3-NB for ged-emacs-devel@m.gmane.org; Sat, 16 Jun 2018 16:23:08 +0200 Original-Received: from localhost ([::1]:51685 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fUC8f-0000Uz-I8 for ged-emacs-devel@m.gmane.org; Sat, 16 Jun 2018 10:25:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53778) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fUC7z-0000UH-J3 for emacs-devel@gnu.org; Sat, 16 Jun 2018 10:24:32 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fUC7v-00069G-LF for emacs-devel@gnu.org; Sat, 16 Jun 2018 10:24:31 -0400 Original-Received: from dancol.org ([2600:3c01::f03c:91ff:fedf:adf3]:46730) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fUC7v-00061G-B0; Sat, 16 Jun 2018 10:24:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dancol.org; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=3c02wuzOWZ3Bp1O/4Lc/Q14XSUf3zoJ9xYmsoqxEcxA=; b=Nso74sRGuADqg38QqzAxskKU8r9MgblmPO2SpMSkLxcOfUn1QXUCb73NVJoVEGrvCioXFnoROlbkITjY5RJqLBtiUSjcO8l4u8gNx8X5GdCiEvNqf6F4yl2xyG5FcB0fSEXi+HLSvHJbf1uIuoUYs+aw1YhE0bq8OG7q7LEltKBUzZBOero/h4knepDvSOjVUprgmqmS+DhkADiUsNfdD0ILoBvCy4o046qBBMJozEQwVHRsfiSkKxavvsMsWBoltUE5KV1w6hFlvhM1Zu/YifqHYgW+slq7+koL4b/vfCg+NYJdS58tQ/e0FnKreb4wrv7ZjLaRJ0RUV7yTe06duw==; Original-Received: from [172.92.145.124] (helo=[192.168.86.27]) by dancol.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1fUC7n-0001gz-SR; Sat, 16 Jun 2018 07:24:20 -0700 In-Reply-To: <83zhzvyqfy.fsf@gnu.org> Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2600:3c01::f03c:91ff:fedf:adf3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:226360 Archived-At: On 06/16/2018 03:29 AM, Eli Zaretskii wrote: >> Date: Fri, 08 Jun 2018 12:15:44 +0300 >> From: Eli Zaretskii >> Cc: emacs-devel@gnu.org > > Daniel, you never answered my question below: > >>> + if (w) { >>> + Lisp_Object found = assq_no_quit (parameter, w->window_parameters); >>> + if (!NILP (found) && EQ (XCDR (found), value)) >>> + match = true; >>> + } >> >> [...] >> >> Also, I wonder whether EQ should actually be equal_no_quit, because >> the latter would allow parameters with values that are not just >> integers or symbols. > > I still wonder why we only allow EQ there, it sounds unnecessarily > restrictive. Because there's no need for greater power. All you need is simple classification.