bug#26001: js-mode: JSX indentation after fat-arrow attribute

bug#26001: js-mode: JSX indentation after fat-arrow attribute

[Dražen]

[-- Attachment #1: Type: text/plain, Size: 1473 bytes --]

As mentioned in
https://github.com/mooz/js2-mode/issues/389#issuecomment-271869380 , there
seems to be a bug in the way js-mode (at least the folks there pointed me
at js-mode) indents JSX JavaScript.

When I'm doing a map with JSX syntax I'm getting:

render() {
    const messages = this.state.messages.map(
        message => <Message key={message.id}
        text={message.text}
        mine={message.mine} />
    );    return messages;
}

I'd ideally expect something like:

render() {
    const messages = this.state.messages.map(
        message => <Message key={message.id}
                            text={message.text}
                            mine={message.mine} />
    );    return messages;
}

It's even odder when I try to leave the argument to the arrow function in
the line above:

render() {
    const messages = this.state.messages.map(message =>
                                             <Message key={message.timestamp}
                                             text={message.text}
                                             mine={message.mine} />
                                            );    return messages;
}

For this second case, I'd hope to get:

render() {
    const messages = this.state.messages.map(message =>
        <Message key={message.timestamp}
                 text={message.text}
                 mine={message.mine} />
    );    return messages;
}

(I get such results if I wrap the return expression in parentheses)

[-- Attachment #2: Type: text/html, Size: 20159 bytes --]

bug#26001: js-mode: JSX indentation after fat-arrow attribute

[Jackson Ray Hamilton]

Hi Dražen,

A set of changes I pushed to the Emacs master branch 2 months ago should 
resolve this issue.  (First fixed in 4b305bb185, but there were several 
commits after that when I broke/fixed it again.  The master branch is 
your best bet.)

Note that if you’re currently using js2-mode, you’ll have to use js-mode 
instead.  The fix is not currently available for JS2, except with 
js2-minor-mode.

Jackson

bug#26001: js-mode: JSX indentation after fat-arrow attribute

[Dražen]

[-- Attachment #1: Type: text/plain, Size: 605 bytes --]

Hi Jackson, great! Thanks for the update.

Cheers!

On Wed, Jun 5, 2019 at 4:57 AM Jackson Ray Hamilton <
jackson@jacksonrayhamilton.com> wrote:

> Hi Dražen,
>
> A set of changes I pushed to the Emacs master branch 2 months ago should
> resolve this issue.  (First fixed in 4b305bb185, but there were several
> commits after that when I broke/fixed it again.  The master branch is
> your best bet.)
>
> Note that if you’re currently using js2-mode, you’ll have to use js-mode
> instead.  The fix is not currently available for JS2, except with
> js2-minor-mode.
>
> Jackson
>
>

[-- Attachment #2: Type: text/html, Size: 950 bytes --]