From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#72701: eglot crash when project-files-relative-names t Date: Fri, 23 Aug 2024 02:22:52 +0300 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30364"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird To: Ship Mints , 72701@debbugs.gnu.org, =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 23 01:23:49 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1shH9g-0007m4-9F for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 23 Aug 2024 01:23:49 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1shH9F-0008A2-D3; Thu, 22 Aug 2024 19:23:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1shH9C-00089j-FV for bug-gnu-emacs@gnu.org; Thu, 22 Aug 2024 19:23:18 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1shH9A-0003O8-Ge for bug-gnu-emacs@gnu.org; Thu, 22 Aug 2024 19:23:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=In-Reply-To:From:References:MIME-Version:Date:To:Subject; bh=9oYofAq1Yzz0AyK/eiB4ncyd7LnFmYb8h8uwJftGryE=; b=kFVB5vZaT51qD5jnArLEdpdRpYs3lBo/gB5JThU0w9fc2Bvk8PUj2YvrrJc79NgNxRP6WKtsukJ3IMeI9vWYGLXVi81zijEt5oiMXO/JiBqVDPG8swkouVA/ffoYqJNDgOUH5HIwBHCo1od1iK7JiskB1CSkSKwU/FtX6BBF6ElDIpcUlzd03I+gX670i48GR88ITQ+cJlEQTMVj2gGhDTDusaQv/wX1/mVxtEROmxk9GjgQo7/9VFROd6Yi5GpuJz7q7/53jzWDs7B1akWcuYYULuC6h17Rz65Bq8Jf1z/ssMYOGLQEIiHv7N9XGdmR10Dt/imKS/Y2QoBbkAdi3g==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1shH9u-0002Da-JD for bug-gnu-emacs@gnu.org; Thu, 22 Aug 2024 19:24:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 22 Aug 2024 23:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72701 X-GNU-PR-Package: emacs Original-Received: via spool by 72701-submit@debbugs.gnu.org id=B72701.17243690308495 (code B ref 72701); Thu, 22 Aug 2024 23:24:02 +0000 Original-Received: (at 72701) by debbugs.gnu.org; 22 Aug 2024 23:23:50 +0000 Original-Received: from localhost ([127.0.0.1]:38553 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1shH9h-0002Cx-Jd for submit@debbugs.gnu.org; Thu, 22 Aug 2024 19:23:49 -0400 Original-Received: from fout1-smtp.messagingengine.com ([103.168.172.144]:48757) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1shH9f-0002CQ-4b for 72701@debbugs.gnu.org; Thu, 22 Aug 2024 19:23:47 -0400 Original-Received: from phl-compute-05.internal (phl-compute-05.nyi.internal [10.202.2.45]) by mailfout.nyi.internal (Postfix) with ESMTP id 9A3D113900FF; Thu, 22 Aug 2024 19:22:55 -0400 (EDT) Original-Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-05.internal (MEProxy); Thu, 22 Aug 2024 19:22:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :content-transfer-encoding:content-type:content-type:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1724368975; x=1724455375; bh=9oYofAq1Yzz0AyK/eiB4ncyd7LnFmYb8h8uwJftGryE=; b= 0bQNUEa6LQqdKYDo7ljltoRwIh0ikcrXyB/QO57HodUM4Es5+yncWh43MmISrXSr LeHbluF49z/IiJ7TAG+kaXTpKUd3176j8Y+Bew00dKfYWo+DBeMC1Oz4j4pRp5on NruvxRDiXts3Q0lITKFq0obJa/Q4HKMCEy9SDWn25kAFCvdvjxH3Yb4HO77raOz1 6i1HmlLUWI3IyVDU4EnUSmQGp12L2PVi+n/DWX+I1ba2uZopMj85XaI2HdXEXtx7 c2IOrFOQOpzk7AMEnX+9kQOP9W4VRKwsVQiLlj66swUCmbzCkBruCfB9mtiMbUiq GGTUrn3X+lDE3ZwvJuGLTA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1724368975; x= 1724455375; bh=9oYofAq1Yzz0AyK/eiB4ncyd7LnFmYb8h8uwJftGryE=; b=t XZF1WA5T7cH/bd8vyUrbobGwsLmVCQ/+EZ1m9/ZtYREu/sbe5jMVZRgqVOzFvEoj zUWoQlhD39ztd+wlK+fi9sURKfN3PITGDOp4poTm4bHvZVGXrwSZMNq0fR0Ytndu PX1mVElQXJSd0k1LYXsq1AUQr2DXwnAIz0Sbe+OA+GRy89FhB+zUc7ySrZYk/pkh DK8OAaSto0TlYP+SZ3wcwkBjnvWN1Ft43nNpE3eysctTUBumdRJpjgwkGdVN3aM4 mwK1jz3TGLPoKlusQfFiy2EuC7sPUmWSHYCUmS68Dj3wzncn9bjSoIDdl6FcmqNA 7f14RRzZkdZewRGk3eVDg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddruddvuddgvdduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhepkfffgggfuffvfhfhjggtgfesthekredttddvjeen ucfhrhhomhepffhmihhtrhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvg hvqeenucggtffrrghtthgvrhhnpeegueegteffuddvjeevvdelleeitdeftdduhfeffeff jedukeevjedvfeffgfevgeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmh grihhlfhhrohhmpegumhhithhrhiesghhuthhovhdruggvvhdpnhgspghrtghpthhtohep fedpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepshhhihhpmhhinhhtshesghhmrg hilhdrtghomhdprhgtphhtthhopeejvdejtdduseguvggssghughhsrdhgnhhurdhorhhg pdhrtghpthhtohepjhhorghothgrvhhorhgrsehgmhgrihhlrdgtohhm X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 22 Aug 2024 19:22:54 -0400 (EDT) Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:290566 Archived-At: Hi! On 18/08/2024 18:43, Ship Mints wrote: > project-files-relative-names was introduced a few months ago, so it's no > surprise that there are some side effects when set. > > This affects the handler for workspace/didChangeWatchedFiles. The result > is that dirs-to-watch... > >          (dirs-to-watch >           (delete-dups (mapcar #'file-name-directory >                                (project-files >                                 (eglot--project server)))))) > > ...is nil when project-files-relative-names is t, due to > file-name-directory failing to parse the directories it was expecting. > This results in file-readable-p failing with a nil dir: You're not really supposed to customize it as an end user (or at least not yet) - the caller code either sets it to t to indicate support for relative names, or not. >          (watch-dir (dir) >            (when-let ((probe >                        (and (file-readable-p dir) > > One solution which I've tested is simply the defensive: > >          (project-files-relative-names nil) ; add this >          (dirs-to-watch >           (delete-dups (mapcar #'file-name-directory >                                (project-files >                                 (eglot--project server)))))) ...that said, someday the default value of this var will be flipped, and some changes like that might be needed. The relative version is a bit faster, though, so maybe Eglot could switch to relative names too. If it makes sense.