From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Mendler Newsgroups: gmane.emacs.bugs Subject: bug#60464: 29.0.60; Regression - pcomplete-arg fails with argument 'last Date: Wed, 4 Jan 2023 16:19:42 +0100 Message-ID: References: <87358u5y6l.fsf@daniel-mendler.de> <226b32f79f2d431d75b6@heytings.org> <009141ba-c21a-a5cb-a81b-c72a12a26207@daniel-mendler.de> <226b32f79f728e6bfed4@heytings.org> <82cf05e4-3c3f-9804-4801-eb31988f6d7d@daniel-mendler.de> <226b32f79f325daf9c7a@heytings.org> <226b32f79fe1e154cfb4@heytings.org> <1de8c8ce-4aa1-c6e4-1ede-0acafc620a50@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27381"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Jim Porter , Eli Zaretskii , 60464@debbugs.gnu.org To: Gregory Heytings , Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 04 16:21:01 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pD5Zc-0006nf-I2 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 04 Jan 2023 16:21:00 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pD5ZA-0004EY-69; Wed, 04 Jan 2023 10:20:32 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pD5Z0-0004B2-8V for bug-gnu-emacs@gnu.org; Wed, 04 Jan 2023 10:20:22 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pD5Yg-0001dN-EI for bug-gnu-emacs@gnu.org; Wed, 04 Jan 2023 10:20:06 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pD5Yg-00073n-8T for bug-gnu-emacs@gnu.org; Wed, 04 Jan 2023 10:20:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Daniel Mendler Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 04 Jan 2023 15:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60464 X-GNU-PR-Package: emacs Original-Received: via spool by 60464-submit@debbugs.gnu.org id=B60464.167284559227118 (code B ref 60464); Wed, 04 Jan 2023 15:20:02 +0000 Original-Received: (at 60464) by debbugs.gnu.org; 4 Jan 2023 15:19:52 +0000 Original-Received: from localhost ([127.0.0.1]:49338 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pD5YW-00073I-II for submit@debbugs.gnu.org; Wed, 04 Jan 2023 10:19:52 -0500 Original-Received: from server.qxqx.de ([178.63.65.180]:45695 helo=mail.qxqx.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pD5YV-000735-3V for 60464@debbugs.gnu.org; Wed, 04 Jan 2023 10:19:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Hewv+d5FmBCRCgISGelFCXap7RPuVU2mllF2zl51YdI=; b=bKpn2VSGudeXbeeb+N9CZn/TqG xecLe+fThFQ61pYatEL9Xjw0chIs64PYvUTE6DFaZpETvdt/y63R5qGcFf+oweIqSEK0E0tBkr3ZT LN27WrsQ8oSvuBIFDeJZIOL1u0qBnIVgGIkN4h/wl/XBThhtl1IoWjXW82LxSsZUBlWk=; Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:252491 Archived-At: On 1/4/23 15:36, Gregory Heytings wrote: > >>> IOW, instead of unconditionally returning arg, we now sometimes (when >>> arg is not already a string and when index is not last) return the >>> textual representation of that argument (what the user typed in) with >>> the value of arg attached to it. >> >> I don't understand the `last` condition. >> >> Could you explain it (e.g. with a concrete example that breaks if you >> don't include it)? >> > > Yes: when index is 'last' returning a non-string (more precisely: a list > of strings) is allowed (and in fact expected, at least by Eshell). A > recipe, in the Emacs repository: > > M-x eshell > cd lisp > ls *.el TAB > > (Note that there is no SPC before TAB.) > > Without the 'last' condition, you don't get what you're supposed to get at > that point (and what you got with Emacs 27 or 28), namely the list of .el > files in *Completions*. Instead you see "Complete, but not unique", and > you have to press TAB a second time to see the completions. Don't you think that this is by accident? Shouldn't Eshell fixed instead to not expect a list in this case? I believe it would be better if pcomplete-arg behaves uniformly for all arguments. Daniel