RE: [PATCH] * etc/themes/wombat-theme.el: Don't set foreground on region

[Drew Adams <drew.adams@oracle.com>]

> > Setting a foreground color on the `region' face is slightly
> > annoying.
> > This is subjective, of course, but the consensus among other
> > themes and around the web is to *not* set a foreground color
> > on the region face.
>
> Any objections to this?  I should have mentioned that the reason
> it's slightly annoying is because setting a foreground color hides
> existing syntax highlighting within the region text.

A particular theme can do anything its authors and users want,
of course.  But wrt the general question of whether region (aka
selection) highlighting should override other highlighting, see
Emacs bug #15899.

http://debbugs.gnu.org/cgi/bugreport.cgi?bug=15899

IMO, selection highlighting should, at least by default, visibly
cover the entire selection.  Otherwise, it is not always clear
what the region limits are.

When other highlighting takes precedence over region highlighting
a user can miss the fact that there is more than one (or more than
N) region pieces highlighted, and so mistake the region limits.

Whether region highlighting has higher precedence (priority)
should always be a user choice.  Users can at least customize face
`region' (including to specify its foreground), but that is not
enough to give region highlighting priority.