From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#70329: 29.3; etags-regen-mode fails in projects that have spaces in their root path elements Date: Thu, 11 Apr 2024 20:10:55 +0300 Message-ID: References: <7yv84p3tee.fsf@icloud.com> <861q7cuzko.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28272"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: 70329-done@debbugs.gnu.org To: Eli Zaretskii , Magiel Bruntink Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Apr 11 19:12:28 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ruxyN-00075I-8H for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 11 Apr 2024 19:12:27 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ruxxu-0006LM-HX; Thu, 11 Apr 2024 13:11:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ruxxq-0006Km-PL for bug-gnu-emacs@gnu.org; Thu, 11 Apr 2024 13:11:54 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ruxxq-00043X-Gq for bug-gnu-emacs@gnu.org; Thu, 11 Apr 2024 13:11:54 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ruxxz-0001AM-Qk for bug-gnu-emacs@gnu.org; Thu, 11 Apr 2024 13:12:03 -0400 Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Thu, 11 Apr 2024 17:12:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 70329 X-GNU-PR-Package: emacs Mail-Followup-To: 70329@debbugs.gnu.org, dmitry@gutov.dev, magiel.bruntink@icloud.com Original-Received: via spool by 70329-done@debbugs.gnu.org id=D70329.17128554814164 (code D ref 70329); Thu, 11 Apr 2024 17:12:03 +0000 Original-Received: (at 70329-done) by debbugs.gnu.org; 11 Apr 2024 17:11:21 +0000 Original-Received: from localhost ([127.0.0.1]:57244 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ruxxI-000156-R2 for submit@debbugs.gnu.org; Thu, 11 Apr 2024 13:11:21 -0400 Original-Received: from fout2-smtp.messagingengine.com ([103.168.172.145]:43281) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ruxxD-00013B-Gu for 70329-done@debbugs.gnu.org; Thu, 11 Apr 2024 13:11:18 -0400 Original-Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailfout.nyi.internal (Postfix) with ESMTP id 4DB151380158; Thu, 11 Apr 2024 13:11:00 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Thu, 11 Apr 2024 13:11:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1712855460; x=1712941860; bh=W9Yvd2NAclq1NImVpMEqSKf/BuEJl7Gc+A+CTYEX/U0=; b= cnnI/Yn7UJkcN696PLPxpAjT7M7He9jalTlbX1xHCHaeXxVuKKFA/w7m4EcIlTXy 1dGY+see9R5FK+b0T74RLoHlLeqDj35kbzwm+hdHPsdGGJp/nb9Chw/KkzDjl7nB v8rGXhefvttIHF25MR75tLlIqZNAGt+CsgvKIDUhxboYcICYj9zJd4nVNb5SgLfZ MKjf+Nv5EGG/OUSWLI8nFmxmiAuIZUVtYWXhEotiFd1UFKOwyWiE7L/+IDf59APb lKLNGZcGy8AF0gxHxGizf5flJ0+9xBi8uleBFeS2BDz/Hh/41Y8s/XxtL4OPORsb 6gPjJ/59A2XvPpoJNIfl/Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1712855460; x= 1712941860; bh=W9Yvd2NAclq1NImVpMEqSKf/BuEJl7Gc+A+CTYEX/U0=; b=D 8DfkPqbs1NLC3Vad+CMShoSxZR8VfseX+XCaSDbX5MIgQt6+f1N5225tWArPsuf/ xbUt9fS2UkRzHogXt585a4xUesD4uh2mxBxpDFmdj2r2VIM7gl4K3hXNeFnno+J8 dBwe9cTUpDAhcs/6P7kuRMzRBttj55Je+ze++rZxv5pEEBR434UxvtVjixJ2pbmZ 9iAMCjxUml9xPqvuSOvEyqyQIWbKv93RtEW5HXeqP1PJCgC+lNZVT7CN7loLBT9W axq8t1kfXqu3obteNcMB12wXJ4etYUP4eWOUp0Drl3bmZtTCT1VplRGE2woA9Nhd N0xkGhGGcC+Kb56TUK+fA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrudehkedguddutdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefkffggfgfuvfevfhfhjggtgfesthejredttddvjeenucfhrhhomhepffhm ihhtrhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrg htthgvrhhnpeetudeljeegheetgfehgeejkeeuhedvveeikeeufedtvddtveefhfdvveeg udejheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe gumhhithhrhiesghhuthhovhdruggvvh X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 11 Apr 2024 13:10:58 -0400 (EDT) Content-Language: en-US In-Reply-To: <861q7cuzko.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:283102 Archived-At: Hi Eli and Magiel, On 11/04/2024 10:29, Eli Zaretskii wrote: >> Date: Wed, 10 Apr 2024 21:32:57 +0200 >> From: Magiel Bruntink via "Bug reports for GNU Emacs, >> the Swiss army knife of text editors" >> >> I wanted to try to the new etags-regen-mode and loaded its lisp manually. >> >> There is an issue with how the new mode deals with paths containing spaces, >> however. >> >> Running the etags--xref-backend through eg. xref-find-definitions >> within a file in a project that has spaces in its path elements, >> eg. "c:/temp/test project/test.c" will cause an error. >> >> Messages seen are: >> Generating new tags table... >> (Shell command failed with code 1 and some error output) >> visit-tags-table-buffer: File c:/temp/test project/TAGS does not exist >> >> Error message in the etags-regen-tags-errors* buffer: >> c:/temp/test: Permission denied > Stab in the dark: does the patch below fix the problem? > > If not, please repeat your recipe with debug-on-error non-nil, and > post the backtrace here. > > diff --git a/lisp/progmodes/etags-regen.el b/lisp/progmodes/etags-regen.el > index 6cd78d3..02d666c 100644 > --- a/lisp/progmodes/etags-regen.el > +++ b/lisp/progmodes/etags-regen.el > @@ -279,7 +279,7 @@ etags-regen--tags-generate > " ") > ;; ctags's etags requires '-L' for stdin input. > (if ctags-p "-L" "") > - tags-file))) > + (shell-quote-argument tags-file)))) > (with-temp-buffer > (mapc (lambda (f) > (insert f "\n")) Thank you, looks good, pushed to master.