On 11/18/2016 01:39 AM, Eli Zaretskii wrote: >> From: Hong Xu >> Cc: 24861@debbugs.gnu.org >> Date: Tue, 15 Nov 2016 16:03:19 -0800 >> >> Can you still consider this patch? > > I'm okay with accepting this for the master branch, but the patch > needs some more work to fix the following issues: > > . The first line of each doc string should be a complete sentence. > . The doc string of cpp-progress-message should mention > cpp-message-min-time-interval. > . The defcustom you are adding should have a :version tag. > . The calculation in cpp-progress-message should be fixed to > calculate the time difference between the current time and the time > of the previous progress message, and compare that with the value > of cpp-message-min-time-interval. The old code just looked at the > 2nd member of the list returned by current-time, but that is no > longer TRT when you need to compare the time difference, because > that member can go back to zero. You need to use time-subtract. > . Last, but not least: please include ChangeLog-style commit log > message for the changes. > Allow users to customize the maximum frequency that `cpp-progress-message' prints messages. * progmodes/cpp.el (cpp-message-min-time-interval) (cpp-progress-message): Add variable `cpp-message-min-time-interval' to indicate the minimum time interval in seconds that `cpp-progress-message' prints messages. * progmodes/cpp.el (cpp-progress-time): Initialize to '(0 0 0 0) instead of 0 and improve the documentation. * progmodes/cpp.el (cpp-highlight-buffer): Use `cpp-progress-message' instead of `message'. Thanks.