From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: Why are so many great packages not trying to get included in GNU Emacs? WAS: Re: Making Emacs more friendly to newcomers Date: Sun, 14 Jun 2020 01:09:23 +0300 Message-ID: References: <87k12bdgx7.fsf@yahoo.com> <87r1wi7a8o.fsf@yahoo.com> <875zdteybt.fsf@runbox.com> <87368wrvf5.fsf@yahoo.com> <86k126d83n.wl-me@enzu.ru> <83pnbyckvv.fsf@gnu.org> <4923d7e98f5ed816a7569093dbc673153adcea88.camel@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="109073"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 To: Konstantin Kharlamov , Stefan Kangas , Eli Zaretskii , Emacs developers Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jun 14 00:10:12 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jkELs-000SHR-6o for ged-emacs-devel@m.gmane-mx.org; Sun, 14 Jun 2020 00:10:12 +0200 Original-Received: from localhost ([::1]:60160 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jkELr-0008BT-88 for ged-emacs-devel@m.gmane-mx.org; Sat, 13 Jun 2020 18:10:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40984) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jkELL-0007l2-F1 for emacs-devel@gnu.org; Sat, 13 Jun 2020 18:09:39 -0400 Original-Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]:51762) by eggs.gnu.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jkELJ-0006vS-Lk; Sat, 13 Jun 2020 18:09:39 -0400 Original-Received: by mail-wm1-x342.google.com with SMTP id b82so2611835wmb.1; Sat, 13 Jun 2020 15:09:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=0DBCUrBFwHEvyHjJSUge1IIMKg4fjkT/+KHXYpBu1IU=; b=gp2s5koWURYzKlFVhlFo+vP98KOe5YsT04GRT0XllqxUZjUTmUAgNQUHHTx6M5S+V3 M8s/xa6ckU+NsyX+R59RN6yTqdfC0SHYP4Rdc2GgYzQ3hZSNtjyUOOlO+PvqBTwSHSkX 4QhM4JOWBXnhkoUVbKODcZ3MDB9eQEg+ho+ernZrd4yt+8zD5VHH++CI/k+hBTO8aXu6 Q5FBHl0XZ5WUnC/TD3D7SKV1W61OPLo4h5/f2TA7MF/DOLtHx+U6L6S6n2WAra767aFx LOiBs23dfoYUQAWTJF5a7t+KMSdMkiMzFKlPhiKAvrcMoQtUFi7d6oe7+XkmyHOExGHu IkgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=0DBCUrBFwHEvyHjJSUge1IIMKg4fjkT/+KHXYpBu1IU=; b=SVTtxuttDr6GcysJK81Xrver+SgP01HxFWfjneZRHjM1Ia9PpLOedJybQDvASdt7uu L7GZKdCQmqNtD3gf0agRTWJGo1G19s3rGRcWD7bqXMtWYKCNNNwXcgsGuvJmr23bFkUA IeVno9Kk/dEdXjwpwtN9XZRyh8mSUjk4F24iRhkZzJ8di1kYiY8xq0QlktnlkEnnxMts lNpmn//oZVPHnEAU67JClkj8S0IXgVjoalVAeD+TGQfmTziquGINEiFCrrUOSAhaSqMt AQ45LiOFyHkoLOMtDVGdg6DaF1MR0CyMJmqBdQ0n7ewEd0oNYr6rRgZJVoZsz2g0FJur rW1A== X-Gm-Message-State: AOAM531aKEvK1n8wi5rP+c1yCbCWZRSteJc7k/Dum8kexloFOKQ7BBvU FM14gNX1ELaToRRLIXRIea3SYMKS X-Google-Smtp-Source: ABdhPJzoy+qQ86RTfmGHi6qAEgonyZO9+BBJVy2zHiljV78pPGvzNBaObDomfJHmhXXPBNO3e9nybw== X-Received: by 2002:a1c:df57:: with SMTP id w84mr5879506wmg.52.1592086165615; Sat, 13 Jun 2020 15:09:25 -0700 (PDT) Original-Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id f11sm16431098wrj.2.2020.06.13.15.09.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 13 Jun 2020 15:09:24 -0700 (PDT) In-Reply-To: Content-Language: en-US Received-SPF: pass client-ip=2a00:1450:4864:20::342; envelope-from=raaahh@gmail.com; helo=mail-wm1-x342.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: 0 X-Spam_score: 0.0 X-Spam_bar: / X-Spam_report: (0.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=1, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:252213 Archived-At: On 13.06.2020 22:23, Konstantin Kharlamov wrote: > FTR, I am all for having good commit messages. It is IMO a must have for any git > project. But having a list of function names with description for each does not > make one. Instead it should be an overview of what is done, why, and how. Having a standard that increases the likelihood of having such a description in the commit message without having to ask the contributor twice is not a bad thing. > Suppose you have a patch that deduplicates the same code pattern across 34 > functions by factoring it out to a single short function. Do you really need > that list? I mean, sure it's a fun fact to know, but you'll have to review diff > anyway. Yes and no. If I get the purpose of the diff, I could scan the contents more superficially (depending on what kind of changes are proposed, and where). > If anything, it only burdens you by forcing to check that each function > is on the list. I usually don't. > Commit message should reveal the intention of the changes (and > perhaps, if OP thinks changes may raise questions, they should also write the > reasoning). That, too. In any case, ChangeLog-style commit messages *are* a barrier for contributing, and one could argue that in the end they don't bring enough benefit to offset that. But our experience shows that they do bring a certain benefit. > On that matter I often love to quote a post from 2009 by Peter Hutterer, a > libinput and Linux HID subsystem maintainer. A post that is old but is not > outdated http://who-t.blogspot.com/2009/12/on-commit-messages.html It's a pretty good guideline. But one that's a bit harder to check and enforce.