From: "Clément Pit--Claudel" <clement.pit@gmail.com>
To: emacs-devel@gnu.org
Cc: Tino Calancha <tino.calancha@gmail.com>
Subject: Re: [Emacs-diffs] master 50548fd: cl-fill: Rename arguments to cl-seq and cl-item
Date: Wed, 24 Aug 2016 11:13:25 -0400 [thread overview]
Message-ID: <c32101f9-c3ff-b07f-c70f-72070b119977@gmail.com> (raw)
In-Reply-To: <jwvpop8n4eb.fsf-monnier+emacsdiffs@gnu.org>
[-- Attachment #1.1: Type: text/plain, Size: 562 bytes --]
On 2016-08-16 11:04, Stefan Monnier wrote:
>> Apparently the functions surrounding cl-fill use cl- prefix. so the
>> change appear to be more cosmetic than technical.
>
> Indeed. But since the "cl-" prefix has to be used for global (aka
> dynamically scoped) variables, it's good practice to *not* use it for
> lexically scoped variables.
>
> IOW, I'm all for such cosmetic changes that harmonize the code, but we
> should do that by removing (rather than adding) the "cl-" prefix where
> it's not needed.
Should the change be reverted, then?
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-08-24 15:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20160813042949.31299.44303@vcs.savannah.gnu.org>
[not found] ` <20160813042950.2B1CB2201C2@vcs.savannah.gnu.org>
2016-08-13 6:06 ` [Emacs-diffs] master 50548fd: cl-fill: Rename arguments to cl-seq and cl-item Stefan Monnier
2016-08-16 14:00 ` Leo Liu
2016-08-16 15:04 ` Stefan Monnier
2016-08-16 15:24 ` John Wiegley
2016-08-16 15:40 ` Drew Adams
2016-08-16 17:09 ` Stefan Monnier
2016-08-16 17:12 ` John Wiegley
2016-08-16 17:31 ` Robert Weiner
2016-08-16 18:15 ` Lars Ingebrigtsen
2016-08-17 9:35 ` Tino Calancha
2016-08-24 0:04 ` Stefan Monnier
2016-08-24 15:13 ` Clément Pit--Claudel [this message]
2016-08-17 9:32 ` Tino Calancha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c32101f9-c3ff-b07f-c70f-72070b119977@gmail.com \
--to=clement.pit@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=tino.calancha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.