From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#35353: 26.2; Buffer *xref*: (1) hard-coded mouse-1, (2) major mode name Date: Mon, 22 Apr 2019 13:52:17 +0300 Message-ID: References: <96cafba3-7ba2-4e87-8f9d-e53825fd1dde@default> <94feda5f-7afa-4ab5-96f8-60dfaba7e0a4@default> <469bf659-07b6-8172-287c-2abc53582447@yandex.ru> <83zhoi74vl.fsf@gnu.org> <44b1aa8a-c06c-61f7-0948-0fd20605e938@yandex.ru> <83y34273mu.fsf@gnu.org> <2979c506-20e4-4b9f-0215-6f0241238678@yandex.ru> <83v9z6732b.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="200821"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 Cc: 35353@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Apr 22 12:53:10 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hIWZS-000q8q-Gx for geb-bug-gnu-emacs@m.gmane.org; Mon, 22 Apr 2019 12:53:10 +0200 Original-Received: from localhost ([127.0.0.1]:35497 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hIWZR-000377-JK for geb-bug-gnu-emacs@m.gmane.org; Mon, 22 Apr 2019 06:53:09 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:35696) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hIWZL-000369-3X for bug-gnu-emacs@gnu.org; Mon, 22 Apr 2019 06:53:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hIWZK-0005Sy-6C for bug-gnu-emacs@gnu.org; Mon, 22 Apr 2019 06:53:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36312) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hIWZK-0005Sr-31 for bug-gnu-emacs@gnu.org; Mon, 22 Apr 2019 06:53:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hIWZJ-00014P-TN for bug-gnu-emacs@gnu.org; Mon, 22 Apr 2019 06:53:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 22 Apr 2019 10:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35353 X-GNU-PR-Package: emacs Original-Received: via spool by 35353-submit@debbugs.gnu.org id=B35353.15559303514074 (code B ref 35353); Mon, 22 Apr 2019 10:53:01 +0000 Original-Received: (at 35353) by debbugs.gnu.org; 22 Apr 2019 10:52:31 +0000 Original-Received: from localhost ([127.0.0.1]:49855 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hIWYp-00013e-7R for submit@debbugs.gnu.org; Mon, 22 Apr 2019 06:52:31 -0400 Original-Received: from mail-lf1-f67.google.com ([209.85.167.67]:36333) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hIWYk-00013N-SW for 35353@debbugs.gnu.org; Mon, 22 Apr 2019 06:52:27 -0400 Original-Received: by mail-lf1-f67.google.com with SMTP id u17so8674340lfi.3 for <35353@debbugs.gnu.org>; Mon, 22 Apr 2019 03:52:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=NYsUdhrpUqtBQUKEtoqn6gQuBT1Eu/UF4hHpfHCr2B0=; b=Fwa4AeanYX3l6BAdFJbRzsHENdfMB4+gIV3wH+hWUjjOzoKTkpnNN7bM7WigdoaJ+R inmnixXJLVeqeVMtF+0hXUsbOtnbLHPqpf1oS7G4C1g9fkwKJl/AGsdimFmD0PaK64L4 lhikL0H7HW7OdP2C3shz9p9+7rAzWnhL5ZnUBEsmb8T0Rhre5LVxQExyTSCqDk6bW0lg gl07WACwHzaRteM1PQvLP7Nssy8Y0Xs+2QDs6GEj4xpgv95+4iVk8ebS9F2e/1nYQaqT kBgHWX2dwRfECZJXNQ4cvuNh126ECRe5NZIMdm1+pVOk4/xWtFx2rD4ZXh+epcnU7rDF 2TVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=NYsUdhrpUqtBQUKEtoqn6gQuBT1Eu/UF4hHpfHCr2B0=; b=KFtNQSjz78HzUwBdjBJjhaW2JvQNSYLi42zYUfg9/fgNvvMVNQFpVNDIyICiZTucye tJ8nbN7Btx0aYegnJiJiXXq6vU+9A1USogKhIZuOVObsbXsdMorm7QK52kTW6B1Qvon9 GQhelXmzK9Ozu0Z4MHGZR8Pks2AuciegRPW7+pDeE7nHqhTUr8xMXIdbgiSAwiyOpw2u ei3TqoicoX5QA6LfK0/IpBxqhyY7kp4paKwqmo+miKV7JN0SUIlSid2zcspEV140y1SB p6lL2PJksQtnf/aTV59IL1BRFjdVO4hiMzFFFITEkiZC0TLdOnb+oXRU/SMwc5YovlUZ jDaA== X-Gm-Message-State: APjAAAWvoY2ZZFc7IPGMIAT/DAzs50x3S6mPwcQvidsQEuZMRQIwnBMq bYSLo6A27Gz2Q9pne28kK/oLfNHz X-Google-Smtp-Source: APXvYqwRHRGJC4s18+tLRGVrS0l6B1yjR/Ytjhu1dRkQUrRIaLn0mdwXzjBAdXbOHLcjyJzdRTu+Fw== X-Received: by 2002:ac2:48a5:: with SMTP id u5mr9801404lfg.115.1555930340631; Mon, 22 Apr 2019 03:52:20 -0700 (PDT) Original-Received: from [192.168.1.3] ([185.105.174.23]) by smtp.googlemail.com with ESMTPSA id v11sm2900795lfb.68.2019.04.22.03.52.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 Apr 2019 03:52:19 -0700 (PDT) In-Reply-To: <83v9z6732b.fsf@gnu.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:158005 Archived-At: On 22.04.2019 13:21, Eli Zaretskii wrote: >>> So we already support mouse-1 clicks, don't we? Or am I again missing >>> something? >> >> Yes, but apparently we don't honor mouse-1-click-follows-link. > > FWIW, I don't see that as a serious issue in this case. Feel free to > close as wontfix, if you want. The fix is not hard, though. Is the variable more targeted on other use cases? Or is it just obscure enough for us not to bother? The patch looks like this (to be accompanied with an appropriate renaming): diff --git a/lisp/progmodes/xref.el b/lisp/progmodes/xref.el index e5e59721eb..463f72ae6f 100644 --- a/lisp/progmodes/xref.el +++ b/lisp/progmodes/xref.el @@ -722,8 +722,9 @@ xref--next-error-function (defvar xref--button-map (let ((map (make-sparse-keymap))) (define-key map [(control ?m)] #'xref-goto-xref) - (define-key map [mouse-1] #'xref-goto-xref) - (define-key map [mouse-2] #'xref--mouse-2) + (define-key map [follow-link] 'mouse-face) + (define-key map [mouse-2] #'xref-goto-xref) + (define-key map [mouse-1] #'xref--mouse-2) map)) (defun xref--mouse-2 (event)