bug#17737: 24.4.50; REGRESSION: `delete-selection-mode' broken by `electric-indent-mode' change

bug#17737: 24.4.50; REGRESSION: `delete-selection-mode' broken by `electric-indent-mode' change

[Drew Adams]

emacs -Q

M-x delete-selection-mode     ; turn it on
M-: (electric-indent-mode -1) ; turn it off

I was hoping that this would just restore the behavior present in Emacs
forever, prior to Emacs 24.4: C-j would insert a newline and indent, and
RET would insert a newline.

The regression is that C-j does not delete the active region.  For
example, in `emacs-lisp-mode':

Select the text from the middle of a line through eol (the newline
char).  Ensure that point is at the start of the selection, not the end.
Hit `C-j'.  The rest of the line is indented on the next line, instead
of being killed.  If point was instead at eol then the rest of the line
is intact and a newline is inserted and point indented.  In sum, the
selected text is not killed.

A fix is to add this sexp to delsel.el:

(put 'electric-newline-and-maybe-indent 'delete-selection t)

I see that you have already added this sexp instead:

(put 'reindent-then-newline-and-indent 'delete-selection t)

I can't speak to whether that second sexp is correct or should be
removed.  I don't use command `reindent-then-newline-and-indent'.


In GNU Emacs 24.4.50.1 (i686-pc-mingw32)
 of 2014-06-01 on ODIEONE
Bzr revision: 117212 michael.albinus@gmx.de-20140601104945-g88x0mwrxorz302h
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
 `configure --prefix=/c/Devel/emacs/snapshot/trunk
 --enable-checking=yes,glyphs 'CFLAGS=-O0 -g3'
 LDFLAGS=-Lc:/Devel/emacs/lib 'CPPFLAGS=-DGC_MCHECK=1
 -Ic:/Devel/emacs/include''

bug#17737: 24.4.50; REGRESSION: `delete-selection-mode' broken by `electric-indent-mode' change

[Stefan Monnier]

> A fix is to add this sexp to delsel.el:

> (put 'electric-newline-and-maybe-indent 'delete-selection t)

Indeed, thanks, done,


        Stefan