From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#63778: [PATCH] Use comint-pager in eshell Date: Wed, 23 Aug 2023 16:58:07 -0700 Message-ID: References: <36a8613a-7601-14d5-c659-3bd86708b63b@gmail.com> <635470cf-103b-8383-0bc5-9b69de4f324d@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14779"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 63778-done@debbugs.gnu.org To: Morgan Smith Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 24 01:59:21 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qYxkt-0003g8-De for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 24 Aug 2023 01:59:19 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qYxka-0000Dd-Lq; Wed, 23 Aug 2023 19:59:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qYxkZ-0000Ci-5x for bug-gnu-emacs@gnu.org; Wed, 23 Aug 2023 19:58:59 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qYxkY-0004qo-US for bug-gnu-emacs@gnu.org; Wed, 23 Aug 2023 19:58:58 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qYxkc-0003Mm-IF for bug-gnu-emacs@gnu.org; Wed, 23 Aug 2023 19:59:02 -0400 Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Wed, 23 Aug 2023 23:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 63778 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 63778@debbugs.gnu.org, jporterbugs@gmail.com, Morgan.J.Smith@outlook.com Original-Received: via spool by 63778-done@debbugs.gnu.org id=D63778.169283510212883 (code D ref 63778); Wed, 23 Aug 2023 23:59:02 +0000 Original-Received: (at 63778-done) by debbugs.gnu.org; 23 Aug 2023 23:58:22 +0000 Original-Received: from localhost ([127.0.0.1]:35584 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qYxjy-0003Li-CW for submit@debbugs.gnu.org; Wed, 23 Aug 2023 19:58:22 -0400 Original-Received: from mail-oi1-x22b.google.com ([2607:f8b0:4864:20::22b]:45322) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qYxju-0003LU-JE for 63778-done@debbugs.gnu.org; Wed, 23 Aug 2023 19:58:20 -0400 Original-Received: by mail-oi1-x22b.google.com with SMTP id 5614622812f47-3a7d7e5fb03so4499711b6e.3 for <63778-done@debbugs.gnu.org>; Wed, 23 Aug 2023 16:58:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692835089; x=1693439889; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=BFEU7u94/c+R7YGz1/wA1PvuSfrzaX4NRnPP0YOuiQE=; b=T2IAL5m3ypZpjbqR4yhtBz6PCkLxKMCi+T+MUmuurEkK45z2sTcGiVORNRmHs6pupD Jj6XIRs9rr/nWGgLTzQmt4lmqPwsTN+j6kZ7wTYor/jq0kg/+SJaf5IM0cGBIoBhUEqv ndoYSC/Vx1aIF/6/e3UeSXVsj6t5NdwL1s5D95w4rHIHvBXB2rR9H8vVEKqYa6zS9BDG 4UezQSEaVSUiT3jnWMWYIM31y/Fc7LkS5UZLGBt1mo6xVJcBYHAAOULU+dUkGHvS+k6M 3vlRYngWULOD4uhPRSWGPnLvoDVOF1Nhr/hxA+/nWF4zId0DwU2GxQqfMFm4rYyHXdxl 5pPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692835089; x=1693439889; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BFEU7u94/c+R7YGz1/wA1PvuSfrzaX4NRnPP0YOuiQE=; b=fPUDpH454moY1BGamfpFhswKzEBMYN3sQxzRVzV53CJdm1Hzxq/25ISoTnMrw7rsyW GdHOnSgk+DBWROK9ewP9+RLxRXcu6ifmaEnEpxm2JVzH0FdGZ8AvjSp/osMEqXJqTm5v 7eaE30mD44uQFWWyZWKqYKsBamOh93tEEUvpqmhJMzBwuucaE3KY5NC0ReBTlVxlhMEK 2K39guaudjuMaplX1i33/Asig3zrbnhJAUHbRsoWewrIt8G93MydawEP8sJqAojZ4oWG ftqU24s+GEj+QLkB9ny0/73pX5c4vn8zQOln3nps0UC5p6bujEeFyh18NRmgw0vGLE5a I5FQ== X-Gm-Message-State: AOJu0YyyY73ov7fG9olph0RF83a7Uq6pWFtDbMLivzdJa762KMm4xr79 b2lkgZ7aR2DO+/Lzt0jmA7M= X-Google-Smtp-Source: AGHT+IFS8lTe/h2Si09x9dnklqxsdQGP8phgIB4rV3S6+zVlztyWY8UQuzV+9SpwqrjvDynAfwh4cw== X-Received: by 2002:a05:6808:1a90:b0:3a7:6224:8424 with SMTP id bm16-20020a0568081a9000b003a762248424mr14623766oib.56.1692835089096; Wed, 23 Aug 2023 16:58:09 -0700 (PDT) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id v21-20020aa78095000000b00687087d8bc3sm10299797pff.141.2023.08.23.16.58.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Aug 2023 16:58:08 -0700 (PDT) Content-Language: en-US In-Reply-To: <635470cf-103b-8383-0bc5-9b69de4f324d@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:268283 Archived-At: Version: 30.1 On 5/29/2023 10:14 PM, Jim Porter wrote: > There's probably a nice way to do this, but it might involve some tweaks > to how Eshell handles variable aliases in general. I'll look into it more. Sorry for completely forgetting about this bug for a few months; I had some trouble getting a patch to work, then got busy with other things, and never picked it back up. I've now merged an updated version of this patch as 08901e93797, so marking this done. This implementation should be 100% backwards compatible, since users have to opt in to setting the new 'comint-pager' option, and even if you do that, it's easy enough to opt back out for just Eshell (set 'comint-pager' buffer-locally to nil in 'eshell-mode-hook' or similar).