all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Harald Judt <h.judt@gmx.at>
To: Philip Kaludercic <philipk@posteo.net>
Cc: emacs-devel@gnu.org, Stefan Kangas <stefankangas@gmail.com>,
	Eli Zaretskii <eliz@gnu.org>, Visuwesh <visuweshm@gmail.com>
Subject: Re: [ELPA] New package: dired-duplicates
Date: Thu, 2 Nov 2023 09:44:17 +0100	[thread overview]
Message-ID: <c26d5591-389f-4096-b0b7-01db5bca3a87@gmx.at> (raw)
In-Reply-To: <875y2lyxfq.fsf@posteo.net>


[-- Attachment #1.1: Type: text/plain, Size: 1485 bytes --]

On 2023-11-01 22:29, Philip Kaludercic wrote:

[...]

> Harald Judt <h.judt@gmx.at> writes:
> 
>> Hi Philip,
>>
>> Another more organisational question regarding your review: If I apply
>> your patch and create commits from it in the project, should I then
>> use your name and email address as author of the commit (I guess I can
>> assume you also assigned copyright to the FSF ;-))?
> 
> You can attribute it to me, but I don't really care much either way.  I
> didn't really send you a patch to apply, but just the output of C-x v =
> after leaving a few comments in the file.
> 
>> Harald

Thank you, I have attributed the improvement for error handling of the 
checksum program to you, while simply pushing the rest.

I will try to implement the checksumming using Emacs's primitives in one of 
the next versions, but first have to think about what's the best way to 
integrate it from a usability perspective (and whether it should be a fallback 
or just another togglable option like setting checksum exec var to nil).

If anyone has other suggestions how to improve functionality of this package, 
I'd be glad to hear.

Now, I think I have addressed all points from your feedback, how may I go on 
pushing a release? Simply increase the version number to 0.2 as you said in my 
codeberg repo?

Harald

-- 
`Experience is the best teacher.'

PGP Key ID: 4FFFAB21B8580ABD
Fingerprint: E073 6DD8 FF40 9CF2 0665 11D4 4FFF AB21 B858 0ABD


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2023-11-02  8:44 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-31 10:34 [ELPA] New package: dired-duplicates Harald Judt
2023-10-31 12:21 ` Philip Kaludercic
2023-10-31 21:05   ` Harald Judt
2023-11-01  2:14     ` Michael Heerdegen
2023-11-01 15:16       ` [External] : " Drew Adams
2023-11-01 15:45         ` Eli Zaretskii
2023-11-01 16:28           ` Drew Adams
2023-11-01 16:47             ` Eli Zaretskii
2023-11-01 16:33         ` Philip Kaludercic
2023-11-01 11:32     ` Philip Kaludercic
2023-11-01 20:04       ` Harald Judt
2023-11-01 21:29         ` Philip Kaludercic
2023-11-02  8:44           ` Harald Judt [this message]
2023-11-03  8:19             ` Philip Kaludercic
2023-11-03 20:19               ` Harald Judt
2023-11-04 15:27                 ` Philip Kaludercic
2023-11-06  9:33                   ` Harald Judt
2023-11-10  8:37                     ` Philip Kaludercic
2023-11-10 10:02                       ` Harald Judt
2023-11-23  6:12                         ` Philip Kaludercic
2023-10-31 21:24   ` Harald Judt
2023-11-01 17:40     ` Stefan Kangas
2023-11-01  3:30   ` Eli Zaretskii
2023-11-01 13:53     ` Visuwesh
2023-11-01 14:12       ` Eli Zaretskii
2023-11-01 17:57         ` Philip Kaludercic
2023-11-01 19:24           ` Eli Zaretskii
2023-11-01 20:09             ` Harald Judt
2023-11-02  5:55               ` Eli Zaretskii
2023-11-08 20:29                 ` Harald Judt
2023-11-09  5:52                   ` Eli Zaretskii
2023-11-09  8:00                     ` Harald Judt
2023-11-09  8:38                       ` tomas
2023-11-09  8:48                         ` Eli Zaretskii
2023-11-09  8:43                       ` Eli Zaretskii
2023-11-09  8:53                         ` tomas
2023-11-09  9:18                         ` Harald Judt
2023-11-09 14:52                           ` Harald Judt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c26d5591-389f-4096-b0b7-01db5bca3a87@gmx.at \
    --to=h.judt@gmx.at \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=philipk@posteo.net \
    --cc=stefankangas@gmail.com \
    --cc=visuweshm@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.