From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.devel Subject: RE: [patch] Run occur command restricted to a region Date: Thu, 29 Dec 2016 10:16:32 -0800 (PST) Message-ID: References: <87vau3jl6f.fsf@gmail.com> <8337h6vhr7.fsf@gnu.org> <87shp665hf.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1483035422 7868 195.159.176.226 (29 Dec 2016 18:17:02 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 29 Dec 2016 18:17:02 +0000 (UTC) Cc: emacs-devel@gnu.org To: Tino Calancha , Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Dec 29 19:16:58 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cMfG3-0001Mv-Pj for ged-emacs-devel@m.gmane.org; Thu, 29 Dec 2016 19:16:55 +0100 Original-Received: from localhost ([::1]:36816 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cMfG8-0005jd-M2 for ged-emacs-devel@m.gmane.org; Thu, 29 Dec 2016 13:17:00 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45531) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cMfG2-0005jF-Bx for emacs-devel@gnu.org; Thu, 29 Dec 2016 13:16:55 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cMfG1-0006lP-Mo for emacs-devel@gnu.org; Thu, 29 Dec 2016 13:16:54 -0500 Original-Received: from aserp1040.oracle.com ([141.146.126.69]:44868) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cMfFv-0006kW-UM; Thu, 29 Dec 2016 13:16:48 -0500 Original-Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id uBTIGiTU011948 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 29 Dec 2016 18:16:45 GMT Original-Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserv0021.oracle.com (8.13.8/8.14.4) with ESMTP id uBTIGiC2010151 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 29 Dec 2016 18:16:44 GMT Original-Received: from abhmp0010.oracle.com (abhmp0010.oracle.com [141.146.116.16]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id uBTIGiLM031046; Thu, 29 Dec 2016 18:16:44 GMT In-Reply-To: <87shp665hf.fsf@gmail.com> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 12.0.6753.5000 (x86)] X-Source-IP: aserv0021.oracle.com [141.146.126.233] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] [fuzzy] X-Received-From: 141.146.126.69 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:210967 Archived-At: > (define-key search-map "o" 'occur) > +(define-key search-map "b" 'occur-backward) > +(define-key search-map "f" 'occur-forward) FWIW, I don't think those keys (`M-s b' and `M-s f') should be bound to those commands. If we want to bind the new commands during Isearch then I suggest that the occur commands be grouped on prefix key `M-s o': M-s oo occur M-s ob occur-backward M-s of occur-backward `M-s' is a _general_ search prefix key. There is nothing particularly mnemonic about `b' or `f' being `occur-backward' or `occur-forward'. And we should not sacrifice 3 `M-s' keys to these commands. I, and perhaps other users, and perhaps in the future vanilla Emacs, have other bindings on `M-s'. And `M-s' bindings can be anything at all related to the encompassing context of searching.