From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: discoverability, better defaults and which-key in Emacs Date: Sun, 11 Feb 2024 14:30:49 +0200 Message-ID: References: <874jetaxri.fsf@jeremybryant.net> <87r0hridvr.fsf@posteo.net> <5dd3d04c-c0eb-43fe-b7c2-957f80261ea3@gutov.dev> <87eddqiw84.fsf@posteo.net> <32071337-c91d-46ad-bb9b-10b8d0c83965@gutov.dev> <86h6ikzc38.fsf@gnu.org> <1056a72d-af5c-487e-be33-67522fe47d17@gutov.dev> <87r0hnohgv.fsf@gmail.com> <86a5obxwy9.fsf@gnu.org> <61ffccc8-56c0-4b14-9420-2d0fd9cac216@gutov.dev> <86r0hnw1l1.fsf@gnu.org> <86o7crvza4.fsf@gnu.org> <941e2791-bb35-4de6-b7a7-e3dce4938a1d@gutov.dev> <8c6f06a7-e5e3-499a-88c4-d2b035262c4d@gutov.dev> <2dab155b-05a1-4672-b327-680a683f63e4@gutov.dev> <87ttmf207f.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27250"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: Eli Zaretskii , visuweshm@gmail.com, justin@burkett.cc, philipk@posteo.net, jb@jeremybryant.net, emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Feb 11 13:32:21 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rZ90N-0006mz-Tr for ged-emacs-devel@m.gmane-mx.org; Sun, 11 Feb 2024 13:32:20 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rZ8zH-0008OE-TM; Sun, 11 Feb 2024 07:31:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rZ8z3-0007vT-Br for emacs-devel@gnu.org; Sun, 11 Feb 2024 07:31:04 -0500 Original-Received: from wout4-smtp.messagingengine.com ([64.147.123.20]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rZ8z1-0006dR-Ol; Sun, 11 Feb 2024 07:30:57 -0500 Original-Received: from compute7.internal (compute7.nyi.internal [10.202.2.48]) by mailout.west.internal (Postfix) with ESMTP id 3C15D3200A06; Sun, 11 Feb 2024 07:30:53 -0500 (EST) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Sun, 11 Feb 2024 07:30:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1707654652; x=1707741052; bh=iMH1pouKAJCC3lxdfM1r8ieq6nibAAdXhBdh0rCaMm4=; b= iEhPQ/7/WYpQAVuerh10u32H62hdViBBF/O3nkY1aar3OsKCc+fGO0YItF87eVsi wN22jQlXQ1PdTz6kWHoyHXu330wv9B5SZjy6uakHyvd+GKq/mOdlVQ9E5QDxnPry e68/VvtDjmq4HTdvBpfoZuJ9TbnDwgB6pFEgCMbNHLYverIKgzvRP2fUZbR4NkFA Nmh+BsWIyH0iyCX2nxg6HsK/FZwQw+S4LbFDX0Y7fMSh7looOUnn6urS/eFdsB1C gdBQsUkMQQh92OvcGDVRSLjaUbgURefE7+ushX3k2Opm37YHjzIwmqCl7XR1vkEC 6SWSoQGrvSj/TKug3HxrEQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1707654652; x= 1707741052; bh=iMH1pouKAJCC3lxdfM1r8ieq6nibAAdXhBdh0rCaMm4=; b=k 1xAmYO0uAvjQqCt0jW4Jloihm6QNGnKxh97r8W3JfUqVmTE+9w6J46VvQKJLDP7q mrXVI/H053Y/szJILN5f2RAn9n7TtJXz+yeO6YpL87spD7BoL4orJ0Ny30yvf4Kn 9pqpScVpbOOgyk6gRREQlfKVNfEUz1K9bxECAUnPpIcp6b7Up2HFOON3emAo/t7S hSxx6lMGIIdOMwWMmgtTTLQVLiR9oI9sr/VhRX92ykp9Voc+kOvG+yxdW2e1O/nq IkIm/yB61XyYcqelzJaJN6u3EBO1/eNXC80gvj7bnOAQLUfuFT+LBiiIYIfKrbP8 DKkusY+pw9wzCVnUeRsZw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledruddugdegvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefkffggfgfuvfevfhfhjggtgfesthejredttddvjeenucfhrhhomhepffhmihht rhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrghtth gvrhhnpeetudeljeegheetgfehgeejkeeuhedvveeikeeufedtvddtveefhfdvveegudej heenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegumh hithhrhiesghhuthhovhdruggvvh X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 11 Feb 2024 07:30:50 -0500 (EST) Content-Language: en-US In-Reply-To: <87ttmf207f.fsf@yahoo.com> Received-SPF: pass client-ip=64.147.123.20; envelope-from=dmitry@gutov.dev; helo=wout4-smtp.messagingengine.com X-Spam_score_int: -36 X-Spam_score: -3.7 X-Spam_bar: --- X-Spam_report: (-3.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H5=-1, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_SBL_A=0.1 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:316112 Archived-At: On 11/02/2024 04:39, Po Lu wrote: > Dmitry Gutov writes: > >> diff --git a/src/keyboard.c b/src/keyboard.c >> index 10cdef67348..8cc1b2ec756 100644 >> --- a/src/keyboard.c >> +++ b/src/keyboard.c >> @@ -594,14 +594,9 @@ echo_dash (void) >> concat2 (KVAR (current_kboard, echo_string), dash)); >> >> if (echo_keystrokes_help) >> - { >> - Lisp_Object help; >> - >> - help = build_string (" (\\`C-h' or \\`' for help)"); >> - kset_echo_string (current_kboard, >> - concat2 (KVAR (current_kboard, echo_string), >> - calln (Qsubstitute_command_keys, help))); >> - } >> + kset_echo_string (current_kboard, >> + calln (intern_c_string ("help--append-keystrokes-help"), >> + KVAR (current_kboard, echo_string))); >> >> echo_now (); >> } > Please replace the call to intern_c_string with a DEFSYM. There's no > good reason not to. Thanks, I'll do that when committing.