From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tino Calancha Newsgroups: gmane.emacs.bugs Subject: bug#22679: 25.0.91; ibuffer-do-shell-command-pipe truncate output Date: Sat, 20 Aug 2016 12:28:46 +0900 Message-ID: References: <7oa66k9es.fsf@fencepost.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1471663763 29227 195.159.176.226 (20 Aug 2016 03:29:23 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 20 Aug 2016 03:29:23 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 Cc: 22679@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Aug 20 05:29:19 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bawyB-0007DQ-Qj for geb-bug-gnu-emacs@m.gmane.org; Sat, 20 Aug 2016 05:29:15 +0200 Original-Received: from localhost ([::1]:59708 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bawy8-00011Q-PN for geb-bug-gnu-emacs@m.gmane.org; Fri, 19 Aug 2016 23:29:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57579) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bawy2-00010X-Kj for bug-gnu-emacs@gnu.org; Fri, 19 Aug 2016 23:29:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bawxy-0004lS-Eq for bug-gnu-emacs@gnu.org; Fri, 19 Aug 2016 23:29:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:36893) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bawxy-0004lO-Bi for bug-gnu-emacs@gnu.org; Fri, 19 Aug 2016 23:29:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bawxy-0004ZX-4J for bug-gnu-emacs@gnu.org; Fri, 19 Aug 2016 23:29:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tino Calancha Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 20 Aug 2016 03:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22679 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 22679-submit@debbugs.gnu.org id=B22679.147166373617564 (code B ref 22679); Sat, 20 Aug 2016 03:29:02 +0000 Original-Received: (at 22679) by debbugs.gnu.org; 20 Aug 2016 03:28:56 +0000 Original-Received: from localhost ([127.0.0.1]:34605 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bawxs-0004ZE-8W for submit@debbugs.gnu.org; Fri, 19 Aug 2016 23:28:56 -0400 Original-Received: from mail-pf0-f176.google.com ([209.85.192.176]:35425) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bawxr-0004Yz-3M for 22679@debbugs.gnu.org; Fri, 19 Aug 2016 23:28:55 -0400 Original-Received: by mail-pf0-f176.google.com with SMTP id x72so14777991pfd.2 for <22679@debbugs.gnu.org>; Fri, 19 Aug 2016 20:28:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=eW6f1Oqav6nxjhICJ7XTWEjdx2AAIR0XHL0WNQ+SI/A=; b=uYzyPJrZBrd/HF+8aioAYTFuOfje8zAU+dAmOg/6wLYCuGmmBXd/boSP0tq6314asd /kAKAWIDNwUblLwzR08Mz3K32QYn45mxLLZ50csGm9SbGB0XE8HZ3G46l6QoXa9mbN62 kpQPJGWvH92q9wnsdTGpnjxCLI0svQ/FRvpf3dyJNE1v264VyroNdfkBv8UwLYfEl6PY RKqHNs7fc7GLHbTweodDd5CSpOXD8QISGt833GOB20BSDPGMN27eO/JzhjLWr0nDfuHo NtqWRaiezifxdi8E5jjYDPJqHSjsbdag4puBWFazz5owcFsCH/91uIEPDtmbCyqLJx6c jRgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=eW6f1Oqav6nxjhICJ7XTWEjdx2AAIR0XHL0WNQ+SI/A=; b=kU0ACHbVyH9GzfgsWz7YtFRB/t+rUEx0S+tMBIR9zqpYk2DmAc/PyFcMdgFipirQh4 wjbur06/al726gHjkvxZYn2LfbZN+FIeHlvhg/C468sS2TJ41YrjPi+hLatnt6NTmiyj XirTkwsjElANOcgtPxuRLhpTIqdAOgertoyYzAeHGCBJ/JUL8j4rlMy2BCcU8g/wU9PJ a+b6OeGhgzV5HI3jekPcCtbFJAObuTg1jygMtkDD1zQkNvT6pzrDdHDWmKYJjOXZyr5j ueCOHAU/LIHP8X0Zj7jJKvkuZRxnTNE3K4d2CQ/2X7SDH658nG0Ylp8gqXBGcXkJsqTt 6bXQ== X-Gm-Message-State: AEkooutijvAx1XLCsAjjJAWAzXq5CWAtsOwL6sVcdy8W9BAOvbE+mWJ3bpcRBVEzSAR8pA== X-Received: by 10.98.93.25 with SMTP id r25mr20374932pfb.122.1471663729553; Fri, 19 Aug 2016 20:28:49 -0700 (PDT) Original-Received: from [10.248.6.9] ([210.160.37.24]) by smtp.gmail.com with ESMTPSA id f84sm9647110pfd.87.2016.08.19.20.28.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 19 Aug 2016 20:28:48 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:122399 Archived-At: On 08/19/2016 10:52 PM, Stefan Monnier wrote: >> - :modifier-p nil) >> - (shell-command-on-region >> - (point-min) (point-max) command)) >> + :modifier-p nil >> + :opstring "Shell command executed on" >> + :modifier-p nil >> + :before (funcall #'ibuffer--before-shell-command) >> + :after (funcall #'ibuffer--after-shell-command)) >> + (let ((out-buf (get-buffer "*Shell Command Output*"))) >> + (with-current-buffer out-buf (goto-char (point-max))) >> + (call-process-region (point-min) (point-max) command nil out-buf))) > I haven't looked at the rest of your patch but this part looks wrong: > the docstring indicates that `command' is expected to be a shell command > whereas call-process-region expects an executable. > > > Stefan Thank you very much. I didn't notice this because i was testing with and executable (cat) as the command. I will start working in a new patch.