From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jens Schmidt via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#64160: bug#64089: 30.0.50; `ldap-search' errors out with `wrong-type-argument listp' when called WITHDN == t Date: Mon, 19 Jun 2023 00:14:34 +0200 Message-ID: References: <83cz1usk0i.fsf@gnu.org> <83legiqy3x.fsf@gnu.org> <83h6r6qwxh.fsf@gnu.org> <704ffb16-a822-8fed-6d63-4d9fc9a2b16e@vodafonemail.de> Reply-To: Jens Schmidt Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24397"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Cc: 64160@debbugs.gnu.org To: Filipp Gunbin Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jun 19 00:15:32 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qB0gF-0006Bk-O7 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 19 Jun 2023 00:15:31 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qB0fu-0001AH-2V; Sun, 18 Jun 2023 18:15:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qB0fn-0001A5-1K for bug-gnu-emacs@gnu.org; Sun, 18 Jun 2023 18:15:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qB0fm-0002ic-Od for bug-gnu-emacs@gnu.org; Sun, 18 Jun 2023 18:15:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qB0fm-0006GQ-5E for bug-gnu-emacs@gnu.org; Sun, 18 Jun 2023 18:15:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jens Schmidt Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 18 Jun 2023 22:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64160 X-GNU-PR-Package: emacs Original-Received: via spool by 64160-submit@debbugs.gnu.org id=B64160.168712649424040 (code B ref 64160); Sun, 18 Jun 2023 22:15:02 +0000 Original-Received: (at 64160) by debbugs.gnu.org; 18 Jun 2023 22:14:54 +0000 Original-Received: from localhost ([127.0.0.1]:55186 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qB0fd-0006Fd-Ux for submit@debbugs.gnu.org; Sun, 18 Jun 2023 18:14:54 -0400 Original-Received: from mr6.vodafonemail.de ([145.253.228.166]:36890) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qB0fb-0006FL-JS for 64160@debbugs.gnu.org; Sun, 18 Jun 2023 18:14:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vodafonemail.de; s=vfde-mb-mr2-21dec; t=1687126485; bh=7wps0NLZ+4zPXTrwbmPWYf/ci4X3Fq4txQPTkUT3GP8=; h=Message-ID:Date:User-Agent:Subject:Content-Language:From:To: References:In-Reply-To:Content-Type:From; b=prZ0rVV4HgOW1DTLoWKxD2SIkHm19ITnFBnsRVrJD2ScPDOifXdvpBsyBRvSga2yU m4EUbDslPW16SQFgivKgfoo8l+nnRu9xt1K89y8+qPAbOGcaJPWt5l3coluUyZQ82Q 3ACUcQPYOTLJ+XcNmChFqOq9bpGzYcV5tjphvPBU= Original-Received: from smtp.vodafone.de (unknown [10.0.0.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by mr6.vodafonemail.de (Postfix) with ESMTPS id 4QknJ50XJxz1xxP; Sun, 18 Jun 2023 22:14:45 +0000 (UTC) Original-Received: from [192.168.178.41] (port-92-194-48-156.dynamic.as20676.net [92.194.48.156]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp.vodafone.de (Postfix) with ESMTPSA id 4QknHx4Sr0zHpxd; Sun, 18 Jun 2023 22:14:34 +0000 (UTC) Content-Language: de-DE-frami, en-US In-Reply-To: <704ffb16-a822-8fed-6d63-4d9fc9a2b16e@vodafonemail.de> X-purgate-type: clean X-purgate: clean X-purgate-size: 1435 X-purgate-ID: 155817::1687126480-49FFCD81-42B4F5DB/0/0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:263661 Archived-At: Hi Filipp, On 2023-06-18 09:43, Jens Schmidt wrote: > [...] In any case, I'll open a new bug for that to continue this > discussion. here is the bug I've opened as master tracking bug: bug#64160 (CCed as well). I'd appreciate contributing together with you, and your hint on the role of `ldap-ignore-attribute-codings' was really helpful, thanks. But some others of the changes you have been proposing were not very helpful for what I have in mind. For example: > 3) (unrelated, just noticed and fixed) Match data clobbering in this > piece: > > - ;; Need to handle file:///D:/... as generated by OpenLDAP > - ;; on DOS/Windows as local files. > - (if (and (memq system-type '(windows-nt ms-dos)) > - (eq (string-match "/\\(.:.*\\)$" value) 0)) > - (setq value (match-string 1 value))) This piece of code handling temp files on DOS/Windows should in my opinion be moved into the following `(if (match-string 3) ...' clause, which handles temp files in general. (In that case the `save-match-data' would no longer be required, BTW.) On 2023-06-17 00:13, Filipp Gunbin wrote: > Please give it a try, if it's OK and others have no objections, I'll > install it on Monday (on master, I guess). So could you please wait with your commit until we have something worked out that works for all? Thanks!