From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: next-error use cases Date: Tue, 19 May 2020 04:10:51 +0300 Message-ID: References: <87zi2esn7l.fsf@mail.linkov.net> <87r2nknpaz.fsf@mail.linkov.net> <83y3hr5z35.fsf@gnu.org> <87d0z2anv8.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="50117"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 Cc: emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue May 19 03:11:43 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jaqnH-000CwJ-4o for ged-emacs-devel@m.gmane-mx.org; Tue, 19 May 2020 03:11:43 +0200 Original-Received: from localhost ([::1]:52410 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jaqnG-0006Iu-1O for ged-emacs-devel@m.gmane-mx.org; Mon, 18 May 2020 21:11:42 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37230) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jaqmW-0005sQ-OC for emacs-devel@gnu.org; Mon, 18 May 2020 21:10:56 -0400 Original-Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]:39162) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jaqmV-0002uX-Kb for emacs-devel@gnu.org; Mon, 18 May 2020 21:10:56 -0400 Original-Received: by mail-wr1-x430.google.com with SMTP id l18so13933494wrn.6 for ; Mon, 18 May 2020 18:10:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=2EcS3sbQCb6Osl6JNwY41Kc6VILEWXNbtbnu4jDu9QM=; b=kqyTWy0YHBOAGxQwEIVIqYnF/X23dV/EIQEi4KyRbnm/to+OEWENDPufG1h8CJocix VcNwOsGMG5r1LFMUCf7yLwuYUFaaUU1hx5K4SW4gPhIP3eVRFtFjupH+l3+WONp5qinT lRhr6UFonvftpFC/wLuCVLInlwowzYAEIRgmxG6rDwWaXF3ePo5HgyUaVMrr7Z1hJZC+ vzqCjcMYep8WES5+n/AnlTJJJMMyCylp1ty1Bdx1o/sWn5pWc3rOoOX5CzrpyiUwYFhW mrp2Fw7uU5+HT6y3qR2VNlX9c8ohx4USadwiOa+VmxF6AZ9p2JhE7kGH7DgW+Lj2rWd4 DvrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=2EcS3sbQCb6Osl6JNwY41Kc6VILEWXNbtbnu4jDu9QM=; b=Y9lkFXyoREh1wJ5T7v7pE/JGi/CbkpvyAuzP4NooR0eyNEJwvm5RRZhCtvxvoGES6y ktjB62OwOsE6zt4advhq+oq42Ut/azrvbfj6/XZcqKOuYytWdqrnDxFy+x/XD8rQfGEJ jC5bmfTE2/QcqyY4AgN7JHAuy6G+2jza7Psa/EUMfnMQAQ1fe8qeZnhroN+j5iijEZ2s EBNj8/soGRbcB8SuHSoJnqIOAqi3gwK54OtXK+2RlMAgeOV8nHUokUBVsXBMqUK7bVdg +O5arBZuXv+cVsslN8KGKnUOhQKY08VRANM6w3TCbF8g/sALo2LNmuN4ZTtXq2JEOJTg QIGQ== X-Gm-Message-State: AOAM5300mjluw9pjQ6K1axhiBmGZC/oeB63QK6TaFGgYqjZOcINY8MyA mD4JJgJVgSxNrGTcnbRyF3pfxC3G X-Google-Smtp-Source: ABdhPJz94hCi5iLuUKG54AJbA4iVHGmB56xK5yp2vzksQv66wbRi6lRHfAkjjyl5w14eRSX5GNNrkA== X-Received: by 2002:a05:6000:4:: with SMTP id h4mr22340701wrx.36.1589850653227; Mon, 18 May 2020 18:10:53 -0700 (PDT) Original-Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id v5sm18575564wrr.93.2020.05.18.18.10.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 May 2020 18:10:52 -0700 (PDT) In-Reply-To: <87d0z2anv8.fsf@mail.linkov.net> Content-Language: en-US Received-SPF: pass client-ip=2a00:1450:4864:20::430; envelope-from=raaahh@gmail.com; helo=mail-wr1-x430.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:250843 Archived-At: Hi Juri, On 13.04.2018 22:48, Juri Linkov wrote: > in*xref* xref-goto-xref: RET > in*Diff* diff-goto-source: RET, C-c C-c, o > in ChangeLogs change-log-goto-source: C-c C-c > in*Occur* occur-mode-goto-occurrence: RET, C-c C-c, > occur-mode-goto-occurrence-other-window: o > occur-mode-display-occurrence: C-o Only 2 years passed, and I finally read the new code. I have to say it's a solid improvement over the previous related change. And one peculiarity: if I'm not mistaken, the value of next-error-buffer itself is never used in the current code, there's only the check (local-variable-p 'next-error-buffer) that references it, effectively turning it into a buffer-local boolean. But it could probably still be used in custom values of next-error-find-buffer-function. Too bad it didn't solve the flymake+next-error-function problem, but that seems more difficult. Some rough idea: pick some similar keybinding in flymake-supported buffers ('C-c C-c'? wouldn't it be too presumptuous to take over?)... and make it, I don't know, echo the error text? Or (!) show the diagnostics buffer, for which there's no default key binding still. And in the end, call next-error-found.