Re: [ELPA] CSS improvements

[Adam Porter <adam@alphapapa.net>]

[-- Attachment #1: Type: text/plain, Size: 1401 bytes --]

Hi Stefan, Philip,

On 9/11/22 10:04, Philip Kaludercic wrote:
> Stefan Monnier <monnier@iro.umontreal.ca> writes:

>>> Btw, Adam it seems there is some peculiar rendering just below
>>> the "2. Usage" title:  On GitHub there appears to be a manual
>>> TOC, while on the elpa.gnu.org it appears as a list with three
>>> empty elements.

Yes, that's caused by the table of contents in the readme, which is
generated for GitHub's renderer, which isn't compatible with Org's
exporter.  I'm not yet sure how to solve that problem, but I will when I
can.

>> Great, thanks, installed.

Thanks.

>> BTW, regarding the second patch: I'm no fan of underline, so it'd
>> be nice to find some other solution (bold maybe?).

Agreed.  I chose underline at first, because making H4s bold caused them 
to stand out more than H3s.  The new patches attached here make both H3 
and H4 bold, which seems to look good.  H5s remain italic.

>> Also, in that ement.html page, I see now that the "2.1 Bindings"
>> heading is underlined, but the "2.1.1 Room buffers" is left
>> unchanged whereas the patch seemed to want to make it italics.
>> 
>> Is it a problem in the CSS or am I missing something?
> 
> Yes there is, italics are set using "font-style: italic", not 
> "text-decoration".

Well, that's embarrassing.  Apparently I hadn't written CSS in too long. 
  The attached patches correct that as well.

Thanks,
Adam

[-- Attachment #2: 0001-html-layout.css-p-Improve-margins.patch --]
[-- Type: text/x-patch, Size: 803 bytes --]

From c846798ff3f4cb19308c875cc37bf0a48537aa6d Mon Sep 17 00:00:00 2001
From: Adam Porter <adam@alphapapa.net>
Date: Sun, 11 Sep 2022 08:25:48 -0500
Subject: [PATCH 1/2] * html/layout.css (p): Improve margins

Previously, paragraphs only had bottom margins, which caused them to
have nearly no spacing between them and other, non-paragraph page
elements.  This change maintains the same spacing between paragraphs,
while adding space after other elements, which looks *much* better.
---
 html/layout.css | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/html/layout.css b/html/layout.css
index 48f9aa5fc7..59d88a3bec 100644
--- a/html/layout.css
+++ b/html/layout.css
@@ -127,7 +127,7 @@ pre .kw {
 }
 
 p {
-  margin-bottom: 2em;
+  margin: 1em 0 1em 0;
 }
 
 p.centered {
-- 
2.34.0


[-- Attachment #3: 0002-html-layout.css-h4-h5-Margins-decoration-weight-styl.patch --]
[-- Type: text/x-patch, Size: 890 bytes --]

From 4b09b19b6953d84fc6aee63167d180815ade030b Mon Sep 17 00:00:00 2001
From: Adam Porter <adam@alphapapa.net>
Date: Sun, 11 Sep 2022 08:33:51 -0500
Subject: [PATCH 2/2] * html/layout.css (h4, h5): Margins, decoration, weight,
 style

The margin changes add whitespace after other page elements, matching
the margins of other heading levels.  The other changes visually
distinguish them from normal body text.  The result is much more
readable.
---
 html/layout.css | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/html/layout.css b/html/layout.css
index 59d88a3bec..f7fd276900 100644
--- a/html/layout.css
+++ b/html/layout.css
@@ -90,8 +90,17 @@ h2 {
 
 h3 {
   font-size: 1.5em;
+  font-weight: bold;
   margin: 1.2em 0px;
 }
+h4 {
+  margin: 1em 0px;
+  text-decoration: underline;
+}
+h5 {
+  margin: 1em 0px;
+  font-style: italic;
+}
 
 a {
   color: #c73a6c;
-- 
2.34.0