From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#17397: 24.4.50; REGRESSION: `temp-buffer-show-hook' is no longer invoked for `describe-variable' Date: Tue, 13 May 2014 14:24:43 -0700 (PDT) Message-ID: References: <18354a80-fa76-43bd-a06b-7d2c4ccbbfd4@default> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1400016334 11364 80.91.229.3 (13 May 2014 21:25:34 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 13 May 2014 21:25:34 +0000 (UTC) To: 17397@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue May 13 23:25:26 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WkKCT-0001p0-Ka for geb-bug-gnu-emacs@m.gmane.org; Tue, 13 May 2014 23:25:25 +0200 Original-Received: from localhost ([::1]:48034 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WkKCS-0000ns-W2 for geb-bug-gnu-emacs@m.gmane.org; Tue, 13 May 2014 17:25:24 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41031) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WkKCF-0000Vs-S1 for bug-gnu-emacs@gnu.org; Tue, 13 May 2014 17:25:20 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WkKC7-0007RT-4B for bug-gnu-emacs@gnu.org; Tue, 13 May 2014 17:25:11 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:45310) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WkKC7-0007R8-0D for bug-gnu-emacs@gnu.org; Tue, 13 May 2014 17:25:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WkKC5-0002yD-WB for bug-gnu-emacs@gnu.org; Tue, 13 May 2014 17:25:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 May 2014 21:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17397 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 17397-submit@debbugs.gnu.org id=B17397.140001629511398 (code B ref 17397); Tue, 13 May 2014 21:25:01 +0000 Original-Received: (at 17397) by debbugs.gnu.org; 13 May 2014 21:24:55 +0000 Original-Received: from localhost ([127.0.0.1]:34428 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WkKBy-0002xl-Em for submit@debbugs.gnu.org; Tue, 13 May 2014 17:24:54 -0400 Original-Received: from aserp1040.oracle.com ([141.146.126.69]:32564) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WkKBv-0002xV-Np for 17397@debbugs.gnu.org; Tue, 13 May 2014 17:24:52 -0400 Original-Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id s4DLOii4022482 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for <17397@debbugs.gnu.org>; Tue, 13 May 2014 21:24:45 GMT Original-Received: from aserz7022.oracle.com (aserz7022.oracle.com [141.146.126.231]) by ucsinet22.oracle.com (8.14.5+Sun/8.14.5) with ESMTP id s4DLOhnl003649 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for <17397@debbugs.gnu.org>; Tue, 13 May 2014 21:24:44 GMT Original-Received: from abhmp0019.oracle.com (abhmp0019.oracle.com [141.146.116.25]) by aserz7022.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s4DLOh4I016270 for <17397@debbugs.gnu.org>; Tue, 13 May 2014 21:24:43 GMT In-Reply-To: <18354a80-fa76-43bd-a06b-7d2c4ccbbfd4@default> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8 (707110) [OL 12.0.6691.5000 (x86)] X-Source-IP: ucsinet22.oracle.com [156.151.31.94] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:89048 Archived-At: I would really like to get some help with this. So far, no response at all. Help functions using buffer *Help* previously used `with-output-to-temp-buffer', which runs `temp-buffer-setup-hook' and `temp-buffer-show-hook'. And previously the setup hook usually put the buffer in help mode. Now, *Help* is set up by `with-help-window', and neither of those hooks is run by it. This is a regression, to me - any code or any user who relies on those hooks being run for *Help* buffers is up the creek without a paddle, AFAICS. So be it. But what is that code or that user supposed to do now? `with-help-window' invokes `with-temp-buffer-window', which runs `temp-buffer-window-setup-hook' and `temp-buffer-window-show-hook'. To get *Help* to DTRT for the code or user that previously used `temp-buffer-setup-hook' or `temp-buffer-show-hook, is it appropriate to put the same things on `temp-buffer-window-setup-hook' and `temp-buffer-window-show-hook' instead? Or will that maybe have unwanted effects because `with-temp-buffer-window' is perhaps used for more than just *Help*? Not clear to me. And I find no help in the doc or NEWS - or in this bug thread, so far. Should I be adding `fit-frame-if-one-window' to `temp-buffer-window' for Emacs 24.4, to get the effect it has in Emacs 24.3 (and prior) by being on `temp-buffer-show-hook'? If not, how to get the same effect? If yes, how to deal with other possible uses of `with-temp-buffer-window', which have nothing to do with *Help*? (In the case of `fit-frame-if-one-window', that would probably not hurt anything, but the question is more general.) -- The existing doc is anyway wrong in some cases, AFAICT: The doc string of `with-temp-buffer-window' says: This construct is similar to `with-output-to-temp-buffer' but, neither runs `temp-buffer-setup-hook' which usually puts the buffer in Help mode, nor `temp-buffer-show-function' (the ACTION argument replaces this). And the doc string of `temp-buffer-setup-hook', likewise, says: This hook is normally set up with a function to put the buffer in Help mode. I don't get the impression that either of those statements is true anymore. It seems like there is *no relation* anymore between such temp-buffer things and Help mode. Furthermore, grepping for `temp-buffer-setup-hook' in the Emacs sources shows that it is not used for this at all anymore. A little help, please.